This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Make system-include-extractor.test more resilient in the face of paths with special characters
AbandonedPublic

Authored by nridge on Nov 8 2022, 2:45 PM.

Details

Reviewers
ayzhao
sammccall

Diff Detail

Event Timeline

nridge created this revision.Nov 8 2022, 2:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2022, 2:45 PM
nridge requested review of this revision.Nov 8 2022, 2:45 PM
sammccall accepted this revision.Nov 8 2022, 2:49 PM
sammccall added a subscriber: sammccall.

LG, I committed https://github.com/llvm/llvm-project/commit/96d771c4707df9b3153ea5a8451f2bbbe17c8917 but was too lazy to add the comment, feel free to land this or not.

This revision is now accepted and ready to land.Nov 8 2022, 2:49 PM
ayzhao accepted this revision.Nov 8 2022, 2:51 PM

Thanks for the quick fix! I patched this in and I can confirm it fixes the issue.

nridge abandoned this revision.Nov 8 2022, 2:55 PM

Great minds :)