This is an archive of the discontinued LLVM Phabricator instance.

[LangRef][LoongArch] Update inline asm constraint code and operand modifier
ClosedPublic

Authored by XiaodongLoong on Nov 6 2022, 10:13 PM.

Diff Detail

Event Timeline

XiaodongLoong created this revision.Nov 6 2022, 10:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2022, 10:13 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript
XiaodongLoong requested review of this revision.Nov 6 2022, 10:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2022, 10:13 PM
SixWeining accepted this revision.Nov 6 2022, 10:30 PM

LGTM but I'm not sure if we should add/wait reviewers relevant to doc changes.

This revision is now accepted and ready to land.Nov 6 2022, 10:30 PM
xen0n added a comment.Nov 6 2022, 10:49 PM

LGTM but I'm not sure if we should add/wait reviewers relevant to doc changes.

I think so.

And I believe some of the recently added constraints are missing, such as J. They should be synced here as well.

Add 'J' constraint code.

XiaodongLoong retitled this revision from [doc][LoongArch] Update inline asm constraint code and operand modifier to [LangRef][LoongArch] Update inline asm constraint code and operand modifier.Nov 7 2022, 6:38 PM
XiaodongLoong edited the summary of this revision. (Show Details)

As shown in the patch https://github.com/llvm/llvm-project/commit/ee3aef93b73646ef98f0241498d807a4fb68b78c, I think we can add other constraint code or operand modifier in other patches.
The reviewers who accepted the patch above concentrate on RISCV backend. Maybe, we can commit this patch directly.