Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
No specific opinion on this from my side - if it works for all clang-cl and mingw configs in CI, it's most probably fine with me. But CI seems to have not run correctly - it seems to have run before the parent patch was set up, so it failed to apply the patch. Rerunning it, now that the parent relationship is set up already, should hopefully make it apply it correctly and run the tests.
Comment Actions
LGTM if CI is happy. This seems to basically removes copy-pasted code which isn't relevant anymore now that we're using Clang builtins.