Page MenuHomePhabricator

[libc++][math.h] Remove some code duplication
ClosedPublic

Authored by philnik on Nov 5 2022, 1:55 PM.

Diff Detail

Event Timeline

philnik created this revision.Nov 5 2022, 1:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 5 2022, 1:55 PM
philnik requested review of this revision.Nov 5 2022, 1:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 5 2022, 1:55 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

No specific opinion on this from my side - if it works for all clang-cl and mingw configs in CI, it's most probably fine with me. But CI seems to have not run correctly - it seems to have run before the parent patch was set up, so it failed to apply the patch. Rerunning it, now that the parent relationship is set up already, should hopefully make it apply it correctly and run the tests.

ldionne accepted this revision.Nov 21 2022, 8:24 AM

LGTM if CI is happy. This seems to basically removes copy-pasted code which isn't relevant anymore now that we're using Clang builtins.

This revision is now accepted and ready to land.Nov 21 2022, 8:24 AM
This revision was automatically updated to reflect the committed changes.