This is an archive of the discontinued LLVM Phabricator instance.

Differential D136556

[mlir] Support overriding LLVM_LIT_ARGS in standalone builds
ClosedPublic

Authored by mgorny on Oct 23 2022, 10:11 AM.

Details

Reviewers
mehdi_amini
MaskRay
Commits
rGf3713a9047df: [mlir] Support overriding LLVM_LIT_ARGS in standalone builds
Summary

Introduce LLVM_LIT_ARGS cache variable in standalone builds, to let
the caller override the options passed by LLVM to lit calls. Once
defined, this is automatically handled by LLVM's cmake logic.

Diff Detail

Event Timeline

mgorny created this revision.Oct 23 2022, 10:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 23 2022, 10:11 AM
Herald added subscribers: zero9178, bzcheeseman, sdasgup3 and 19 others. · View Herald Transcript
mgorny requested review of this revision.Oct 23 2022, 10:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 23 2022, 10:11 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B193814: Diff 469990.Oct 23 2022, 10:37 AM
mehdi_amini accepted this revision.Oct 23 2022, 4:23 PM
This revision is now accepted and ready to land.Oct 23 2022, 4:23 PM
Closed by commit rGf3713a9047df: [mlir] Support overriding LLVM_LIT_ARGS in standalone builds (authored by mgorny). · Explain WhyOct 23 2022, 8:15 PM
This revision was automatically updated to reflect the committed changes.
mgorny added a commit: rGf3713a9047df: [mlir] Support overriding LLVM_LIT_ARGS in standalone builds.
mgorny added a comment.Oct 23 2022, 8:15 PM

Thanks!

Revision Contents

PathSize
mlir/
2 lines

Diff 469990

mlir/CMakeLists.txt

Show All 24 Linesif(MLIR_STANDALONE_BUILD)
set(UNITTEST_DIR ${LLVM_MAIN_SRC_DIR}/utils/unittest) set(UNITTEST_DIR ${LLVM_MAIN_SRC_DIR}/utils/unittest)
if(EXISTS ${UNITTEST_DIR}/googletest/include/gtest/gtest.h) if(EXISTS ${UNITTEST_DIR}/googletest/include/gtest/gtest.h)
add_subdirectory(${UNITTEST_DIR} utils/unittest) add_subdirectory(${UNITTEST_DIR} utils/unittest)
endif() endif()
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY set(CMAKE_LIBRARY_OUTPUT_DIRECTORY
"${CMAKE_CURRENT_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}") "${CMAKE_CURRENT_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}")
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/bin") set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/bin")
set(LLVM_LIT_ARGS "-sv" CACHE STRING "Default options for lit")
endif() endif()
set(MLIR_TOOLS_INSTALL_DIR "${CMAKE_INSTALL_BINDIR}" CACHE PATH set(MLIR_TOOLS_INSTALL_DIR "${CMAKE_INSTALL_BINDIR}" CACHE PATH
"Path for binary subdirectory (defaults to '${CMAKE_INSTALL_BINDIR}')") "Path for binary subdirectory (defaults to '${CMAKE_INSTALL_BINDIR}')")
mark_as_advanced(MLIR_TOOLS_INSTALL_DIR) mark_as_advanced(MLIR_TOOLS_INSTALL_DIR)
set(MLIR_MAIN_SRC_DIR ${CMAKE_CURRENT_SOURCE_DIR} ) set(MLIR_MAIN_SRC_DIR ${CMAKE_CURRENT_SOURCE_DIR} )
set(MLIR_MAIN_INCLUDE_DIR ${MLIR_MAIN_SRC_DIR}/include ) set(MLIR_MAIN_INCLUDE_DIR ${MLIR_MAIN_SRC_DIR}/include )
▲ Show 20 Lines • Show All 226 Lines • Show Last 20 Lines