[Verifier] Relieve intrinsics parameter alignment size constrain

[LuoYuanke]

Summary

In D121898 we restrict parameter alignment size in IR since DAGISel
only have 4 bits to hold the alignment value. However intrinsics
won't be lowered to call instruction, so we can remove the constrain
for intrinsics.

[dmgreen]

Thanks for the patch. Could it use a simpler intrinsic for the test? Maybe a llvm.fshr.v8192i32?

[LuoYuanke]

Address @dmgreen's comments

[skan]

llvm/lib/IR/Verifier.cpp

3228–3230

Why do we need this check? Is there a LIT test for it?

[LuoYuanke]

llvm/lib/IR/Verifier.cpp

3228–3230

This is the original code, and I just move it above VerifyTypeAlign check. See the left line 3240 ~ 3245.

[skan]

LGTM

[dmgreen]

Thanks for the update. LGTM.

llvm/lib/IR/Verifier.cpp

Check(Call.getArgOperand(i)->getType() == FTy->getParamType(i),
           "Call parameter type does not match function signature!",
           Call.getArgOperand(i), FTy->getParamType(i), Call);
 
   AttributeList Attrs = Call.getAttributes();
 
   Check(verifyAttributeCount(Attrs, Call.arg_size()),
         "Attribute after last parameter!", Call);
 
+  Function *Callee =
+      dyn_cast<Function>(Call.getCalledOperand()->stripPointerCasts());
+  bool IsIntrinsic = Callee && Callee->isIntrinsic();
+  if (IsIntrinsic)
+    Check(Callee->getValueType() == FTy,
+          "Intrinsic called with incompatible signature", Call);
+
   auto VerifyTypeAlign = [&](Type *Ty, const Twine &Message) {
     if (!Ty->isSized())
       return;
     Align ABIAlign = DL.getABITypeAlign(Ty);
     Align MaxAlign(ParamMaxAlignment);
     Check(ABIAlign <= MaxAlign,
           "Incorrect alignment of " + Message + " to called function!", Call);
   };
 
+  if (!IsIntrinsic) {
     VerifyTypeAlign(FTy->getReturnType(), "return type");
     for (unsigned i = 0, e = FTy->getNumParams(); i != e; ++i) {
       Type *Ty = FTy->getParamType(i);
       VerifyTypeAlign(Ty, "argument passed");
     }
-
-  Function *Callee =
-      dyn_cast<Function>(Call.getCalledOperand()->stripPointerCasts());
-  bool IsIntrinsic = Callee && Callee->isIntrinsic();
-  if (IsIntrinsic)
-    Check(Callee->getValueType() == FTy,
-          "Intrinsic called with incompatible signature", Call);
+  }
 
   if (Attrs.hasFnAttr(Attribute::Speculatable)) {
     // Don't allow speculatable on call sites, unless the underlying function
     // declaration is also speculatable.
     Check(Callee && Callee->isSpeculatable(),
           "speculatable attribute may not apply to call sites", Call);
   }
 

llvm/test/Verifier/param-align.ll

 ; RUN: not llvm-as < %s 2>&1 | FileCheck %s
 
+; Large vector for intrinsics is valid
+; CHECK-NOT: llvm.fshr
+define dso_local <8192 x i32> @test_intrin(<8192 x i32> %l, <8192 x i32> %r, <8192 x i32> %amt) {
+entry:
+  %b = call <8192 x i32> @llvm.fshr.v8192i32(<8192 x i32> %l, <8192 x i32> %r, <8192 x i32> %amt)
+  ret <8192 x i32> %b
+}
+declare <8192 x i32> @llvm.fshr.v8192i32 (<8192 x i32> %l, <8192 x i32> %r, <8192 x i32> %amt)
+
 ; CHECK: Incorrect alignment of argument passed to called function!
+; CHECK: bar
 define dso_local void @foo(<8192 x float> noundef %vec) {
 entry:
   call void @bar(<8192 x float> %vec)
   ret void
 }
 
 declare dso_local void @bar(<8192 x float>)

llvm/test/Verifier/param-ret-align.ll

 ; RUN: not llvm-as < %s 2>&1 | FileCheck %s
 
+; Large vector for intrinsics is valid
+; CHECK-NOT: llvm.fshr
+define dso_local <8192 x i32> @test_intrin(<8192 x i32> %l, <8192 x i32> %r, <8192 x i32> %amt) {
+entry:
+  %b = call <8192 x i32> @llvm.fshr.v8192i32(<8192 x i32> %l, <8192 x i32> %r, <8192 x i32> %amt)
+  ret <8192 x i32> %b
+}
+declare <8192 x i32> @llvm.fshr.v8192i32 (<8192 x i32> %l, <8192 x i32> %r, <8192 x i32> %amt)
+
 ; CHECK: Incorrect alignment of return type to called function!
+; CHECK: bar
 define dso_local void @foo() {
 entry:
   call <8192 x float> @bar()
   ret void
 }
 
 declare dso_local <8192 x float> @bar()