This is an archive of the discontinued LLVM Phabricator instance.

[flang] Fix missing generated includes in out of tree build
ClosedPublic

Authored by DavidSpickett on Oct 19 2022, 5:25 AM.

Details

Summary

875fd9df76ded4a88a3a44b690f290ea98f91705 added a new dialect
with some generated files.

When flang is built out of tree (build llvm/clang/mlir first, then
build flang pointing at the first build) those files were not created
at all.

I don't 100% understand why not but juding by the comment at the top
of the file, add_mlir_interface probably expects to run in an MLIR
directory, as add_mlir_dialect does.

So in the same way, I've just inlined enough of that function to
fix the out of tree build.

Diff Detail

Event Timeline

DavidSpickett created this revision.Oct 19 2022, 5:25 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 19 2022, 5:25 AM
DavidSpickett requested review of this revision.Oct 19 2022, 5:25 AM
jeanPerier accepted this revision.Oct 19 2022, 6:06 AM

Thanks a lot for identifying and fixing the issue !

This revision is now accepted and ready to land.Oct 19 2022, 6:06 AM