This is an archive of the discontinued LLVM Phabricator instance.

Differential D136239

[testcase] [OpenMP] Fix the testcase error of check-all when DCLANG_DEFAULT_OPENMP_RUNTIME is not libomp
ClosedPublic

Authored by zixuan-wu on Oct 19 2022, 3:15 AM.

Details

Reviewers
jdoerfert
MaskRay
Commits
rG55c2137939d8: [testcase][OpenMP] Fix the testcase error of check-all when…
Summary

When DCLANG_DEFAULT_OPENMP_RUNTIME is set to libgomp, there is some check-all error. The expected CHECK result only displays when fopenmp=libomp is specified explicitly.

Diff Detail

Event Timeline

zixuan-wu created this revision.Oct 19 2022, 3:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2022, 3:15 AM
Herald added subscribers: StephenFan, arphaman, guansong, yaxunl. · View Herald Transcript
zixuan-wu requested review of this revision.Oct 19 2022, 3:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2022, 3:15 AM
Herald added subscribers: cfe-commits, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B192954: Diff 468839.Oct 19 2022, 4:00 AM
jdoerfert accepted this revision.Oct 19 2022, 10:16 AM

LG

This revision is now accepted and ready to land.Oct 19 2022, 10:16 AM
Closed by commit rG55c2137939d8: [testcase][OpenMP] Fix the testcase error of check-all when… (authored by zixuan-wu). · Explain WhyOct 19 2022, 7:19 PM
This revision was automatically updated to reflect the committed changes.
zixuan-wu added a commit: rG55c2137939d8: [testcase][OpenMP] Fix the testcase error of check-all when….

Revision Contents

PathSize
clang/
test/
Driver/
2 lines
Index/
2 lines

Diff 469102

clang/test/Driver/fopenmp.c

Show First 20 Lines • Show All 134 Lines • ▼ Show 20 Lines
// CHECK-LD-STATIC-IOMP5: "{{.*}}ld{{(.exe)?}}" // CHECK-LD-STATIC-IOMP5: "{{.*}}ld{{(.exe)?}}"
// CHECK-LD-STATIC-IOMP5: "-Bstatic" "-liomp5" "-Bdynamic" // CHECK-LD-STATIC-IOMP5: "-Bstatic" "-liomp5" "-Bdynamic"
// //
// CHECK-LD-STATIC-IOMP5-NO-BDYNAMIC: "{{.*}}ld{{(.exe)?}}" // CHECK-LD-STATIC-IOMP5-NO-BDYNAMIC: "{{.*}}ld{{(.exe)?}}"
// For x86 Gnu, the driver passes -static, while FreeBSD, NetBSD and OpenBSD pass -Bstatic // For x86 Gnu, the driver passes -static, while FreeBSD, NetBSD and OpenBSD pass -Bstatic
// CHECK-LD-STATIC-IOMP5-NO-BDYNAMIC: "-{{B?}}static" {{.*}} "-liomp5" // CHECK-LD-STATIC-IOMP5-NO-BDYNAMIC: "-{{B?}}static" {{.*}} "-liomp5"
// CHECK-LD-STATIC-IOMP5-NO-BDYNAMIC-NOT: "-Bdynamic" // CHECK-LD-STATIC-IOMP5-NO-BDYNAMIC-NOT: "-Bdynamic"
// //
// RUN: %clang -target x86_64-linux-gnu -fopenmp -fopenmp-enable-irbuilder -c %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-CC1-OPENMPIRBUILDER // RUN: %clang -target x86_64-linux-gnu -fopenmp=libomp -fopenmp-enable-irbuilder -c %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-CC1-OPENMPIRBUILDER
// //
// CHECK-CC1-OPENMPIRBUILDER: "-cc1" // CHECK-CC1-OPENMPIRBUILDER: "-cc1"
// CHECK-CC1-OPENMPIRBUILDER-SAME: "-fopenmp" // CHECK-CC1-OPENMPIRBUILDER-SAME: "-fopenmp"
// CHECK-CC1-OPENMPIRBUILDER-SAME: "-fopenmp-enable-irbuilder" // CHECK-CC1-OPENMPIRBUILDER-SAME: "-fopenmp-enable-irbuilder"
// //
// We'd like to check that the default is sane, but until we have the ability // We'd like to check that the default is sane, but until we have the ability
// to *always* semantically analyze OpenMP without always generating runtime // to *always* semantically analyze OpenMP without always generating runtime
// calls (in the event of an unsupported runtime), we don't have a good way to // calls (in the event of an unsupported runtime), we don't have a good way to
Show All 15 Lines

clang/test/Index/openmp-tile.c

// RUN: c-index-test -test-load-source local %s -fopenmp -fopenmp-version=51 | FileCheck %s // RUN: c-index-test -test-load-source local %s -fopenmp=libomp -fopenmp-version=51 | FileCheck %s
void test() { void test() {
#pragma omp tile sizes(5) #pragma omp tile sizes(5)
for (int i = 0; i < 65; i += 1) for (int i = 0; i < 65; i += 1)
; ;
} }
// CHECK: openmp-tile.c:4:1: OMPTileDirective= Extent=[4:1 - 4:26] // CHECK: openmp-tile.c:4:1: OMPTileDirective= Extent=[4:1 - 4:26]
// CHECK: openmp-tile.c:4:24: IntegerLiteral= Extent=[4:24 - 4:25] // CHECK: openmp-tile.c:4:24: IntegerLiteral= Extent=[4:24 - 4:25]
// CHECK: openmp-tile.c:5:3: ForStmt= Extent=[5:3 - 6:6] // CHECK: openmp-tile.c:5:3: ForStmt= Extent=[5:3 - 6:6]