This is an archive of the discontinued LLVM Phabricator instance.

[lld][WebAssembly] Add symbols marking start/end of stack region
ClosedPublic

Authored by sbc100 on Oct 13 2022, 12:55 PM.

Details

Summary

Currently emscripten is make assumptions about that memory layout and assuming
the stack is between __data_end and __heap_base:

https://github.com/emscripten-core/emscripten/blob/af961ad5c4c278ec510f0b7f7d522a95ee5a90f8/system/lib/compiler-rt/stack_limits.S#L42-L61

With this change we can be more precise:

https://github.com/emscripten-core/emscripten/pull/18057

Diff Detail

Event Timeline

sbc100 created this revision.Oct 13 2022, 12:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2022, 12:55 PM
Herald added subscribers: pmatos, asb, wingo and 4 others. · View Herald Transcript
sbc100 requested review of this revision.Oct 13 2022, 12:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2022, 12:55 PM
sbc100 edited the summary of this revision. (Show Details)Oct 13 2022, 1:32 PM
sbc100 edited the summary of this revision. (Show Details)
sbc100 added a reviewer: azakai.
sunfish accepted this revision.Oct 13 2022, 2:12 PM

LGTM!

This revision is now accepted and ready to land.Oct 13 2022, 2:12 PM