This is an archive of the discontinued LLVM Phabricator instance.

Differential D135885

[clang][LTO][NFC] Adding More Tests for AIX Options
ClosedPublic

Authored by qiongsiwu1 on Oct 13 2022, 8:31 AM.

Details

Reviewers
MaskRay
w2yehia
daltenty
Commits
rGbdd11bbace5e: [clang][LTO][NFC] Adding More Tests for AIX Options
Summary

This patch adds more tests for AIX. It follows https://reviews.llvm.org/D134820 which added a minimal set of tests for the newly added AIX options. These new tests were originally created by https://reviews.llvm.org/D119109. Since we do not plan to land https://reviews.llvm.org/D119109 in its current shape to add the AIX specific options, we incorporate the relevant tests developed.

Diff Detail

Event Timeline

qiongsiwu1 created this revision.Oct 13 2022, 8:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2022, 8:31 AM
Herald added subscribers: ormris, StephenFan, steven_wu and 2 others. · View Herald Transcript
qiongsiwu1 requested review of this revision.Oct 13 2022, 8:31 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptOct 13 2022, 8:31 AM
daltenty mentioned this in D119109: [clang][AIX] Enable LTO and teach the driver to pass options to the plugin.Oct 13 2022, 8:35 AM
Harbormaster completed remote builds in B191981: Diff 467487.Oct 13 2022, 9:26 AM
qiongsiwu1 added a comment.Oct 18 2022, 6:53 AM

@w2yehia @daltenty may I ask for a review? Thanks so much!

w2yehia accepted this revision.Oct 20 2022, 2:39 PM
This revision is now accepted and ready to land.Oct 20 2022, 2:39 PM
qiongsiwu1 updated this revision to Diff 469428.Oct 20 2022, 5:33 PM

Rebase and cleanup some test cases.

Harbormaster completed remote builds in B193385: Diff 469428.Oct 20 2022, 6:21 PM
Closed by commit rGbdd11bbace5e: [clang][LTO][NFC] Adding More Tests for AIX Options (authored by Qiongsi Wu <qiongsiwu@gmail.com>). · Explain WhyOct 22 2022, 8:11 AM
This revision was automatically updated to reflect the committed changes.
Qiongsi Wu <qiongsiwu@gmail.com> added a commit: rGbdd11bbace5e: [clang][LTO][NFC] Adding More Tests for AIX Options.

Revision Contents

PathSize
clang/
test/
Driver/
29 lines

Diff 467487

clang/test/Driver/lto-aix.c

// Test LTO path, mcpu and opt level options // Test LTO path, mcpu and opt level options
// RUN: %clang --target=powerpc-ibm-aix -### %s -flto -fuse-ld=ld -O3 2>&1 \ // RUN: %clang --target=powerpc-ibm-aix -### %s -flto -fuse-ld=ld -O3 2>&1 \
// RUN: | FileCheck -check-prefixes=LTOPATH,MCPUOPTLEVEL %s // RUN: | FileCheck -check-prefixes=LTOPATH,MCPUOPTLEVEL %s
// //
// LTOPATH: "-bplugin:{{.*}}libLTO.{{so|dll|dylib}}" // LTOPATH: "-bplugin:{{.*}}libLTO.{{so|dll|dylib}}"
// MCPUOPTLEVEL: "-bplugin_opt:-mcpu={{.*}}" "-bplugin_opt:-O3" // MCPUOPTLEVEL: "-bplugin_opt:-mcpu={{.*}}" "-bplugin_opt:-O3"
//
// More opt level option tests
// RUN: %clang --target=powerpc-ibm-aix --sysroot %S/Inputs/aix_ppc_tree %s \
// RUN: -fuse-ld=ld -flto -O -### 2>&1 | FileCheck --check-prefix=O1 %s
// RUN: %clang --target=powerpc-ibm-aix --sysroot %S/Inputs/aix_ppc_tree %s \
// RUN: -fuse-ld=ld -flto -O1 -### 2>&1 | FileCheck --check-prefix=O1 %s
// RUN: %clang --target=powerpc-ibm-aix --sysroot %S/Inputs/aix_ppc_tree %s \
// RUN: -fuse-ld=ld -flto -Og -### 2>&1 | FileCheck --check-prefix=O1 %s
// RUN: %clang --target=powerpc-ibm-aix --sysroot %S/Inputs/aix_ppc_tree %s \
// RUN: -fuse-ld=ld -flto -O2 -### 2>&1 | FileCheck --check-prefix=O2 %s
// RUN: %clang --target=powerpc-ibm-aix --sysroot %S/Inputs/aix_ppc_tree %s \
// RUN: -fuse-ld=ld -flto -Os -### 2>&1 | FileCheck --check-prefix=O2 %s
// RUN: %clang --target=powerpc-ibm-aix --sysroot %S/Inputs/aix_ppc_tree %s \
// RUN: -fuse-ld=ld -flto -Oz -### 2>&1 | FileCheck --check-prefix=O2 %s
// RUN: %clang --target=powerpc-ibm-aix --sysroot %S/Inputs/aix_ppc_tree %s \
// RUN: -fuse-ld=ld -flto -O3 -### 2>&1 | FileCheck --check-prefix=O3 %s
// RUN: %clang --target=powerpc-ibm-aix --sysroot %S/Inputs/aix_ppc_tree %s \
// RUN: -fuse-ld=ld -flto -Ofast -### 2>&1 | FileCheck --check-prefix=O3 %s
// O1: "-bplugin_opt:-O1"
// O2: "-bplugin_opt:-O2"
// O3: "-bplugin_opt:-O3"
//
// Test debugging options
// RUN: %clang --target=powerpc-ibm-aix -### %s -flto -fuse-ld=ld -gdbx 2> %t
// RUN: FileCheck -check-prefix=CHECK-TUNING-DBX < %t %s
// RUN: %clang --target=powerpc-ibm-aix -### %s -flto -fuse-ld=ld -g 2> %t
// RUN: FileCheck -check-prefix=CHECK-NO-TUNING < %t %s
// CHECK-TUNING-DBX: "-bplugin_opt:-debugger-tune=dbx"
// CHECK-NO-TUNING-NOT: "{{-plugin-opt=|-bplugin_opt:}}-debugger-tune"