This is an archive of the discontinued LLVM Phabricator instance.

Differential D135848

[clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support
ClosedPublic

Authored by lkail on Oct 12 2022, 8:37 PM.

Details

Reviewers
hubert.reinterpretcast
daltenty
stevewan
Commits
rGe231a580139a: [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support
Summary

Fixed error

Command Output (stderr):
--
fatal error: error in backend: Objective-C support is unimplemented for object file format

Source code in clang/lib/CodeGen/CGObjCMac.cpp:5080

case llvm::Triple::Wasm:
case llvm::Triple::GOFF:
case llvm::Triple::SPIRV:
case llvm::Triple::XCOFF:
case llvm::Triple::DXContainer:
  llvm::report_fatal_error(
      "Objective-C support is unimplemented for object file format");
}

Diff Detail

Event Timeline

lkail created this revision.Oct 12 2022, 8:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2022, 8:37 PM
Herald added a subscriber: sunfish. · View Herald Transcript
lkail requested review of this revision.Oct 12 2022, 8:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2022, 8:37 PM
Herald added subscribers: cfe-commits, aheejin. · View Herald Transcript
lkail edited the summary of this revision. (Show Details)Oct 12 2022, 8:40 PM
hubert.reinterpretcast accepted this revision.Oct 12 2022, 8:47 PM

LGTM with comment (matches similar files already present in the directory).

clang/test/Modules/module-file-home-is-cwd.m
1

We see GOFF in the same list.

This revision is now accepted and ready to land.Oct 12 2022, 8:47 PM
lkail updated this revision to Diff 467356.Oct 12 2022, 8:49 PM
lkail added inline comments.
clang/test/Modules/module-file-home-is-cwd.m
1

Nice one.

hubert.reinterpretcast accepted this revision.Oct 12 2022, 8:56 PM

Confirming LGTM.

This revision was landed with ongoing or failed builds.Oct 12 2022, 9:04 PM
Closed by commit rGe231a580139a: [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support (authored by lkail). · Explain Why
This revision was automatically updated to reflect the committed changes.
lkail added a commit: rGe231a580139a: [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support.
Harbormaster completed remote builds in B191889: Diff 467356.Oct 12 2022, 9:28 PM
GitHub <noreply@github.com> mentioned this in rGa1b4005bae86: [clang][Module] Mark test unsupported since objc doesn't have xcoff/g… (#70661).Oct 30 2023, 10:06 AM

Revision Contents

PathSize
clang/
test/
Modules/
1 line

Diff 467355

clang/test/Modules/module-file-home-is-cwd.m

// UNSUPPORTED: aix
hubert.reinterpretcastUnsubmitted
Not Done
ReplyInline Actions
- // UNSUPPORTED: aix
+ // UNSUPPORTED: -zos, -aix
// RUN: cd %S

We see GOFF in the same list.

hubert.reinterpretcast: We see GOFF in the same list.
lkailAuthorUnsubmitted
Done
ReplyInline Actions

Nice one.

lkail: Nice one.
// RUN: cd %S // RUN: cd %S
// RUN: %clang_cc1 -x objective-c -fmodules -fno-implicit-modules \ // RUN: %clang_cc1 -x objective-c -fmodules -fno-implicit-modules \
// RUN: -fmodule-file-home-is-cwd -fmodule-name=libA -emit-module \ // RUN: -fmodule-file-home-is-cwd -fmodule-name=libA -emit-module \
// RUN: -fmodules-embed-all-files %S/Inputs/normal-module-map/module.map \ // RUN: -fmodules-embed-all-files %S/Inputs/normal-module-map/module.map \
// RUN: -o %t/mod.pcm // RUN: -o %t/mod.pcm
// RUN: llvm-bcanalyzer --dump --disable-histogram %t/mod.pcm | FileCheck %s // RUN: llvm-bcanalyzer --dump --disable-histogram %t/mod.pcm | FileCheck %s
// CHECK: <INPUT_FILE {{.*}}/> blob data = 'Inputs{{/|\\}}normal-module-map{{/|\\}}module.map' // CHECK: <INPUT_FILE {{.*}}/> blob data = 'Inputs{{/|\\}}normal-module-map{{/|\\}}module.map'
Show All 14 Lines