Page MenuHomePhabricator
Differential D135605

[AMDGPU][MC] Correct image_gather4h
ClosedPublic
Actions

Authored by dp on Oct 10 2022, 11:02 AM.

Details

Reviewers
foad
mbrkusanin
arsenm
Commits
rG4e62d02db930: [AMDGPU][MC] Correct image_gather4h
Summary

Correct encoding of image_gather4h for GFX9; disable this instruction for SI, CI and VI.

See this issue.

Diff Detail

Event Timeline

dp created this revision.Oct 10 2022, 11:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 10 2022, 11:02 AM
Herald added subscribers: kosarev, kerbowa, hiraditya and 6 others. · View Herald Transcript
dp requested review of this revision.Oct 10 2022, 11:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 10 2022, 11:02 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
arsenm accepted this revision.Oct 10 2022, 11:12 AM

LGTM

This revision is now accepted and ready to land.Oct 10 2022, 11:12 AM
Harbormaster completed remote builds in B191324: Diff 466553.Oct 10 2022, 11:41 AM
Closed by commit rG4e62d02db930: [AMDGPU][MC] Correct image_gather4h (authored by dp). · Explain WhyOct 11 2022, 4:41 AM
This revision was automatically updated to reflect the committed changes.
dp added a commit: rG4e62d02db930: [AMDGPU][MC] Correct image_gather4h.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
AMDGPU/
8 lines
test/
MC/
AMDGPU/
3 lines
3 lines
3 lines
24 lines
Disassembler/
AMDGPU/
18 lines

Diff 466771

View Options

llvm/lib/Target/AMDGPU/MIMGInstructions.td

Loading...
View Options

llvm/test/MC/AMDGPU/gfx7_unsupported.s

Loading...
View Options

llvm/test/MC/AMDGPU/gfx8_unsupported.s

Loading...
View Options

llvm/test/MC/AMDGPU/gfx90a_err.s

Loading...
View Options

llvm/test/MC/AMDGPU/gfx9_asm_mimg.s

Loading...
View Options

llvm/test/MC/Disassembler/AMDGPU/gfx9_mimg.txt

Loading...