This is an archive of the discontinued LLVM Phabricator instance.

Differential D135486

[Clang] Use C++17 in constant-builtins-fmax.cpp test
ClosedPublic

Authored by Izaron on Oct 7 2022, 1:55 PM.

Details

Reviewers
efriedma
jcranmer-intel
aaron.ballman
cor3ntin
Commits
rGc585a44651f4: [Clang] Use C++17 in constant-builtins-fmax.cpp test
Summary

Add -std=c++17 to the test so that buildbot won't fail

Diff Detail

Event Timeline

Izaron created this revision.Oct 7 2022, 1:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 1:55 PM
Izaron requested review of this revision.Oct 7 2022, 1:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 1:55 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Izaron added a comment.Oct 7 2022, 1:56 PM

ASAP fix from previous review request, see comment: https://reviews.llvm.org/D134369#3843824

Izaron mentioned this in D134369: [Clang] Support constexpr builtin fmax.Oct 7 2022, 1:57 PM
efriedma accepted this revision.Oct 7 2022, 2:07 PM

Looks fine

This revision is now accepted and ready to land.Oct 7 2022, 2:07 PM
Izaron added a comment.Oct 7 2022, 2:09 PM

Thanks, will land the patch after Build 288902: pre-merge checks is passed =)

dyung added a subscriber: dyung.Oct 7 2022, 2:26 PM

Thanks, this is necessary because the Playstation platforms default to C++14, not C++17.

Harbormaster completed remote builds in B191011: Diff 466170.Oct 7 2022, 2:31 PM
Closed by commit rGc585a44651f4: [Clang] Use C++17 in constant-builtins-fmax.cpp test (authored by Izaron). · Explain WhyOct 7 2022, 2:32 PM
This revision was automatically updated to reflect the committed changes.
Izaron added a commit: rGc585a44651f4: [Clang] Use C++17 in constant-builtins-fmax.cpp test.

Revision Contents

PathSize
clang/
test/
Sema/
2 lines

Diff 466170

clang/test/Sema/constant-builtins-fmax.cpp

// RUN: %clang_cc1 -fsyntax-only -verify %s // RUN: %clang_cc1 -std=c++17 -fsyntax-only -verify %s
// expected-no-diagnostics // expected-no-diagnostics
constexpr double NaN = __builtin_nan(""); constexpr double NaN = __builtin_nan("");
constexpr double Inf = __builtin_inf(); constexpr double Inf = __builtin_inf();
constexpr double NegInf = -__builtin_inf(); constexpr double NegInf = -__builtin_inf();
#define FMAX_TEST_SIMPLE(T, FUNC) \ #define FMAX_TEST_SIMPLE(T, FUNC) \
static_assert(T(6.7890) == FUNC(T(1.2345), T(6.7890))); \ static_assert(T(6.7890) == FUNC(T(1.2345), T(6.7890))); \
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines