This is an archive of the discontinued LLVM Phabricator instance.

Differential D135336

[mlir][sparse] Fixing bug in python test
ClosedPublic

Authored by wrengr on Oct 5 2022, 6:01 PM.

Details

Reviewers
aartbik
bixia
penpornk
Peiming
nicolasvasilache
Commits
rG794d347988b9: [mlir][sparse] Fixing bug in python test
Summary

This is a followup to D135004, to correct one of the tests that didn't get caught by the buildbot.

Diff Detail

Event Timeline

wrengr created this revision.Oct 5 2022, 6:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2022, 6:01 PM
Herald added subscribers: anlunx, bzcheeseman, sdasgup3 and 17 others. · View Herald Transcript
wrengr requested review of this revision.Oct 5 2022, 6:01 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptOct 5 2022, 6:01 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
aartbik accepted this revision.Oct 5 2022, 6:04 PM
This revision is now accepted and ready to land.Oct 5 2022, 6:04 PM
This revision was landed with ongoing or failed builds.Oct 5 2022, 6:06 PM
Closed by commit rG794d347988b9: [mlir][sparse] Fixing bug in python test (authored by wrengr). · Explain Why
This revision was automatically updated to reflect the committed changes.
wrengr added a commit: rG794d347988b9: [mlir][sparse] Fixing bug in python test.
Harbormaster completed remote builds in B190659: Diff 465629.Oct 5 2022, 6:17 PM

Revision Contents

PathSize
mlir/
test/
python/
dialects/
sparse_tensor/
4 lines

Diff 465629

mlir/test/python/dialects/sparse_tensor/dialect.py

Show All 19 Lines parsed = Attribute.parse('#sparse_tensor.encoding<{'
'}>') '}>')
# CHECK: #sparse_tensor.encoding<{ dimLevelType = [ "compressed" ], pointerBitWidth = 16, indexBitWidth = 32 }> # CHECK: #sparse_tensor.encoding<{ dimLevelType = [ "compressed" ], pointerBitWidth = 16, indexBitWidth = 32 }>
print(parsed) print(parsed)
casted = st.EncodingAttr(parsed) casted = st.EncodingAttr(parsed)
# CHECK: equal: True # CHECK: equal: True
print(f"equal: {casted == parsed}") print(f"equal: {casted == parsed}")
# CHECK: dim_level_types: [<DimLevelType.compressed: 1>] # CHECK: dim_level_types: [<DimLevelType.compressed: 8>]
print(f"dim_level_types: {casted.dim_level_types}") print(f"dim_level_types: {casted.dim_level_types}")
# CHECK: dim_ordering: None # CHECK: dim_ordering: None
print(f"dim_ordering: {casted.dim_ordering}") print(f"dim_ordering: {casted.dim_ordering}")
# CHECK: pointer_bit_width: 16 # CHECK: pointer_bit_width: 16
print(f"pointer_bit_width: {casted.pointer_bit_width}") print(f"pointer_bit_width: {casted.pointer_bit_width}")
# CHECK: index_bit_width: 32 # CHECK: index_bit_width: 32
print(f"index_bit_width: {casted.index_bit_width}") print(f"index_bit_width: {casted.index_bit_width}")
Show All 22 Lines parsed = Attribute.parse('#sparse_tensor.encoding<{'
'}>') '}>')
# CHECK: #sparse_tensor.encoding<{ dimLevelType = [ "dense", "compressed" ], dimOrdering = affine_map<(d0, d1) -> (d1, d0)>, pointerBitWidth = 8, indexBitWidth = 32 }> # CHECK: #sparse_tensor.encoding<{ dimLevelType = [ "dense", "compressed" ], dimOrdering = affine_map<(d0, d1) -> (d1, d0)>, pointerBitWidth = 8, indexBitWidth = 32 }>
print(parsed) print(parsed)
casted = st.EncodingAttr(parsed) casted = st.EncodingAttr(parsed)
# CHECK: equal: True # CHECK: equal: True
print(f"equal: {casted == parsed}") print(f"equal: {casted == parsed}")
# CHECK: dim_level_types: [<DimLevelType.dense: 0>, <DimLevelType.compressed: 1>] # CHECK: dim_level_types: [<DimLevelType.dense: 4>, <DimLevelType.compressed: 8>]
print(f"dim_level_types: {casted.dim_level_types}") print(f"dim_level_types: {casted.dim_level_types}")
# CHECK: dim_ordering: (d0, d1) -> (d1, d0) # CHECK: dim_ordering: (d0, d1) -> (d1, d0)
print(f"dim_ordering: {casted.dim_ordering}") print(f"dim_ordering: {casted.dim_ordering}")
# CHECK: pointer_bit_width: 8 # CHECK: pointer_bit_width: 8
print(f"pointer_bit_width: {casted.pointer_bit_width}") print(f"pointer_bit_width: {casted.pointer_bit_width}")
# CHECK: index_bit_width: 32 # CHECK: index_bit_width: 32
print(f"index_bit_width: {casted.index_bit_width}") print(f"index_bit_width: {casted.index_bit_width}")
Show All 24 Lines