This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Add test coverage to ensure first regallocfast only allocates SGPR
ClosedPublic

Authored by jrbyrnes on Oct 5 2022, 4:17 PM.

Details

Summary

Register allocation is split into two passes, and the expected behavior is that the first pass only should only work on virtual SGPRs. Whereas the second pass works on virtual VGPRs. This adds a test case which breaks if the first pass allocates VGPRs.

Diff Detail

Event Timeline

jrbyrnes created this revision.Oct 5 2022, 4:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2022, 4:17 PM
jrbyrnes requested review of this revision.Oct 5 2022, 4:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2022, 4:17 PM
arsenm added inline comments.Oct 5 2022, 4:19 PM
llvm/test/CodeGen/AMDGPU/fastregalloc-sgpr-only.mir
3

Should specify run with regallocfast,0

jrbyrnes updated this revision to Diff 465781.Oct 6 2022, 10:20 AM
jrbyrnes marked an inline comment as done.

Specify regallocfast,0. Add sgpr allocation test

arsenm accepted this revision.Oct 6 2022, 11:43 AM
This revision is now accepted and ready to land.Oct 6 2022, 11:43 AM