This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Making verification after parsing optional
ClosedPublic

Authored by rriddle on Sep 28 2022, 7:00 PM.

Details

Summary

This is very useful when you want to parse IR even if
its invalid (e.g. bytecode). It's also useful if you don't
want to pay the cost of verification in certain situations.

Diff Detail

Event Timeline

rriddle created this revision.Sep 28 2022, 7:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 28 2022, 7:00 PM
rriddle requested review of this revision.Sep 28 2022, 7:00 PM
lattner accepted this revision.Sep 28 2022, 7:22 PM
lattner added a subscriber: lattner.

Nice, thank you for the test

This revision is now accepted and ready to land.Sep 28 2022, 7:22 PM
bondhugula added inline comments.
mlir/unittests/Parser/ParserTest.cpp
1

This is a header file's header. Drop "- C++ -".

bzcheeseman accepted this revision.Sep 28 2022, 8:00 PM

Thanks river :)

This revision was automatically updated to reflect the committed changes.
rriddle marked an inline comment as done.

Just noticed this config existed - will be very useful! Thanks!