This is an archive of the discontinued LLVM Phabricator instance.

[LoongArch] Support 'generic' as a valid CPU name
ClosedPublic

Authored by xen0n on Sep 21 2022, 11:39 PM.

Details

Summary

As the LoongArch port is largely modeled after RISCV it has the same
behavior of not accepting generic as a CPU name. For better
compatibility with consumers of LLVM (e.g. mesa) follow D121149's suit
and treat generic the same as an empty CPU name.

Diff Detail

Event Timeline

xen0n created this revision.Sep 21 2022, 11:39 PM
xen0n requested review of this revision.Sep 21 2022, 11:39 PM
SixWeining accepted this revision.EditedSep 22 2022, 4:58 AM

LGTM. Thanks.

EDIT: Should we add some tests for this change?

This revision is now accepted and ready to land.Sep 22 2022, 4:58 AM
xen0n updated this revision to Diff 462162.Sep 22 2022, 6:26 AM

add testcase

SixWeining accepted this revision.Sep 22 2022, 6:29 AM

LGTM. Thanks.

This revision was automatically updated to reflect the committed changes.