This is an archive of the discontinued LLVM Phabricator instance.

[msan] Handle x86_avx_cmp_pd_256 and x86_avx_cmp_ps_256
ClosedPublic

Authored by vitalybuka on Sep 17 2022, 8:21 PM.

Details

Summary

Removed FIXME which looks irrelevant. The error message happens only without -mattr=+avx.
E.g.
GOOD: opt llvm/test/Instrumentation/MemorySanitizer/avx-intrinsics-x86.ll -passes=msan -o - | llc -O3 -o /dev/null -mattr=+avx
BAD: opt llvm/test/Instrumentation/MemorySanitizer/avx-intrinsics-x86.ll -passes=msan -o - | llc -O3 -o /dev/null

So nothing to fix here.

Diff Detail

Event Timeline

vitalybuka created this revision.Sep 17 2022, 8:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 17 2022, 8:21 PM
vitalybuka requested review of this revision.Sep 17 2022, 8:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 17 2022, 8:21 PM
RKSimon added inline comments.
llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
3872

Have you been able to determine whether this has been addressed?

vitalybuka edited the summary of this revision. (Show Details)Sep 19 2022, 9:43 AM
vitalybuka added reviewers: eugenis, kda, kstoimenov.
vitalybuka added inline comments.Sep 19 2022, 9:45 AM
llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
3872

this error happens only without -mattr=+avx which is expected
and it's true for many other avx intrinsic here

So I assume this comment is by mistake here @eugenis

pengfei added inline comments.Sep 19 2022, 6:36 PM
llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
3872

The FE checked the target attributes before generating such intrinsics, so I think we can always assume we meet the requirments.
In fact, now we generate such intrinsics only for a few cases under constrained FP: https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CGBuiltin.cpp#L14812-L14866

RKSimon accepted this revision.Sep 20 2022, 6:47 AM

LGTM - cheers

llvm/test/Instrumentation/MemorySanitizer/avx-intrinsics-x86.ll
290

these changes look superfluous - precommit to clean up the test codegen checks?

This revision is now accepted and ready to land.Sep 20 2022, 6:47 AM
This revision was landed with ongoing or failed builds.Sep 21 2022, 3:17 PM
This revision was automatically updated to reflect the committed changes.