Page MenuHomePhabricator
People kda

kda (Kevin Athey)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 17 2021, 5:02 PM (104 w, 4 d)

Recent Activity
View All

Feb 9 2023

kda added a comment to rG6ab9f1e59371: [Driver] Fix -fsanitize-address-stack-use-after-scope after D142606.

Right. I saw that bug on Monday. Thank you for that fix.
I'm not sure why it started leaking today...

Feb 9 2023, 11:44 AM · Restricted Project, Restricted Project
kda added a comment to rG6ab9f1e59371: [Driver] Fix -fsanitize-address-stack-use-after-scope after D142606.

Looks like this is breaking Sanitizer builds: https://lab.llvm.org/buildbot/#/builders/5/builds/31378

Feb 9 2023, 10:57 AM · Restricted Project, Restricted Project

Dec 16 2022

kda added a comment to rGfc21f2d7bae2: [Attributor] Introduce AA[Intra/Inter]Reachability.

This introduced a leak in sanitizer buildbot for ASAN.
https://lab.llvm.org/buildbot/#/builders/168/builds/10733

Dec 16 2022, 11:05 AM · Restricted Project, Restricted Project

Dec 15 2022

kda added a comment to rG4c52fb1a5ee2: [AArch64][GlobalISel][Legalizer] Legalize G_SHUFFLE_VECTOR with different….

Apoligies: I put it back.
https://reviews.llvm.org/rGec7cffc579737d086addf22bb155e76e5cd30ab3

Dec 15 2022, 11:21 AM · Restricted Project, Restricted Project
kda added a reverting change for rG192cc76e0be6: Revert "[AArch64][GlobalISel][Legalizer] Legalize G_SHUFFLE_VECTOR with…: rGec7cffc57973: Revert "Revert "[AArch64][GlobalISel][Legalizer] Legalize G_SHUFFLE_VECTOR with….
Dec 15 2022, 11:20 AM · Restricted Project, Restricted Project
kda committed rGec7cffc57973: Revert "Revert "[AArch64][GlobalISel][Legalizer] Legalize G_SHUFFLE_VECTOR with… (authored by kda).
Revert "Revert "[AArch64][GlobalISel][Legalizer] Legalize G_SHUFFLE_VECTOR with…
Dec 15 2022, 11:20 AM · Restricted Project, Restricted Project
kda added a reverting change for rG4c52fb1a5ee2: [AArch64][GlobalISel][Legalizer] Legalize G_SHUFFLE_VECTOR with different…: rG192cc76e0be6: Revert "[AArch64][GlobalISel][Legalizer] Legalize G_SHUFFLE_VECTOR with….
Dec 15 2022, 11:16 AM · Restricted Project, Restricted Project
kda committed rG192cc76e0be6: Revert "[AArch64][GlobalISel][Legalizer] Legalize G_SHUFFLE_VECTOR with… (authored by kda).
Revert "[AArch64][GlobalISel][Legalizer] Legalize G_SHUFFLE_VECTOR with…
Dec 15 2022, 11:16 AM · Restricted Project, Restricted Project
kda added a reverting change for D132190: [AArch64][GlobalISel] Legalize G_SHUFFLE_VECTOR with different lengths: rG192cc76e0be6: Revert "[AArch64][GlobalISel][Legalizer] Legalize G_SHUFFLE_VECTOR with….
Dec 15 2022, 11:16 AM · Restricted Project, Restricted Project
kda added a comment to D132190: [AArch64][GlobalISel] Legalize G_SHUFFLE_VECTOR with different lengths.

This has broken UBSAN buildbot:
https://lab.llvm.org/buildbot/#/builders/85/builds/13003

Dec 15 2022, 10:16 AM · Restricted Project, Restricted Project

Dec 12 2022

kda added a comment to rG3bbfaee23d41: [reland][Alignment][NFC] Remove access to deprecated GlobalObject::getAlignment….

This breaks sanitizer buildbot (fast): https://lab.llvm.org/buildbot/#/builders/5/builds/29930

Dec 12 2022, 1:01 PM · Restricted Project, Restricted Project
kda accepted D139727: [HWASAN][NFC] Renamed [g|s]et_requested_size to [G|S]etRequestedSize..

NFC?

Dec 12 2022, 10:46 AM · Restricted Project, Restricted Project

Dec 5 2022

kda accepted D139296: [msan][CodeGen] Set noundef for C return value.

LGTM

Dec 5 2022, 2:36 PM · Restricted Project, Restricted Project
kda added a comment to D139296: [msan][CodeGen] Set noundef for C return value.

Is there a risk of this being too strict for standard C?

Dec 5 2022, 1:24 PM · Restricted Project, Restricted Project
kda updated the summary of D139296: [msan][CodeGen] Set noundef for C return value.
Dec 5 2022, 1:19 PM · Restricted Project, Restricted Project

Oct 27 2022

kda added a comment to D127531: [SLP]Improve analysis of same/alternate code ops and scheduling..

Looks like this is breaking MSAN buildbot: https://lab.llvm.org/buildbot/#/builders/74/builds/14584

Oct 27 2022, 2:28 PM · Restricted Project, Restricted Project
kda added a comment to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.

This looks to have broken sanitizer Fast buildbot: https://lab.llvm.org/buildbot/#/builders/5/builds/28595

Oct 27 2022, 2:04 PM · Restricted Project, Restricted Project, debug-info
kda added a reverting change for D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info: rG0cb65b0a585c: Revert "[OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target….
Oct 27 2022, 1:59 PM · Restricted Project, Restricted Project, Restricted Project
kda added a reverting change for rG3d0e9edd8e53: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region…: rG0cb65b0a585c: Revert "[OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target….
Oct 27 2022, 1:59 PM · Restricted Project, Restricted Project, Restricted Project
kda committed rG0cb65b0a585c: Revert "[OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target… (authored by kda).
Revert "[OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target…
Oct 27 2022, 1:59 PM · Restricted Project, Restricted Project, Restricted Project
kda added a comment to D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info.

The bracket builds have finished and they seem to have a conclusive result. The test starts failing with this patch.

Oct 27 2022, 1:55 PM · Restricted Project, Restricted Project, Restricted Project

Oct 26 2022

kda added a comment to D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info.

This may have broken HWASAN buildbot:
https://lab.llvm.org/buildbot/#/builders/236/builds/786

Oct 26 2022, 1:19 PM · Restricted Project, Restricted Project, Restricted Project

Oct 24 2022

kda committed rG31bfa4a69b12: [MSAN] Add handleCountZeroes for ctlz and cttz. (authored by kda).
[MSAN] Add handleCountZeroes for ctlz and cttz.
Oct 24 2022, 5:31 PM · Restricted Project, Restricted Project
kda closed D136523: [MSAN] Add handleCountZeroes for ctlz and cttz..
Oct 24 2022, 5:31 PM · Restricted Project, Restricted Project
kda updated the diff for D136523: [MSAN] Add handleCountZeroes for ctlz and cttz..

rebase.

Oct 24 2022, 5:30 PM · Restricted Project, Restricted Project
kda retitled D136523: [MSAN] Add handleCountZeroes for ctlz and cttz. from [MSAN] Add handleCountZeroes for vector versions of ctlz and cttz. to [MSAN] Add handleCountZeroes for ctlz and cttz..
Oct 24 2022, 5:28 PM · Restricted Project, Restricted Project
kda committed rG67ad31c88e8b: [MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. (NFC) (authored by kda).
[MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. (NFC)
Oct 24 2022, 5:19 PM · Restricted Project, Restricted Project
kda closed D136369: [MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. (NFC).
Oct 24 2022, 5:19 PM · Restricted Project, Restricted Project
kda updated the diff for D136523: [MSAN] Add handleCountZeroes for ctlz and cttz..

improvements based on vitalybuka feedback

Oct 24 2022, 5:09 PM · Restricted Project, Restricted Project
kda abandoned D136644: attempt to create test that uses ctlz.v2i64 (currently failed).
Oct 24 2022, 4:29 PM · Restricted Project, Restricted Project
kda retitled D136369: [MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. (NFC) from [MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. to [MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. (NFC).
Oct 24 2022, 4:12 PM · Restricted Project, Restricted Project
kda requested review of D136644: attempt to create test that uses ctlz.v2i64 (currently failed).
Oct 24 2022, 4:00 PM · Restricted Project, Restricted Project
kda updated the diff for D136523: [MSAN] Add handleCountZeroes for ctlz and cttz..

removed unused line

Oct 24 2022, 3:57 PM · Restricted Project, Restricted Project
kda added a comment to D136523: [MSAN] Add handleCountZeroes for ctlz and cttz..
In D136523#3880730, @eugenis wrote:

LGTM, but I'd merge the two changes. I don't really see the point of submitting a test for the broken behavior first.

Oct 24 2022, 3:48 PM · Restricted Project, Restricted Project
kda updated the diff for D136523: [MSAN] Add handleCountZeroes for ctlz and cttz..

updated for input from eugenis.

Oct 24 2022, 1:45 PM · Restricted Project, Restricted Project
kda added a comment to D125782: [llvm-debuginfo-analyzer] 07 - Compare elements.

Looking better already:
https://lab.llvm.org/buildbot/#/builders/168/builds/9681

Oct 24 2022, 1:30 PM · Restricted Project, Restricted Project, debug-info
kda added a comment to D125782: [llvm-debuginfo-analyzer] 07 - Compare elements.

These are still broken claiming this target is the trouble:

Failed Tests (1):
  LLVM-Unit :: DebugInfo/LogicalView/./DebugInfoLogicalViewTests/8/15

Appears to be a leak:

Oct 24 2022, 11:38 AM · Restricted Project, Restricted Project, debug-info
kda added a comment to D125782: [llvm-debuginfo-analyzer] 07 - Compare elements.
In D125782#3879032, @CarlosAlbertoEnciso wrote:

The following patch fixed some buildbot sanitizer issues: https://reviews.llvm.org/D136593

Oct 24 2022, 9:19 AM · Restricted Project, Restricted Project, debug-info

Oct 22 2022

kda updated the summary of D136523: [MSAN] Add handleCountZeroes for ctlz and cttz..
Oct 22 2022, 2:26 AM · Restricted Project, Restricted Project
kda requested review of D136523: [MSAN] Add handleCountZeroes for ctlz and cttz..
Oct 22 2022, 2:26 AM · Restricted Project, Restricted Project
kda added inline comments to D136369: [MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. (NFC).
Oct 22 2022, 2:23 AM · Restricted Project, Restricted Project
kda updated the diff for D136369: [MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. (NFC).

add no zero poison versions

Oct 22 2022, 2:22 AM · Restricted Project, Restricted Project

Oct 20 2022

kda updated the diff for D136369: [MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. (NFC).

added x86 non-vector versions

Oct 20 2022, 1:13 PM · Restricted Project, Restricted Project
kda requested review of D136369: [MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. (NFC).
Oct 20 2022, 10:32 AM · Restricted Project, Restricted Project

Sep 21 2022

kda accepted D134126: [sanitizer] Handle movmsk intrinsics.
Sep 21 2022, 4:05 PM · Restricted Project, Restricted Project
kda accepted D134123: [msan] Instrument vtest instrinsics.
Sep 21 2022, 3:42 PM · Restricted Project, Restricted Project
kda updated the summary of D134123: [msan] Instrument vtest instrinsics.
Sep 21 2022, 10:41 AM · Restricted Project, Restricted Project
kda updated the summary of D134122: [msan] Handle vpermilvar intrinsics.
Sep 21 2022, 10:11 AM · Restricted Project, Restricted Project

Sep 19 2022

kda accepted D133678: [msan] Check mask and pointers shadow.
Sep 19 2022, 12:01 PM · Restricted Project, Restricted Project

Sep 14 2022

kda added inline comments to D133678: [msan] Check mask and pointers shadow.
Sep 14 2022, 5:45 PM · Restricted Project, Restricted Project
kda accepted D133682: [msan] Handle shadow of masked instruction.
Sep 14 2022, 5:44 PM · Restricted Project, Restricted Project
kda accepted D133681: [nfc][msan] getShadowOriginPtr on <N x ptr>.
Sep 14 2022, 3:18 PM · Restricted Project, Restricted Project
kda added a comment to D133681: [nfc][msan] getShadowOriginPtr on <N x ptr>.

This seems like it should change some IR, but I don't see a unit test.
Certainly there should be something for the kernel.

Sep 14 2022, 2:29 PM · Restricted Project, Restricted Project
kda added inline comments to D133678: [msan] Check mask and pointers shadow.
Sep 14 2022, 1:58 PM · Restricted Project, Restricted Project
kda accepted D133673: [NFC][msan] Convert some code to early returns.
Sep 14 2022, 1:04 PM · Restricted Project, Restricted Project
kda accepted D133652: [NFC][msan] Simplify llvm.masked.load origin code.

This appears to use fewer instructions. Yay!

Sep 14 2022, 12:53 PM · Restricted Project, Restricted Project

Sep 9 2022

kda added a comment to D132325: [AArch64][CodeGen] Fold the mov and lsl into ubfiz.
In D132325#3781756, @efriedma wrote:
In D132325#3781749, @kda wrote:

Looks like this is breaking ASAN buildbot:
https://lab.llvm.org/buildbot/#/builders/168/builds/8760

Are you certain you're assigning blame correctly? That's a unittest failure in MLIR on x86; I don't see how it could possibly involve the AArch64 backend.

Sep 9 2022, 4:50 PM · Restricted Project, Restricted Project
kda added a comment to D132325: [AArch64][CodeGen] Fold the mov and lsl into ubfiz.

Looks like this is breaking ASAN buildbot:
https://lab.llvm.org/buildbot/#/builders/168/builds/8760

Sep 9 2022, 4:30 PM · Restricted Project, Restricted Project

Sep 8 2022

kda accepted D133232: [msan] Disambiguate warnings debug location.
Sep 8 2022, 1:04 PM · Restricted Project, Restricted Project
kda updated the summary of D133232: [msan] Disambiguate warnings debug location.
Sep 8 2022, 11:21 AM · Restricted Project, Restricted Project

Sep 1 2022

kda committed rG0b509f2d1a19: [MSAN] removing redundant tests and parameters (NFC) (authored by kda).
[MSAN] removing redundant tests and parameters (NFC)
Sep 1 2022, 2:04 PM · Restricted Project, Restricted Project, Restricted Project
kda closed D117622: [MSAN] removing redundant tests and parameters (NFC).
Sep 1 2022, 2:04 PM · Restricted Project, Restricted Project, Restricted Project
kda added a comment to D117622: [MSAN] removing redundant tests and parameters (NFC).

Just returning to finish this clean up.

Sep 1 2022, 1:07 PM · Restricted Project, Restricted Project, Restricted Project
kda retitled D117622: [MSAN] removing redundant tests and parameters (NFC) from cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509 to [MSAN] removing redundant tests and parameters (NFC).
Sep 1 2022, 1:06 PM · Restricted Project, Restricted Project, Restricted Project
kda updated the diff for D117622: [MSAN] removing redundant tests and parameters (NFC).

rebase

Sep 1 2022, 1:05 PM · Restricted Project, Restricted Project, Restricted Project
kda accepted D133091: [msan] Fix debug info with getNextNode.
Sep 1 2022, 12:39 PM · Restricted Project, Restricted Project
kda accepted D133077: [msan] Use no-origin functions when possible.
Sep 1 2022, 11:45 AM · Restricted Project, Restricted Project, Restricted Project
kda accepted D133071: [msan] Combine shadow check of the same instruction.
Sep 1 2022, 11:41 AM · Restricted Project, Restricted Project
kda accepted D133065: [nfc][msan] Group checks per instruction.
Sep 1 2022, 11:37 AM · Restricted Project, Restricted Project

Aug 31 2022

kda added a comment to D133065: [nfc][msan] Group checks per instruction.

test?

Aug 31 2022, 4:53 PM · Restricted Project, Restricted Project
kda accepted D133034: [MSan] Fix determinism issue when using msan-track-origins..
Aug 31 2022, 11:08 AM · Restricted Project, Restricted Project

Aug 30 2022

kda accepted D132907: [msan] Add more specific messages for use-after-destroy.
Aug 30 2022, 3:30 PM · Restricted Project, Restricted Project, Restricted Project

Aug 15 2022

kda retitled D131903: [MSAN] clean up style from D131728 - NFC from [MSAN] clean up style from D131728 to [MSAN] clean up style from D131728 - NFC.
Aug 15 2022, 3:29 PM · Restricted Project, Restricted Project
kda committed rGc22841049eba: [MSAN] clean up style from D131728 (authored by kda).
[MSAN] clean up style from D131728
Aug 15 2022, 11:46 AM · Restricted Project, Restricted Project
kda closed D131903: [MSAN] clean up style from D131728 - NFC.
Aug 15 2022, 11:46 AM · Restricted Project, Restricted Project
kda added inline comments to D131728: [MSAN] add flag to suppress storage of stack variable names with -sanitize-memory-track-origins.
Aug 15 2022, 9:34 AM · Restricted Project, Restricted Project, Restricted Project
kda requested review of D131903: [MSAN] clean up style from D131728 - NFC.
Aug 15 2022, 9:33 AM · Restricted Project, Restricted Project

Aug 12 2022

kda committed rG532564de17bf: [MSAN] add flag to suppress storage of stack variable names with -sanitize… (authored by kda).
[MSAN] add flag to suppress storage of stack variable names with -sanitize…
Aug 12 2022, 12:00 PM · Restricted Project, Restricted Project, Restricted Project
kda closed D131728: [MSAN] add flag to suppress storage of stack variable names with -sanitize-memory-track-origins.
Aug 12 2022, 11:59 AM · Restricted Project, Restricted Project, Restricted Project
kda updated the diff for D131728: [MSAN] add flag to suppress storage of stack variable names with -sanitize-memory-track-origins.

update after rebase

Aug 12 2022, 11:43 AM · Restricted Project, Restricted Project, Restricted Project
kda committed rGec277b67eb36: [MSAN] Separate id ptr from constant string for variable names used in track… (authored by kda).
[MSAN] Separate id ptr from constant string for variable names used in track…
Aug 12 2022, 8:47 AM · Restricted Project, Restricted Project, Restricted Project
kda closed D131631: [MSAN] Separate id ptr from constant string for variable names used in track origins..
Aug 12 2022, 8:47 AM · Restricted Project, Restricted Project, Restricted Project

Aug 11 2022

kda updated the diff for D131631: [MSAN] Separate id ptr from constant string for variable names used in track origins..

add check for IDPTR in IR test

Aug 11 2022, 8:29 PM · Restricted Project, Restricted Project, Restricted Project
kda committed rG4735104f09c5: [MSAN] remove unused debugging statements (NFC) (authored by kda).
[MSAN] remove unused debugging statements (NFC)
Aug 11 2022, 8:25 PM · Restricted Project, Restricted Project
kda closed D131748: [MSAN] remove unused debugging statements (NFC).
Aug 11 2022, 8:24 PM · Restricted Project, Restricted Project
kda updated the diff for D131728: [MSAN] add flag to suppress storage of stack variable names with -sanitize-memory-track-origins.

drop pc from new function and fix/improve IR test

Aug 11 2022, 8:23 PM · Restricted Project, Restricted Project, Restricted Project
kda requested review of D131748: [MSAN] remove unused debugging statements (NFC).
Aug 11 2022, 8:20 PM · Restricted Project, Restricted Project
kda added a comment to D131631: [MSAN] Separate id ptr from constant string for variable names used in track origins..

PTAL

Aug 11 2022, 7:49 PM · Restricted Project, Restricted Project, Restricted Project
kda updated the diff for D131631: [MSAN] Separate id ptr from constant string for variable names used in track origins..

fix IR test

Aug 11 2022, 7:07 PM · Restricted Project, Restricted Project, Restricted Project
kda abandoned D131744: fix up IR tests.
Aug 11 2022, 7:05 PM · Restricted Project, Restricted Project
kda requested review of D131744: fix up IR tests.
Aug 11 2022, 7:05 PM · Restricted Project, Restricted Project
kda updated the diff for D131631: [MSAN] Separate id ptr from constant string for variable names used in track origins..

rebase

Aug 11 2022, 4:11 PM · Restricted Project, Restricted Project, Restricted Project
kda abandoned D131737: change name of origin5 function to origin_with_descr.
Aug 11 2022, 4:09 PM · Restricted Project, Restricted Project, Restricted Project
kda requested review of D131737: change name of origin5 function to origin_with_descr.
Aug 11 2022, 4:06 PM · Restricted Project, Restricted Project, Restricted Project
kda updated the diff for D131631: [MSAN] Separate id ptr from constant string for variable names used in track origins..

testing update with squash and rebase

Aug 11 2022, 3:17 PM · Restricted Project, Restricted Project, Restricted Project
kda added a reviewer for D131728: [MSAN] add flag to suppress storage of stack variable names with -sanitize-memory-track-origins: vitalybuka.
Aug 11 2022, 3:03 PM · Restricted Project, Restricted Project, Restricted Project
kda requested review of D131728: [MSAN] add flag to suppress storage of stack variable names with -sanitize-memory-track-origins.
Aug 11 2022, 3:02 PM · Restricted Project, Restricted Project, Restricted Project
kda accepted D131721: [test][msan] Test origin description argument.
Aug 11 2022, 2:28 PM · Restricted Project, Restricted Project
kda accepted D131692: [msan] Avoid unnecessary PC increment/decrement.
Aug 11 2022, 2:19 PM · Restricted Project, Restricted Project
kda added inline comments to D131631: [MSAN] Separate id ptr from constant string for variable names used in track origins..
Aug 11 2022, 1:23 PM · Restricted Project, Restricted Project, Restricted Project