Page MenuHomePhabricator
People kda

kda (Kevin Athey)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 17 2021, 5:02 PM (62 w, 2 d)

Recent Activity
View All

Wed, May 25

kda added a comment to D123235: [OpenMP] atomic compare fail : Parser & AST support.

This has broken sanitizer buildbot:
https://lab.llvm.org/buildbot/#/builders/5/builds/24074

Wed, May 25, 8:19 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 20 2022

kda accepted D124057: [asan] Enable detect_stack_use_after_return=1 by default on Linux.
Apr 20 2022, 2:34 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kda accepted D124058: [msan] Update Use-after-destruction documentation.
Apr 20 2022, 2:26 PM · Restricted Project, Restricted Project

Apr 12 2022

kda accepted D123566: [sanitizer] Don't run malloc hooks for stacktraces.
Apr 12 2022, 4:36 PM · Restricted Project, Restricted Project
kda accepted D123643: [ASan] Fixed a reporting bug in (load|store)N functions which would print unknown-crash instead of the proper error message when a the data access is unaligned..

A couple of nits.

Apr 12 2022, 4:26 PM · Restricted Project, Restricted Project

Apr 8 2022

kda committed rGe9c8d0ff71ba: [MSAN] add __b64_pton and __b64_ntop intercepts (authored by kda).
[MSAN] add __b64_pton and __b64_ntop intercepts
Apr 8 2022, 3:23 PM · Restricted Project, Restricted Project
kda closed D122849: [MSAN] add __b64_pton and __b64_ntop intercepts.
Apr 8 2022, 3:22 PM · Restricted Project, Restricted Project
kda updated the diff for D122849: [MSAN] add __b64_pton and __b64_ntop intercepts.

check trailing null byte of src parameter to pton.

Apr 8 2022, 3:00 PM · Restricted Project, Restricted Project
kda added a comment to D122851: [MSAN] extend prctl interceptor to support PR_SCHED_CORE.

gasp. I missed one symbol.
Should be fixed now. I hope.

Apr 8 2022, 9:48 AM · Restricted Project, Restricted Project
kda committed rGb401d2a43cf6: Add one more definition for symbols in prctl unit test. (authored by kda).
Add one more definition for symbols in prctl unit test.
Apr 8 2022, 9:46 AM · Restricted Project, Restricted Project
kda closed D123404: Add one more definition for symbols in prctl unit test. one more follow up to: https://reviews.llvm.org/D122851.
Apr 8 2022, 9:46 AM · Restricted Project, Restricted Project
kda requested review of D123404: Add one more definition for symbols in prctl unit test. one more follow up to: https://reviews.llvm.org/D122851.
Apr 8 2022, 9:45 AM · Restricted Project, Restricted Project
kda added a comment to D122851: [MSAN] extend prctl interceptor to support PR_SCHED_CORE.

committed: https://reviews.llvm.org/rG5562d9b3c006f3e376d98ee7b9f3c6c8608ddbee
Should fix builds.

Apr 8 2022, 8:57 AM · Restricted Project, Restricted Project
kda committed rG5562d9b3c006: Add definitions for symbols in unit test for prctl. (authored by kda).
Add definitions for symbols in unit test for prctl.
Apr 8 2022, 8:56 AM · Restricted Project, Restricted Project
kda closed D123395: Add definitions for symbols in unit test for prctl. Follow up to: https://reviews.llvm.org/D122851.
Apr 8 2022, 8:56 AM · Restricted Project, Restricted Project
kda added a reviewer for D123395: Add definitions for symbols in unit test for prctl. Follow up to: https://reviews.llvm.org/D122851: eugenis.
Apr 8 2022, 8:55 AM · Restricted Project, Restricted Project
kda requested review of D123395: Add definitions for symbols in unit test for prctl. Follow up to: https://reviews.llvm.org/D122851.
Apr 8 2022, 8:50 AM · Restricted Project, Restricted Project

Apr 7 2022

kda committed rG0713053e4a3f: [MSAN] extend prctl interceptor to support PR_SCHED_CORE (authored by kda).
[MSAN] extend prctl interceptor to support PR_SCHED_CORE
Apr 7 2022, 4:49 PM · Restricted Project, Restricted Project
kda closed D122851: [MSAN] extend prctl interceptor to support PR_SCHED_CORE.
Apr 7 2022, 4:49 PM · Restricted Project, Restricted Project
kda added inline comments to D122851: [MSAN] extend prctl interceptor to support PR_SCHED_CORE.
Apr 7 2022, 4:47 PM · Restricted Project, Restricted Project
kda updated the diff for D122851: [MSAN] extend prctl interceptor to support PR_SCHED_CORE.

trim includes from unit test

Apr 7 2022, 9:41 AM · Restricted Project, Restricted Project
kda updated the diff for D122851: [MSAN] extend prctl interceptor to support PR_SCHED_CORE.

added unit test

Apr 7 2022, 9:39 AM · Restricted Project, Restricted Project

Apr 5 2022

kda added inline comments to D122849: [MSAN] add __b64_pton and __b64_ntop intercepts.
Apr 5 2022, 4:23 PM · Restricted Project, Restricted Project
kda updated the diff for D122849: [MSAN] add __b64_pton and __b64_ntop intercepts.

a few more adjustments

Apr 5 2022, 4:23 PM · Restricted Project, Restricted Project
kda updated the diff for D122849: [MSAN] add __b64_pton and __b64_ntop intercepts.

improve unit test (reading and edge cases), add sanitizer_common test, adjust implementation.

Apr 5 2022, 3:52 PM · Restricted Project, Restricted Project

Apr 4 2022

kda added inline comments to D122849: [MSAN] add __b64_pton and __b64_ntop intercepts.
Apr 4 2022, 11:34 AM · Restricted Project, Restricted Project

Mar 31 2022

kda updated the diff for D122851: [MSAN] extend prctl interceptor to support PR_SCHED_CORE.

narrow intercept by checking second parameter.

Mar 31 2022, 4:29 PM · Restricted Project, Restricted Project
kda added reviewers for D122851: [MSAN] extend prctl interceptor to support PR_SCHED_CORE: vitalybuka, eugenis.
Mar 31 2022, 2:51 PM · Restricted Project, Restricted Project
kda requested review of D122851: [MSAN] extend prctl interceptor to support PR_SCHED_CORE.
Mar 31 2022, 2:51 PM · Restricted Project, Restricted Project
kda updated the diff for D122849: [MSAN] add __b64_pton and __b64_ntop intercepts.

remove unused include

Mar 31 2022, 2:42 PM · Restricted Project, Restricted Project
kda added reviewers for D122849: [MSAN] add __b64_pton and __b64_ntop intercepts: vitalybuka, eugenis.
Mar 31 2022, 1:37 PM · Restricted Project, Restricted Project
kda updated the diff for D122849: [MSAN] add __b64_pton and __b64_ntop intercepts.

improved comparison

Mar 31 2022, 1:37 PM · Restricted Project, Restricted Project
kda requested review of D122849: [MSAN] add __b64_pton and __b64_ntop intercepts.
Mar 31 2022, 1:35 PM · Restricted Project, Restricted Project

Mar 29 2022

kda added a comment to D120159: [Clang] Implement __builtin_source_location..

Fix looks good. Thank you.

Mar 29 2022, 3:20 PM · Restricted Project, Restricted Project
kda added a comment to D120159: [Clang] Implement __builtin_source_location..

This appears to have broken buildbot: sanitizer-x86_64-linux-fast

Mar 29 2022, 2:15 PM · Restricted Project, Restricted Project

Mar 16 2022

kda accepted D119300: Use-after-dtor detection for trivial base classes..
Mar 16 2022, 10:32 AM · Restricted Project, Restricted Project, Restricted Project
kda added inline comments to D119300: Use-after-dtor detection for trivial base classes..
Mar 16 2022, 10:31 AM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2022

kda accepted D121674: [lsan] Allow suppression of "unknown module".
Mar 15 2022, 11:12 AM · Restricted Project, Restricted Project

Mar 9 2022

kda added a reverting change for rG0a4dec6cc2bf: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime: rGfc9e07873f0c: Revert "[MSAN] add interceptor for timer_create, timer_settime, timer_gettime".
Mar 9 2022, 2:58 PM · Restricted Project
kda committed rGfc9e07873f0c: Revert "[MSAN] add interceptor for timer_create, timer_settime, timer_gettime" (authored by kda).
Revert "[MSAN] add interceptor for timer_create, timer_settime, timer_gettime"
Mar 9 2022, 2:57 PM · Restricted Project
kda added a reverting change for D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime: rGfc9e07873f0c: Revert "[MSAN] add interceptor for timer_create, timer_settime, timer_gettime".
Mar 9 2022, 2:57 PM · Restricted Project, Restricted Project
kda added a reverting change for rGf2a975368095: [MSAN] adjust Posix/timer.cpp: rGb5e985e6f391: Revert "[MSAN] adjust Posix/timer.cpp".
Mar 9 2022, 2:56 PM · Restricted Project
kda committed rGb5e985e6f391: Revert "[MSAN] adjust Posix/timer.cpp" (authored by kda).
Revert "[MSAN] adjust Posix/timer.cpp"
Mar 9 2022, 2:56 PM · Restricted Project
kda added a reverting change for D121326: [MSAN] adjust Posix/timer.cpp: rGb5e985e6f391: Revert "[MSAN] adjust Posix/timer.cpp".
Mar 9 2022, 2:56 PM · Restricted Project, Restricted Project
kda committed rGf2a975368095: [MSAN] adjust Posix/timer.cpp (authored by kda).
[MSAN] adjust Posix/timer.cpp
Mar 9 2022, 1:02 PM · Restricted Project
kda closed D121326: [MSAN] adjust Posix/timer.cpp.
Mar 9 2022, 1:02 PM · Restricted Project, Restricted Project
kda requested review of D121326: [MSAN] adjust Posix/timer.cpp.
Mar 9 2022, 12:58 PM · Restricted Project, Restricted Project
kda committed rG0a4dec6cc2bf: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime (authored by kda).
[MSAN] add interceptor for timer_create, timer_settime, timer_gettime
Mar 9 2022, 11:21 AM · Restricted Project
kda closed D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.
Mar 9 2022, 11:21 AM · Restricted Project, Restricted Project
kda updated the diff for D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.

fix memory leak and SEGV in timer.cpp

Mar 9 2022, 11:20 AM · Restricted Project, Restricted Project
kda reopened D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.
Mar 9 2022, 11:04 AM · Restricted Project, Restricted Project
kda abandoned D121309: fix leak in Posix/timer.ccp.
Mar 9 2022, 11:02 AM · Restricted Project, Restricted Project
kda requested review of D121309: fix leak in Posix/timer.ccp.
Mar 9 2022, 10:49 AM · Restricted Project, Restricted Project

Mar 8 2022

kda committed rGc2aab0d3808b: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime (authored by kda).
[MSAN] add interceptor for timer_create, timer_settime, timer_gettime
Mar 8 2022, 5:00 PM · Restricted Project
kda closed D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.
Mar 8 2022, 4:59 PM · Restricted Project, Restricted Project
kda updated the diff for D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.

add UNSUPPORTED: darwin to test

Mar 8 2022, 3:17 PM · Restricted Project, Restricted Project
kda updated the diff for D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.

move test back to Posix, add typedef to solaris, freebsd, netbsd.

Mar 8 2022, 2:13 PM · Restricted Project, Restricted Project
kda accepted D121249: [DFSan] Fix several bugs in dfsan custom callbacks test..
Mar 8 2022, 2:03 PM · Restricted Project, Restricted Project

Mar 5 2022

kda added inline comments to D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.
Mar 5 2022, 2:35 PM · Restricted Project, Restricted Project
kda updated the diff for D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.

going with LINUX

Mar 5 2022, 2:34 PM · Restricted Project, Restricted Project

Mar 4 2022

kda updated the diff for D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.

move timer.cpp from Linux to Posix.

Mar 4 2022, 5:01 PM · Restricted Project, Restricted Project
kda committed rG7fbc1f7ebe3b: [MSAN] extend ioctl interceptor to support BLKSSZGET (authored by kda).
[MSAN] extend ioctl interceptor to support BLKSSZGET
Mar 4 2022, 3:40 PM · Restricted Project
kda closed D120693: [MSAN] extend ioctl interceptor to support BLKSSZGET.
Mar 4 2022, 3:39 PM · Restricted Project, Restricted Project
kda updated the diff for D120693: [MSAN] extend ioctl interceptor to support BLKSSZGET.

a few more adjustments

Mar 4 2022, 2:08 PM · Restricted Project, Restricted Project
kda added inline comments to D120693: [MSAN] extend ioctl interceptor to support BLKSSZGET.
Mar 4 2022, 8:44 AM · Restricted Project, Restricted Project
kda updated the diff for D120693: [MSAN] extend ioctl interceptor to support BLKSSZGET.

adjusted types and READ/WRITE

Mar 4 2022, 8:43 AM · Restricted Project, Restricted Project

Mar 3 2022

kda added inline comments to D120693: [MSAN] extend ioctl interceptor to support BLKSSZGET.
Mar 3 2022, 5:47 PM · Restricted Project, Restricted Project
kda updated the diff for D120693: [MSAN] extend ioctl interceptor to support BLKSSZGET.

added to list and dropped test
add a few other BLK ioctls

Mar 3 2022, 5:47 PM · Restricted Project, Restricted Project
kda updated the diff for D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.

remove FileCheck from timer.cpp

Mar 3 2022, 8:05 AM · Restricted Project, Restricted Project
kda updated the diff for D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.

remove read checks and format

Mar 3 2022, 8:04 AM · Restricted Project, Restricted Project

Mar 2 2022

kda updated the diff for D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.

add sanitizer_common test, and UMR checks.

Mar 2 2022, 8:29 PM · Restricted Project, Restricted Project
kda retitled D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime from [MSAN] add interceptor for timer_create to [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.
Mar 2 2022, 11:19 AM · Restricted Project, Restricted Project
kda updated the diff for D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.

add interceptors for timer_settime and timer_gettime

Mar 2 2022, 11:19 AM · Restricted Project, Restricted Project

Feb 28 2022

kda added inline comments to D120693: [MSAN] extend ioctl interceptor to support BLKSSZGET.
Feb 28 2022, 8:19 PM · Restricted Project, Restricted Project
kda requested review of D120693: [MSAN] extend ioctl interceptor to support BLKSSZGET.
Feb 28 2022, 8:18 PM · Restricted Project, Restricted Project
kda retitled D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime from [WIP] [MSAN] add interceptor for timer_create to [MSAN] add interceptor for timer_create.
Feb 28 2022, 7:44 PM · Restricted Project, Restricted Project
kda added inline comments to D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.
Feb 28 2022, 7:43 PM · Restricted Project, Restricted Project
kda updated the diff for D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.

remove spacing noise

Feb 28 2022, 7:43 PM · Restricted Project, Restricted Project

Feb 25 2022

kda added inline comments to D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.
Feb 25 2022, 6:28 PM · Restricted Project, Restricted Project
kda requested review of D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.
Feb 25 2022, 6:17 PM · Restricted Project, Restricted Project
kda added inline comments to D119300: Use-after-dtor detection for trivial base classes..
Feb 25 2022, 12:14 PM · Restricted Project, Restricted Project, Restricted Project
kda accepted D119600: Stricter use-after-dtor detection for trivial members..

LGTM

Feb 25 2022, 11:59 AM · Restricted Project, Restricted Project

Feb 4 2022

kda added a comment to D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`.

This still seems to be breaking sanitizers fast: https://lab.llvm.org/buildbot/#/builders/5/builds/18563

Feb 4 2022, 12:27 PM · Restricted Project

Feb 1 2022

kda added a reverting change for rG3fab2d138e30: [DebugInfo][InstrRef] Add a max-stack-slots-to-track cut-out: rG1c1b670a73a9: Revert "[DebugInfo][InstrRef] Add a max-stack-slots-to-track cut-out".
Feb 1 2022, 6:37 PM
kda committed rG1c1b670a73a9: Revert "[DebugInfo][InstrRef] Add a max-stack-slots-to-track cut-out" (authored by kda).
Revert "[DebugInfo][InstrRef] Add a max-stack-slots-to-track cut-out"
Feb 1 2022, 6:37 PM
kda added a reverting change for D118601: [DebugInfo][InstrRef] Add a max-stack-slots-to-track limitation / cut-out: rG1c1b670a73a9: Revert "[DebugInfo][InstrRef] Add a max-stack-slots-to-track cut-out".
Feb 1 2022, 6:37 PM · Restricted Project
kda added a comment to D118601: [DebugInfo][InstrRef] Add a max-stack-slots-to-track limitation / cut-out.

This may be breaking PPC sanitizer buildbot: https://lab.llvm.org/buildbot/#/builders/105/builds/20857/steps/7/logs/FAIL__LLVM__spill-slot-limits_mir

Feb 1 2022, 4:12 PM · Restricted Project
kda accepted D118739: Revert "[ASan] Not linking asan_static library for DSO.".
Feb 1 2022, 3:34 PM · Restricted Project
kda added a comment to D118313: [Driver] Remove -fno-experimental-new-pass-manager.

This looks like it is breaking the sanitizer buildbot for android:
https://lab.llvm.org/buildbot/#/builders/77/builds/13756/steps/21/logs/stdio

Feb 1 2022, 1:22 PM · Restricted Project

Jan 31 2022

kda added inline comments to D118122: [WebAssembly] Refactor and fix emission of external IR global decls.
Jan 31 2022, 11:27 AM · Restricted Project
kda added a comment to D118122: [WebAssembly] Refactor and fix emission of external IR global decls.

This has broken fast buildbot: https://lab.llvm.org/buildbot/#/builders/5/builds/18257/steps/16/logs/stdio

Jan 31 2022, 11:14 AM · Restricted Project

Jan 25 2022

kda accepted D118205: [ASan] Added a unit test for D118184..

thank you.

Jan 25 2022, 5:09 PM · Restricted Project
kda accepted D118184: [ASan] Not linking asan_static library for DSO..

unit test?

Jan 25 2022, 4:09 PM · Restricted Project

Jan 18 2022

kda updated the diff for D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509.

remove "-s"

Jan 18 2022, 4:05 PM · Restricted Project, Restricted Project
kda requested review of D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509.
Jan 18 2022, 3:49 PM · Restricted Project, Restricted Project
kda added a comment to D108453: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default (2).

Breaks sanitizer buildbots: https://lab.llvm.org/buildbot/#/builders/5/builds/17422 (fast) AND https://lab.llvm.org/buildbot/#/builders/74/builds/8849 (MSAN)

Jan 18 2022, 11:01 AM · Restricted Project, Restricted Project
kda raised a concern with rG8ca4b3ef19fe: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and….

Breaks sanitizer buildbots: https://lab.llvm.org/buildbot/#/builders/5/builds/17422 (fast) AND https://lab.llvm.org/buildbot/#/builders/74/builds/8849 (MSAN)

Jan 18 2022, 10:44 AM

Jan 14 2022

kda added inline comments to D116633: Add -fsanitize-address-param-retval to clang..
Jan 14 2022, 5:57 PM · Restricted Project
kda accepted D117286: [msan] Reset shadow of byval before call.

LGTM
and clean up formatting.

Jan 14 2022, 5:50 PM · Restricted Project
kda accepted D117285: [msan] Copy origin of byval arguments.

LGTM

Jan 14 2022, 5:49 PM · Restricted Project