This is an archive of the discontinued LLVM Phabricator instance.

[HIP][test] Avoid %T
ClosedPublic

Authored by MaskRay on Sep 15 2022, 5:23 PM.

Details

Summary

%T is a deprecated lit feature. It refers to the parent directory.
When two tests in test/Driver refer to the same %T/foo, they are racy with each other.
%t includes the test name and is safe for use.

Diff Detail

Event Timeline

MaskRay created this revision.Sep 15 2022, 5:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2022, 5:23 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
MaskRay requested review of this revision.Sep 15 2022, 5:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2022, 5:23 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
tra accepted this revision.Sep 15 2022, 5:24 PM
This revision is now accepted and ready to land.Sep 15 2022, 5:24 PM
MaskRay updated this revision to Diff 460569.Sep 15 2022, 5:29 PM

fix all hip-*

MaskRay edited the summary of this revision. (Show Details)Sep 15 2022, 5:35 PM
This revision was landed with ongoing or failed builds.Sep 15 2022, 7:58 PM
Closed by commit rG9e1c1ecb148e: [HIP][test] Avoid %T (authored by MaskRay). · Explain Why
This revision was automatically updated to reflect the committed changes.

@MaskRay I see that you restored the clang-driver keyword in hip-link-bc-to-bc.hip, and of course that keyword is not defined anywhere so the test is never being run.
Is there an issue filed to track this? Or is the original author aware? @lamb-j

@MaskRay I see that you restored the clang-driver keyword in hip-link-bc-to-bc.hip, and of course that keyword is not defined anywhere so the test is never being run.
Is there an issue filed to track this? Or is the original author aware? @lamb-j

Thanks for reporting the issue. I forgot to mention it. You are right that Driver/hip-link-bc-to-bc.hip needs fixing @lamb-j

I filed #58711 to get the test fixed; in the meantime, removed clang-driver and added XFAIL: * in rG7af01fe4