This is an archive of the discontinued LLVM Phabricator instance.

Differential D133921

[PowerPC][NFC] Add virtual call to show redundant spill of vector registers
ClosedPublic

Authored by tingwang on Sep 15 2022, 1:23 AM.

Details

Reviewers
lkail
nemanjai
shchenz
Group Reviewers
Restricted Project
Commits
rG514ac16b517e: [PowerPC][NFC] Add virtual call to show redundant spill of vector registers
Summary

Update base test case for https://reviews.llvm.org/D133466.

Diff Detail

Unit TestsFailed

TimeTest
60,070 msx64 debian > MLIR.Examples/standalone::test.toy
60,040 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test

Event Timeline

tingwang created this revision.Sep 15 2022, 1:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2022, 1:23 AM
Herald added a subscriber: qcolombet. · View Herald Transcript
tingwang requested review of this revision.Sep 15 2022, 1:23 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 15 2022, 1:23 AM
tingwang added a child revision: D133466: [PowerPC] Remove redundant spill/reload of callee saved vector registers.Sep 15 2022, 1:24 AM
lkail added inline comments.Sep 15 2022, 1:26 AM
llvm/test/CodeGen/PowerPC/aix64-vector-pair-cc-spills.ll
153

Better move this virtualcall test to another file and check output assembly.

Harbormaster completed remote builds in B186800: Diff 460320.Sep 15 2022, 3:08 AM
tingwang updated this revision to Diff 460557.Sep 15 2022, 4:57 PM

Address comments.

tingwang added a comment.Sep 15 2022, 4:58 PM

Thank you for the suggestion. It's more clear to show the broken function. I will update the fix patch once this is finialized.

Harbormaster completed remote builds in B186981: Diff 460557.Sep 15 2022, 5:49 PM
lkail accepted this revision as: lkail.Sep 15 2022, 6:39 PM

LGTM.

This revision is now accepted and ready to land.Sep 15 2022, 6:39 PM
Closed by commit rG514ac16b517e: [PowerPC][NFC] Add virtual call to show redundant spill of vector registers (authored by tingwang). · Explain WhySep 20 2022, 6:22 PM
This revision was automatically updated to reflect the committed changes.
tingwang added a commit: rG514ac16b517e: [PowerPC][NFC] Add virtual call to show redundant spill of vector registers.

Revision Contents

PathSize
llvm/
test/
CodeGen/
PowerPC/
53 lines

Diff 460320

llvm/test/CodeGen/PowerPC/aix64-vector-pair-cc-spills.ll

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines
; CHECK-VEXT-NEXT: callee-saved-register: '$v20' ; CHECK-VEXT-NEXT: callee-saved-register: '$v20'
define void @spill() { define void @spill() {
entry: entry:
call void asm sideeffect "nop", "~{v20},~{v21},~{v22},~{v23},~{v24},~{v25},~{v26},~{v27},~{v28},~{v29},~{v30},~{v31}"() call void asm sideeffect "nop", "~{v20},~{v21},~{v22},~{v23},~{v24},~{v25},~{v26},~{v27},~{v28},~{v29},~{v30},~{v31}"()
call void @bar(i32 0) call void @bar(i32 0)
ret void ret void
} }
; Error pattern will be fixed in https://reviews.llvm.org/D133466
; CHECK-LABEL: name: virtualCall
; CHECK: spill-slot
; CHECK-NEXT: callee-saved-register: '$v31'
; CHECK: spill-slot
; CHECK-NEXT: callee-saved-register: '$v30'
; CHECK: spill-slot
; CHECK-NEXT: callee-saved-register: '$v29'
; CHECK: spill-slot
; CHECK-NEXT: callee-saved-register: '$v28'
; CHECK: spill-slot
; CHECK-NEXT: callee-saved-register: '$v27'
; CHECK: spill-slot
; CHECK-NEXT: callee-saved-register: '$v26'
; CHECK: spill-slot
; CHECK-NEXT: callee-saved-register: '$v25'
; CHECK: spill-slot
; CHECK-NEXT: callee-saved-register: '$v24'
; CHECK: spill-slot
; CHECK-NEXT: callee-saved-register: '$v23'
; CHECK: spill-slot
; CHECK-NEXT: callee-saved-register: '$v22'
; CHECK: spill-slot
; CHECK-NEXT: callee-saved-register: '$v21'
; CHECK: spill-slot
; CHECK-NEXT: callee-saved-register: '$v20'
; CHECK-VEXT-LABEL: name: virtualCall
; CHECK-VEXT-NOT: spill-slot
; CHECK-VEXT-NOT: callee-saved-register: '$v31'
; CHECK-VEXT-NOT: callee-saved-register: '$v30'
; CHECK-VEXT-NOT: callee-saved-register: '$v29'
; CHECK-VEXT-NOT: callee-saved-register: '$v28'
; CHECK-VEXT-NOT: callee-saved-register: '$v27'
; CHECK-VEXT-NOT: callee-saved-register: '$v26'
; CHECK-VEXT-NOT: callee-saved-register: '$v25'
; CHECK-VEXT-NOT: callee-saved-register: '$v24'
; CHECK-VEXT-NOT: callee-saved-register: '$v23'
; CHECK-VEXT-NOT: callee-saved-register: '$v22'
; CHECK-VEXT-NOT: callee-saved-register: '$v21'
; CHECK-VEXT-NOT: callee-saved-register: '$v20'
define dso_local noundef signext i32 @virtualCall(ptr noundef %b) #0 {
lkailUnsubmitted
Not Done
ReplyInline Actions

Better move this virtualcall test to another file and check output assembly.

lkail: Better move this `virtualcall` test to another file and check output assembly.
entry:
%b.addr = alloca ptr, align 8
store ptr %b, ptr %b.addr, align 8
%0 = load ptr, ptr %b.addr, align 8
%vtable = load ptr, ptr %0, align 8
%vfn = getelementptr inbounds ptr, ptr %vtable, i64 0
%1 = load ptr, ptr %vfn, align 8
%call = call noundef signext i32 %1(ptr noundef nonnull align 8 dereferenceable(8) %0)
ret i32 %call
}
declare void @bar(i32) declare void @bar(i32)