[mlir][math] Canonicalize math.sin with constant

[Lewuathe]

Summary

Canonicalize math.sin given with the constant value.

[ftynse]

mlir/lib/Dialect/Math/IR/MathOps.cpp

489

Should this be sinf?

mlir/test/Dialect/Math/canonicalize.mlir

468

Please add the newline.

[ftynse]

Actually, the earlier https://reviews.llvm.org/D133915 seems to be doing the same thing.

[Mogball]

In D133917#3791640, @ftynse wrote:

Actually, the earlier https://reviews.llvm.org/D133915 seems to be doing the same thing.

+1

[Lewuathe]

In D133917#3792376, @Mogball wrote:

In D133917#3791640, @ftynse wrote:

Actually, the earlier https://reviews.llvm.org/D133915 seems to be doing the same thing.

+1

Oh, thanks. Good catch. I'll close this.

mlir/include/mlir/Dialect/Math/IR/MathOps.td

let description = [{
 
     Example:
 
     ```mlir
     // Scalar sine value.
     %a = math.sin %b : f64
     ```
   }];
+
+  let hasFolder = 1;
 }
 
 //===----------------------------------------------------------------------===//
 // CountLeadingZerosOp
 //===----------------------------------------------------------------------===//
 
 def Math_CountLeadingZerosOp : Math_IntegerUnaryOp<"ctlz"> {
   let summary = "counts the leading zeros an integer value";

mlir/lib/Dialect/Math/IR/MathOps.cpp

return constFoldUnaryOpConditional<FloatAttr>(
         case 32:
           return APFloat(truncf(a.convertToFloat()));
         default:
           return {};
         }
       });
 }
 
+//===----------------------------------------------------------------------===//
+// SinOp folder
+//===----------------------------------------------------------------------===//
+
+OpFoldResult math::SinOp::fold(ArrayRef<Attribute> operands) {
+  return constFoldUnaryOpConditional<FloatAttr>(
+      operands, [](const APFloat &a) -> Optional<APFloat> {
+        switch (a.getSizeInBits(a.getSemantics())) {
+        case 64:
+          return APFloat(sin(a.convertToDouble()));
+        case 32:
+          return APFloat(sin(a.convertToFloat()));
+        default:
+          return {};
+        }
+      });
+}
+
 /// Materialize an integer or floating point constant.
 Operation *math::MathDialect::materializeConstant(OpBuilder &builder,
                                                   Attribute value, Type type,
                                                   Location loc) {
   return builder.create<arith::ConstantOp>(loc, value, type);
 }

mlir/test/Dialect/Math/canonicalize.mlir

 // CHECK-LABEL: @trunc_fold_vec
 // CHECK-NEXT: %[[cst:.+]] = arith.constant dense<[0.000000e+00, -0.000000e+00, 1.000000e+00, -1.000000e+00]> : vector<4xf32>
 // CHECK-NEXT:   return %[[cst]]
 func.func @trunc_fold_vec() -> (vector<4xf32>) {
   %v = arith.constant dense<[0.5, -0.5, 1.5, -1.5]> : vector<4xf32>
   %0 = math.trunc %v : vector<4xf32>
   return %0 : vector<4xf32>
 }
+
+// CHECK-LABEL: @sin_fold
+// CHECK-NEXT: %[[cst:.+]] = arith.constant 8.414710e-01 : f32
+// CHECK-NEXT:   return %[[cst]]
+func.func @sin_fold() -> f32 {
+  %c = arith.constant 1.0 : f32
+  %r = math.sin %c : f32
+  return %r : f32
+}
+
+// CHECK-LABEL: @sin_fold_vec
+// CHECK-NEXT: %[[cst:.+]] = arith.constant dense<[0.000000e+00, 8.414710e-01, 0.000000e+00, 8.414710e-01]> : vector<4xf32>
+// CHECK-NEXT:   return %[[cst]]
+func.func @sin_fold_vec() -> (vector<4xf32>) {
+  %v1 = arith.constant dense<[0.0, 1.0, 0.0, 1.0]> : vector<4xf32>
+  %0 = math.sin %v1 : vector<4xf32>
+  return %0 : vector<4xf32>
+}
 No newline at end of file