This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] Cleaning up SparseTensorFile::readMMEHeader
ClosedPublic

Authored by wrengr on Sep 13 2022, 9:56 PM.

Details

Summary

This is a followup to the refactoring of D133462, D133830, D133831, and D133833.

Depends On D133833

Diff Detail

Event Timeline

wrengr created this revision.Sep 13 2022, 9:56 PM
wrengr requested review of this revision.Sep 13 2022, 9:56 PM
aartbik accepted this revision.Sep 19 2022, 5:24 PM
aartbik added inline comments.
mlir/lib/ExecutionEngine/SparseTensor/File.cpp
87

how about making this a void function now that we no longer need return value, just the in-place updates?

This revision is now accepted and ready to land.Sep 19 2022, 5:24 PM
This revision was automatically updated to reflect the committed changes.
wrengr marked an inline comment as done.Sep 30 2022, 12:39 PM
wrengr added inline comments.
mlir/lib/ExecutionEngine/SparseTensor/File.cpp
87