This is an archive of the discontinued LLVM Phabricator instance.

[GlobalISel][AArch64] Fix pcsections for expanded atomics and add more tests
ClosedPublic

Authored by melver on Sep 12 2022, 10:14 AM.

Details

Summary

Add fix for propagation of !pcsections metadata for expanded atomics,
together with more tests for interesting atomic instructions (based on
llvm/test/CodeGen/AArch64/GlobalISel/arm64-atomic.ll).

Diff Detail

Event Timeline

melver created this revision.Sep 12 2022, 10:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2022, 10:14 AM
melver requested review of this revision.Sep 12 2022, 10:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2022, 10:14 AM

Can you add an IR test that directly shows the metadata after expansion?

melver updated this revision to Diff 459742.Sep 13 2022, 7:24 AM

Switch test to check MIR output instead of asm.

Can you add an IR test that directly shows the metadata after expansion?

That makes more sense, I've updated the test to check the expanded MIR. PTAL.

arsenm added inline comments.Sep 13 2022, 7:46 AM
llvm/lib/CodeGen/MIRParser/MIParser.cpp
1051–1054 ↗(On Diff #459742)

The MIRParser changes are really a separate patch that should get a separate parse/print round trip test in test/CodeGen/MIR

melver updated this revision to Diff 459778.Sep 13 2022, 9:12 AM
melver edited the summary of this revision. (Show Details)

Move MIR parser/printer changes to separate patch.

melver marked an inline comment as done.Sep 13 2022, 11:01 AM
melver updated this revision to Diff 460008.Sep 14 2022, 1:31 AM
melver edited the summary of this revision. (Show Details)

Rebase.

PTAL. Thanks!

arsenm accepted this revision.Sep 14 2022, 1:41 PM

LGTM

This revision is now accepted and ready to land.Sep 14 2022, 1:41 PM
This revision was landed with ongoing or failed builds.Sep 15 2022, 1:44 AM
This revision was automatically updated to reflect the committed changes.