This is an archive of the discontinued LLVM Phabricator instance.

Loop names used in reporting can grow very large
ClosedPublic

Authored by jamieschmeiser on Sep 9 2022, 10:03 AM.

Details

Summary

In his work for https://reviews.llvm.org/D131960, @dongjunduo found that
the names for loops generated by getIRName could grow to be extremely
large because they are based on a serialization of the loop. Replace this with
the name of the loop (which is based on the header) and patch up the
affected lit tests.

It was suggested (in separate conversations) that an analogous
fix be made in https://reviews.llvm.org/D131960 with a FIXME
comment to resolve the 2 pieces of code so https://reviews.llvm.org/D131960
can be delivered as it is part of a GSoC project that is finishing.

Diff Detail

Event Timeline

jamieschmeiser created this revision.Sep 9 2022, 10:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2022, 10:03 AM
jamieschmeiser requested review of this revision.Sep 9 2022, 10:03 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptSep 9 2022, 10:03 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aeubanks accepted this revision.Sep 9 2022, 10:12 AM

this is something I've wanted to do for a while but never got around to
thanks!

This revision is now accepted and ready to land.Sep 9 2022, 10:12 AM
Whitney accepted this revision.Sep 9 2022, 10:13 AM
This revision was landed with ongoing or failed builds.Sep 9 2022, 10:45 AM
This revision was automatically updated to reflect the committed changes.