Page MenuHomePhabricator

jamieschmeiser (Jamie Schmeiser)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2020, 11:14 AM (44 w, 6 d)

Recent Activity

Wed, Jun 16

jamieschmeiser requested review of D104420: thread_local support for AIX.
Wed, Jun 16, 2:08 PM · Restricted Project
jamieschmeiser added a comment to D98798: Produce warning for performing pointer arithmetic on a null pointer..

ping

Wed, Jun 16, 1:39 PM · Restricted Project

Mon, Jun 7

jamieschmeiser added a comment to D98798: Produce warning for performing pointer arithmetic on a null pointer..

@rsmith I separated the C and C++ messages in response to your comments and changed the C++ message to state that "performing pointer subtraction with a null pointer may have undefined behavior" to address your concerns. Are you satisfied? @thakis, the warning no longer fires in the MS headers according to @hans and there is separate option control over this warning. Is this sufficient? @efriedma, thank you for reviewing/approving the original but these changes were sufficiently different that I thought a new review would be beneficial. Are you still satisfied with the resulting changes?

Mon, Jun 7, 9:48 AM · Restricted Project

Fri, Jun 4

jamieschmeiser added a comment to D98798: Produce warning for performing pointer arithmetic on a null pointer..

ping

Fri, Jun 4, 11:01 AM · Restricted Project

Thu, May 27

jamieschmeiser added a comment to D98798: Produce warning for performing pointer arithmetic on a null pointer..

The reason I worded it with 'may' is because, in C++, nullptr - nullptr is defined. If the code is "nullptr - p" or "p - nullptr", it is only undefined behaviour when p is not nullptr, hence the 'may' part of the warning because this is not known at compile time. The warning is still useful as it is suspect code but one cannot state that it is undefined behaviour because it is valid if it is null at runtime.

Thu, May 27, 2:06 PM · Restricted Project
jamieschmeiser committed rG3879fcdb8733: Reuse temporary files for print-changed=diff (authored by jamieschmeiser).
Reuse temporary files for print-changed=diff
Thu, May 27, 7:20 AM
jamieschmeiser closed D100116: Reuse temporary files for print-changed=diff..
Thu, May 27, 7:20 AM · Restricted Project
jamieschmeiser added a reviewer for D98798: Produce warning for performing pointer arithmetic on a null pointer.: thakis.

ping

Thu, May 27, 6:59 AM · Restricted Project

May 25 2021

jamieschmeiser added a comment to D98798: Produce warning for performing pointer arithmetic on a null pointer..

@thakis, can you please verify that the changes no longer affect the MS headers? Thanks.

May 25 2021, 9:11 AM · Restricted Project

May 20 2021

jamieschmeiser committed rG136ced498ba8: When vector is found as a type or non-type id, check if it is really the… (authored by jamieschmeiser).
When vector is found as a type or non-type id, check if it is really the…
May 20 2021, 9:39 AM
jamieschmeiser closed D100991: Fix parsing of vector keyword in presence of conflicting uses..
May 20 2021, 9:39 AM · Restricted Project
jamieschmeiser updated the diff for D98798: Produce warning for performing pointer arithmetic on a null pointer..

Fix formatting.

May 20 2021, 8:31 AM · Restricted Project
jamieschmeiser updated the diff for D100991: Fix parsing of vector keyword in presence of conflicting uses..

Remove unnecessary tests.

May 20 2021, 7:28 AM · Restricted Project

May 19 2021

jamieschmeiser updated the diff for D100991: Fix parsing of vector keyword in presence of conflicting uses..

Expand testing.

May 19 2021, 1:44 PM · Restricted Project
jamieschmeiser requested review of D98798: Produce warning for performing pointer arithmetic on a null pointer..

Significant changes made since previously accepted.

May 19 2021, 11:17 AM · Restricted Project
jamieschmeiser updated the diff for D98798: Produce warning for performing pointer arithmetic on a null pointer..

As requested, I have added a new warning option -Wnull-pointer-subtraction (and added it to -Wextra) that does not trigger on system headers. In addition, I changed the message used such that it states that it is undefined behaviour for C but may be undefined behaviour in C++ to address the concerns that performing the subtraction with a pointer that dynamically becomes null is not undefined behaviour. Expanded the testing to also test that the warning does not fire on system headers. Also, updated the release notes to indicate the new option.

May 19 2021, 11:15 AM · Restricted Project
jamieschmeiser reopened D98798: Produce warning for performing pointer arithmetic on a null pointer..

Re-opening because it was reverted.

May 19 2021, 5:42 AM · Restricted Project

May 12 2021

jamieschmeiser added a comment to D98798: Produce warning for performing pointer arithmetic on a null pointer..

If this is a problem for you, please revert it and I will take a look when I return. Thanks.

May 12 2021, 11:21 AM · Restricted Project
jamieschmeiser added a comment to D98798: Produce warning for performing pointer arithmetic on a null pointer..

@thakis, I have some questions about your comments.
Are you sure this is coming from a system header? The path that you gave has third_party as a directory in the path. If the warning were being triggered by code in a system header, I would have expected it to fire on something in the windows build bots but they appear to be clean.
I don't know if it is possible to suppress a warning based on whether the source is in a system header, or from a macro expansion that is defined in a system header; are you aware about whether or not this is possible? If it is, I suspect it would already be in force as a general setting, again making me question whether this is a system header...and if it isn't a system header, that wouldn't help you in any case.
If I understand your second point correctly, you have a system that previously compiled cleanly with warnings being treated as errors and you are concerned that if you use the existing options to suppress this particular warning, you are concerned that something could creep in. Therefore you are proposing a different warning group that would be a subgroup of the existing one so that if you set it, you would set both but you would still be able to set the specific one. I don't know if this is possible or not. Either way, I suspect that it would require using a different warning for the subtraction case, which would also require significantly changing these changes. Am I understanding correctly? If so, this implies that you have access to a workaround for your problem, although it may not be the best solution.
I do not have access to a windows setup to test any of these proposed changes; in particular, given that I suspect that the affected files are specific to some third party vendor from which you have purchased code, I do not have means of investigating the actual problems/solutions. If it would be helpful, I would be happy to review any changes that you might like to make to remedy the situation.
I will be on vacation for the next few days so please excuse my delayed responses.

May 12 2021, 9:48 AM · Restricted Project

May 11 2021

jamieschmeiser added a comment to D100991: Fix parsing of vector keyword in presence of conflicting uses..

ping

May 11 2021, 9:26 AM · Restricted Project
jamieschmeiser committed rGdfc1e31d49fe: Produce warning for performing pointer arithmetic on a null pointer. (authored by jamieschmeiser).
Produce warning for performing pointer arithmetic on a null pointer.
May 11 2021, 8:31 AM
jamieschmeiser closed D98798: Produce warning for performing pointer arithmetic on a null pointer..
May 11 2021, 8:31 AM · Restricted Project

May 6 2021

jamieschmeiser updated the diff for D98798: Produce warning for performing pointer arithmetic on a null pointer..

Respond to review comments: add C++ test.

May 6 2021, 1:02 PM · Restricted Project

May 3 2021

jamieschmeiser added a comment to D98798: Produce warning for performing pointer arithmetic on a null pointer..

ping

May 3 2021, 2:01 PM · Restricted Project
jamieschmeiser updated the diff for D100991: Fix parsing of vector keyword in presence of conflicting uses..

Limit tests to platform that supports altivec.

May 3 2021, 1:58 PM · Restricted Project

Apr 21 2021

jamieschmeiser added a comment to D98798: Produce warning for performing pointer arithmetic on a null pointer..

ping

Apr 21 2021, 12:35 PM · Restricted Project
jamieschmeiser requested review of D100991: Fix parsing of vector keyword in presence of conflicting uses..
Apr 21 2021, 12:33 PM · Restricted Project

Apr 15 2021

jamieschmeiser accepted D100231: [NewPM] Cleanup IR printing instrumentation.

LGTM

Apr 15 2021, 5:47 AM · Restricted Project, Restricted Project

Apr 13 2021

jamieschmeiser requested changes to D100231: [NewPM] Cleanup IR printing instrumentation.

Thanks for doing this. There are a couple of comments/asserts that were missed...The only real thing is that the functionality of unwrapping Any is repeated many times... perhaps a function taking lambdas for what to do with each type of IR would be useful, probably in the header with Any? WDYT?

Apr 13 2021, 7:25 AM · Restricted Project, Restricted Project

Apr 12 2021

jamieschmeiser accepted D100237: [NewPM] Fix -print-changed when a -filter-print-funcs function is removed.

LGTM

Apr 12 2021, 11:49 AM · Restricted Project
jamieschmeiser added a comment to D100237: [NewPM] Fix -print-changed when a -filter-print-funcs function is removed.

Do you think that the IR being deleted should be reported rather than silently disappearing from the trace? Perhaps with

Out << "*** IR Deleted" << Name << " ***\n"; 
```before the return?
Apr 12 2021, 7:52 AM · Restricted Project
jamieschmeiser updated the diff for D98798: Produce warning for performing pointer arithmetic on a null pointer..

Fix indenting.

Apr 12 2021, 7:41 AM · Restricted Project

Apr 9 2021

jamieschmeiser updated the diff for D98798: Produce warning for performing pointer arithmetic on a null pointer..

Respond to review comments: Do not issue warning for nullptr - nullptr in C++.

Apr 9 2021, 2:49 PM · Restricted Project
jamieschmeiser added inline comments to D98798: Produce warning for performing pointer arithmetic on a null pointer..
Apr 9 2021, 2:08 PM · Restricted Project
jamieschmeiser added inline comments to D98798: Produce warning for performing pointer arithmetic on a null pointer..
Apr 9 2021, 11:35 AM · Restricted Project
jamieschmeiser added a comment to D100116: Reuse temporary files for print-changed=diff..

They already are removed; see the clean up section of code at the end of the function.

Apr 9 2021, 10:33 AM · Restricted Project
jamieschmeiser updated the diff for D98798: Produce warning for performing pointer arithmetic on a null pointer..

Respond to review comments: add requested test.

Apr 9 2021, 9:46 AM · Restricted Project
jamieschmeiser added a comment to D100116: Reuse temporary files for print-changed=diff..

I suspect it may have something to do with name collisions in the calls to create a unique file name. It says that it loops a set number of times trying permutations and I think it just runs out of permutations, partly because the name doesn't have special characters allowing extra permutations. The uses of the file cannot collide (unless the pass manager becomes multi-threaded) so static solves the problem.

Apr 9 2021, 8:34 AM · Restricted Project

Apr 8 2021

jamieschmeiser updated the diff for D98798: Produce warning for performing pointer arithmetic on a null pointer..

Reformat to satisfy clang-format

Apr 8 2021, 9:30 AM · Restricted Project
jamieschmeiser requested review of D100116: Reuse temporary files for print-changed=diff..
Apr 8 2021, 8:33 AM · Restricted Project

Mar 29 2021

jamieschmeiser retitled D98798: Produce warning for performing pointer arithmetic on a null pointer. from Produce waring for performing pointer arithmetic on a null pointer. to Produce warning for performing pointer arithmetic on a null pointer..
Mar 29 2021, 6:29 AM · Restricted Project
jamieschmeiser added reviewers for D98798: Produce warning for performing pointer arithmetic on a null pointer.: rsmith, efriedma, hfinkel.

Added more reviewers.

Mar 29 2021, 6:24 AM · Restricted Project

Mar 25 2021

jamieschmeiser committed rG7f2ae3d55f19: add print-change diff modes that do not use colour (authored by jamieschmeiser).
add print-change diff modes that do not use colour
Mar 25 2021, 7:36 AM
jamieschmeiser closed D97398: add print-changed mode that does not use colour.
Mar 25 2021, 7:36 AM · Restricted Project

Mar 23 2021

jamieschmeiser added a comment to D86657: Add new hidden option -print-crash-IR that prints out IR that caused opt pipeline to crash.

The build problem is that __builtin_trap is not recognized in PassBuilder.cpp.

Mar 23 2021, 7:21 AM · Restricted Project
jamieschmeiser reopened D86657: Add new hidden option -print-crash-IR that prints out IR that caused opt pipeline to crash.

The Buildbot has detected a failed build on builder mlir-windows while building llvm.

Mar 23 2021, 7:14 AM · Restricted Project
jamieschmeiser added a reverting change for rG9544a32287ec: A new option -print-on-crash that prints the IR as it was upon entering the…: rG64336d3421aa: Revert "A new option -print-on-crash that prints the IR as it was upon entering….
Mar 23 2021, 7:10 AM
jamieschmeiser committed rG64336d3421aa: Revert "A new option -print-on-crash that prints the IR as it was upon entering… (authored by jamieschmeiser).
Revert "A new option -print-on-crash that prints the IR as it was upon entering…
Mar 23 2021, 7:10 AM
jamieschmeiser added a reverting change for D86657: Add new hidden option -print-crash-IR that prints out IR that caused opt pipeline to crash: rG64336d3421aa: Revert "A new option -print-on-crash that prints the IR as it was upon entering….
Mar 23 2021, 7:10 AM · Restricted Project
jamieschmeiser committed rG9544a32287ec: A new option -print-on-crash that prints the IR as it was upon entering the… (authored by jamieschmeiser).
A new option -print-on-crash that prints the IR as it was upon entering the…
Mar 23 2021, 6:30 AM
jamieschmeiser closed D86657: Add new hidden option -print-crash-IR that prints out IR that caused opt pipeline to crash.
Mar 23 2021, 6:30 AM · Restricted Project

Mar 22 2021

jamieschmeiser updated the diff for D86657: Add new hidden option -print-crash-IR that prints out IR that caused opt pipeline to crash.

Rebased and updated call to registerBeforeNonSkippedPassCallback. Also removed extra blank line at end of test.

Mar 22 2021, 10:05 AM · Restricted Project

Mar 17 2021

jamieschmeiser added a comment to D98798: Produce warning for performing pointer arithmetic on a null pointer..

I used formatting similar to the existing code, which is not what clang-format is expecting.

Mar 17 2021, 11:07 AM · Restricted Project
jamieschmeiser requested review of D98798: Produce warning for performing pointer arithmetic on a null pointer..
Mar 17 2021, 11:06 AM · Restricted Project

Feb 24 2021

jamieschmeiser added a comment to D86657: Add new hidden option -print-crash-IR that prints out IR that caused opt pipeline to crash.

Yes, it is ready to land. There was a fair bit of discussion during the review so I left it after it was accepted in case there were still concerns. The mutex code was added because it was requested in review. IIRC, there were concerns about multiple pass managers registering signal handlers. Since it is for debugging, efficiency of the mutex code is not as important.

Feb 24 2021, 12:06 PM · Restricted Project
jamieschmeiser added a comment to D97398: add print-changed mode that does not use colour.

Sure, the auto-detection could be used as you suggest, but the control is still needed by the user. Consider what happens when auto-detection says the system supports colour and the user captures the output to a file. They then bring it up in an editor (say vim or emacs) which doesn't recognize the colour characters and show as ^[[31m- and ^[[31m+ (in emacs or vim). By giving the user control over whether they are generated, they can include them if they are examining the results on a screen (or using more) or strip them out when they plan to capture and edit the results (for large changes).

Feb 24 2021, 11:44 AM · Restricted Project
jamieschmeiser added a comment to D97398: add print-changed mode that does not use colour.

I don't think we want auto-detection because the user needs to be able to control it. If it is just going to the screen, the colour is useful, but if the output is being captured and brought up in emacs/vim/etc, the colour characters just show as control characters. less on LINUX doesn't handle the colour characters; other utilities may also have problems with them.

Feb 24 2021, 11:21 AM · Restricted Project
jamieschmeiser requested review of D97398: add print-changed mode that does not use colour.
Feb 24 2021, 9:37 AM · Restricted Project

Feb 23 2021

jamieschmeiser added a comment to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Don't apologize for "slow reviews," I appreciate your taking the time to review all of these changes. If there is anything I can do to make it easier, please let me know.

Feb 23 2021, 6:30 AM · Restricted Project
jamieschmeiser updated the diff for D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Rebase to facilitate applying patch. Also, I removed the indenting for a grouping of links as I don't think it was useful.

Feb 23 2021, 6:28 AM · Restricted Project

Feb 8 2021

jamieschmeiser added a comment to D88515: Add dot-cfg-changes style view to the llvm-diff tool.

This will require changes based on changes that have been made to the code it uses. The changes will be made after that code lands.

Feb 8 2021, 2:44 PM · Restricted Project
jamieschmeiser updated the diff for D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Updated the code to reflect various changes made in reviews
for the other change printers that have landed. Also added
unit tests.

Feb 8 2021, 2:42 PM · Restricted Project
jamieschmeiser committed rG4b661b4059b0: Introduce -print-changed=[diff | diff-quiet] which show changes in patch-like… (authored by jamieschmeiser).
Introduce -print-changed=[diff | diff-quiet] which show changes in patch-like…
Feb 8 2021, 7:12 AM
jamieschmeiser closed D91890: Introduce -print-changed=[diff | diff-quiet] which show changes in patch-like format.
Feb 8 2021, 7:11 AM · Restricted Project

Jan 28 2021

jamieschmeiser added a comment to D86657: Add new hidden option -print-crash-IR that prints out IR that caused opt pipeline to crash.

I think that is a great idea, especially since it is likely it is being captured anyway... Perhaps with -print-on-crash=<filename> with the current behaviour when =<filename> is not specified? As a subsequent change rather than in this one.

Jan 28 2021, 10:05 AM · Restricted Project

Jan 26 2021

jamieschmeiser updated the diff for D91890: Introduce -print-changed=[diff | diff-quiet] which show changes in patch-like format.

Respond to review comments. Minor changes including fixing typos, using function_ref, enum classes and moving code around.

Jan 26 2021, 9:16 AM · Restricted Project

Jan 19 2021

jamieschmeiser updated the diff for D91890: Introduce -print-changed=[diff | diff-quiet] which show changes in patch-like format.

Respond to review comments:
Establish an ordering based on the "after" ordering with the removed
sections interspersed. This ordering is applied to get the basic blocks
in the order they are in the function and also applied to the functions
to get them into the same order they are in the module.

Jan 19 2021, 6:55 AM · Restricted Project

Jan 15 2021

jamieschmeiser committed rG17d0fb7f574e: Set option default for enabling memory ssa for new pass manager loop sink pass… (authored by jamieschmeiser).
Set option default for enabling memory ssa for new pass manager loop sink pass…
Jan 15 2021, 6:57 AM
jamieschmeiser closed D92486: Set option default for enabling memory ssa for new pass manager loop sink pass to true..
Jan 15 2021, 6:57 AM · Restricted Project

Jan 14 2021

jamieschmeiser updated the diff for D91890: Introduce -print-changed=[diff | diff-quiet] which show changes in patch-like format.

Updated option control to be -print-changed=[diff | diff-quiet]

rather than a separate option.  This also introduces the
quiet mode.  Change/add tests accordingly.
Jan 14 2021, 12:16 PM · Restricted Project

Jan 11 2021

jamieschmeiser committed rG43a830ed9418: Introduce new quiet mode and new option handling for -print-changed. (authored by jamieschmeiser).
Introduce new quiet mode and new option handling for -print-changed.
Jan 11 2021, 11:16 AM
jamieschmeiser closed D92589: Introduce new quiet mode and new option handling for -print-changed..
Jan 11 2021, 11:16 AM · Restricted Project

Dec 18 2020

jamieschmeiser added a comment to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

A new quiet mode for change printers is being considered in https://reviews.llvm.org/D92589. I will likely have to change this patch based on the results of that, which would introduce a quiet mode into this change reporter also.

Dec 18 2020, 10:14 AM · Restricted Project
jamieschmeiser added a comment to D91890: Introduce -print-changed=[diff | diff-quiet] which show changes in patch-like format.

I would like to change the option handling for this based on the discussions in https://reviews.llvm.org/D92589. In particular, I was thinking that this option could be controlled using -print-changed=diff and -print-changed=diff-quiet rather than using a separate option. WDYT? I will wait until that patch is settled before making further changes to this one.

Dec 18 2020, 10:08 AM · Restricted Project
jamieschmeiser updated the diff for D92589: Introduce new quiet mode and new option handling for -print-changed..

I have changed the option handling as discussed and used the optional
string on the option as you suggested. I have also changed this from
being a separate change printer to being an option on the base class.
This way, they other proposed change printers can also benefit by getting
the verbose/quiet modes using the same code.

Dec 18 2020, 10:03 AM · Restricted Project

Dec 9 2020

jamieschmeiser added a comment to D92589: Introduce new quiet mode and new option handling for -print-changed..

I was thinking about a slightly different approach for these options. There are several different options (-print-changed, print-changed-diff, -dot-cfg-changed ) with different variations. As you say, it doesn't make sense to use more than one at a time so I was thinking that perhaps there could be -print-changed, and -print-changed-options=<options>. Without -print-changed-options, you would get this one (ie, before and after without banners for no changed, ignored, etc). The options would be a string of characters v being verbose (all banners), b is -print-before-changed, p is patch format (-print-changed-diff which could also have a verbose mode as currently up for review and default to skipping other banners). -dot-cfg-changed (also with/without verbose mode) would be d=string, b=string, a=string, c=string with strings going to the end of input or comma where d, b, a and c being the directory, before colour, after colour and common colour. The option letters can change, the important thing is the idea of the first option saying you want some form of change reporter (defaulting to this nonverbose print-changed version) and a modifier option that picks and controls the various types of reporter. WDYT?

Dec 9 2020, 9:50 AM · Restricted Project

Dec 7 2020

jamieschmeiser added a comment to D86657: Add new hidden option -print-crash-IR that prints out IR that caused opt pipeline to crash.

@yrouban, @aeubanks indicated that he is satisfied but would like you to sign off on the signal handler.

Dec 7 2020, 12:57 PM · Restricted Project
jamieschmeiser updated the diff for D91890: Introduce -print-changed=[diff | diff-quiet] which show changes in patch-like format.

I have removed the templates and the compare hierarchy
because they are not necessary for this change reporter.
They will have to be re-introduced for the final reporter as
it builds on this one but their removal simplifies this review.

Dec 7 2020, 12:52 PM · Restricted Project

Dec 3 2020

jamieschmeiser requested review of D92589: Introduce new quiet mode and new option handling for -print-changed..
Dec 3 2020, 10:40 AM · Restricted Project
jamieschmeiser accepted D87216: [NewPM] Support --print-before/after in NPM.

LGTM

Dec 3 2020, 6:25 AM · Restricted Project, Restricted Project

Dec 2 2020

jamieschmeiser added a comment to D87216: [NewPM] Support --print-before/after in NPM.

I previously saw unrelated changes showing up in the differences here but this no longer seems to be the case so that comment can be ignored.

Dec 2 2020, 1:56 PM · Restricted Project, Restricted Project
jamieschmeiser updated the summary of D92486: Set option default for enabling memory ssa for new pass manager loop sink pass to true..
Dec 2 2020, 12:09 PM · Restricted Project
jamieschmeiser updated the summary of D92486: Set option default for enabling memory ssa for new pass manager loop sink pass to true..
Dec 2 2020, 12:09 PM · Restricted Project
jamieschmeiser updated the diff for D92486: Set option default for enabling memory ssa for new pass manager loop sink pass to true..

Remove changes pertaining to legacy pass manager.

Dec 2 2020, 12:08 PM · Restricted Project
jamieschmeiser updated the diff for D91890: Introduce -print-changed=[diff | diff-quiet] which show changes in patch-like format.

Respond to review comments: change option name to print-changed-diff,
change function name and change code to use ExecuteAndWait.

Dec 2 2020, 11:11 AM · Restricted Project
jamieschmeiser requested review of D92486: Set option default for enabling memory ssa for new pass manager loop sink pass to true..
Dec 2 2020, 7:34 AM · Restricted Project
jamieschmeiser added a comment to D87216: [NewPM] Support --print-before/after in NPM.

I see you have made the requested changes (nit: clang-tidy complained about the capitalization of the function) but why are there so many other, unrelated changes shown? Is there a problem with the patch?

Dec 2 2020, 6:18 AM · Restricted Project, Restricted Project

Dec 1 2020

jamieschmeiser added a comment to D87216: [NewPM] Support --print-before/after in NPM.

I agree that having the callbacks ask for the names is an improvement as it is cleaner and allows other callbacks to use this feature if desired. Generally, things look good. I have a couple of minor concerns mentioned in the code but I think it would be acceptable as is if you don't agree with what I've mentioned.

Dec 1 2020, 12:36 PM · Restricted Project, Restricted Project
jamieschmeiser added a comment to D91890: Introduce -print-changed=[diff | diff-quiet] which show changes in patch-like format.

The template base classes are also used for -dot-cfg-changes, which shows the diff by making a website and showing the changes in dot-cfg form with the added code shown in green and the deleted code shown in red. The template parameters are the data structures needed for that display, while they are just empty structs in this change reporter. https://reviews.llvm.org/D87202 has the changes for that change reporter but the changes are out-of-date as they build on the original patch for this change reporter (which has been split up), but the data structures used by the templates for that change reporter can be seen in that patch.

Dec 1 2020, 9:50 AM · Restricted Project
jamieschmeiser updated the summary of D91890: Introduce -print-changed=[diff | diff-quiet] which show changes in patch-like format.
Dec 1 2020, 9:34 AM · Restricted Project

Nov 20 2020

jamieschmeiser updated the diff for D91890: Introduce -print-changed=[diff | diff-quiet] which show changes in patch-like format.

Changes based on clang-tidy/format

Nov 20 2020, 3:22 PM · Restricted Project
jamieschmeiser requested review of D91890: Introduce -print-changed=[diff | diff-quiet] which show changes in patch-like format.
Nov 20 2020, 12:51 PM · Restricted Project
jamieschmeiser committed rG7f6360cdc68e: Reland: Expand existing loopsink testing to also test loopsinking using new… (authored by jamieschmeiser).
Reland: Expand existing loopsink testing to also test loopsinking using new…
Nov 20 2020, 7:27 AM
jamieschmeiser closed D90249: Add options to enable memoryssa for loopsink, expand loopsink testing and fix exposed bug in LICM.
Nov 20 2020, 7:27 AM · Restricted Project
jamieschmeiser committed rG621efa6a5a96: [NFC intended] Refactor the code for printChanged for reuse and to facilitate… (authored by jamieschmeiser).
[NFC intended] Refactor the code for printChanged for reuse and to facilitate…
Nov 20 2020, 6:51 AM
jamieschmeiser closed D87000: [NFC intended] Refactor code for print-changed to facilitate reuse..
Nov 20 2020, 6:51 AM · Restricted Project

Nov 19 2020

jamieschmeiser updated the diff for D87000: [NFC intended] Refactor code for print-changed to facilitate reuse..

Rebasing code on latest master before delivering

Nov 19 2020, 10:50 AM · Restricted Project
jamieschmeiser updated the diff for D90249: Add options to enable memoryssa for loopsink, expand loopsink testing and fix exposed bug in LICM.

@nikic I have moved the test for profile data before the calculation of the alias sets.

Nov 19 2020, 7:50 AM · Restricted Project

Nov 18 2020

jamieschmeiser committed rGcff479b14528: Revert "Revert "Revert "Expand existing loopsink testing to also test… (authored by jamieschmeiser).
Revert "Revert "Revert "Expand existing loopsink testing to also test…
Nov 18 2020, 1:08 PM
jamieschmeiser added a reverting change for rGe29292969b92: Revert "Revert "Expand existing loopsink testing to also test loopsinking using…: rGcff479b14528: Revert "Revert "Revert "Expand existing loopsink testing to also test….
Nov 18 2020, 1:08 PM