Page MenuHomePhabricator

jamieschmeiser (Jamie Schmeiser)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2020, 11:14 AM (104 w, 2 d)

Recent Activity

Thu, Aug 11

jamieschmeiser added a comment to D131469: [Clang] change default storing path of `-ftime-trace`.

You should not have debugging information in code that is up for review. If this is debugging information that you plan to leave in for future purposes (which I doubt is the case here), you need to protect it so that it isn't active unless some option is set. For example, see LLVM_DEBUG code that lives in various opt routines.

Thu, Aug 11, 6:02 AM · Restricted Project, Restricted Project

Mon, Aug 8

jamieschmeiser accepted D130596: [StandardInstrumentations] Handle case where block order changes.

LGTM. Thanks.

Mon, Aug 8, 5:50 AM · Restricted Project, Restricted Project

Fri, Aug 5

jamieschmeiser added a comment to D130596: [StandardInstrumentations] Handle case where block order changes.

Sorry for the delay, missed this before going on vacation.

Fri, Aug 5, 12:02 PM · Restricted Project, Restricted Project

Wed, Jul 27

jamieschmeiser accepted D130587: [StandardInstrumentations] Assign names to basic blocks without names.

I'm wondering what would happen (after this change) if a function were to re-order the blocks (without any other change). EG, the first 2 blocks in the function are swapped in the function list of blocks with no other change. I suspect that this would then indicate that the change was the original block 1 was replaced with the new block 2 and the original block 2 was replaced with the new block 1 with the corresponding changes to the branches. I think that may be unavoidable since the comparisons are string based. Besides, it is better than crashing...

Wed, Jul 27, 1:40 PM · Restricted Project, Restricted Project

Tue, Jul 26

jamieschmeiser accepted D130434: [MachineFunctionPass] Support -print-changed and -print-changed=quiet.

Since you have the before and after versions, I expect you could get -print-changed=diff and cdiff without too much difficulty by calling the diff routine that the opt print-changed options use, if you want to expand this functionality.

Tue, Jul 26, 6:46 AM · Restricted Project, Restricted Project

Jul 11 2022

jamieschmeiser accepted D128048: Add a new clang option "-ftime-trace=<value>".

LGTM. Thanks.

Jul 11 2022, 8:20 AM · Restricted Project, Restricted Project

Jun 24 2022

jamieschmeiser added a comment to D128048: Add a new clang option "-ftime-trace=<value>".

You may add -ftime-trace=<file> instead of introducing a new spelling.

Jun 24 2022, 7:48 AM · Restricted Project, Restricted Project

Jun 23 2022

jamieschmeiser added inline comments to D128048: Add a new clang option "-ftime-trace=<value>".
Jun 23 2022, 12:36 PM · Restricted Project, Restricted Project

Jun 22 2022

jamieschmeiser added a comment to D128048: Add a new clang option "-ftime-trace=<value>".

Can you please use git rebase -i to collapse all the changes into a single change? If this isn't done, it is difficult to know what is being reviewed as the changes only show the differences since your last revision, not all of the changes.

I can see all the changes, make sure your link is not suffix with "new", or check the history tab to see what is it comparing.

Jun 22 2022, 8:58 AM · Restricted Project, Restricted Project
jamieschmeiser added a comment to D128048: Add a new clang option "-ftime-trace=<value>".

Can you please use git rebase -i to collapse all the changes into a single change? If this isn't done, it is difficult to know what is being reviewed as the changes only show the differences since your last revision, not all of the changes.

Jun 22 2022, 6:39 AM · Restricted Project, Restricted Project

Jun 17 2022

jamieschmeiser requested changes to D128048: Add a new clang option "-ftime-trace=<value>".

This is a good start. You should mention in the summary that when -c is not specified, the compiler is invoked with -o pointing at /tmp so the .json file will currently be placed there, which is confusing.

Jun 17 2022, 10:50 AM · Restricted Project, Restricted Project

Jun 6 2022

jamieschmeiser committed rG41778e3dc5f4: [NFC] Change lit test for print-changed=dot-cfg to use regular expression (authored by jamieschmeiser).
[NFC] Change lit test for print-changed=dot-cfg to use regular expression
Jun 6 2022, 12:54 PM · Restricted Project, Restricted Project
jamieschmeiser closed D126876: Change lit test for print-changed=dot-cfg to use regular expression.
Jun 6 2022, 12:53 PM · Restricted Project, Restricted Project

Jun 3 2022

jamieschmeiser committed rGefbf0136b410: Only issue warning for subtraction involving null pointers on live code paths (authored by jamieschmeiser).
Only issue warning for subtraction involving null pointers on live code paths
Jun 3 2022, 7:12 AM · Restricted Project, Restricted Project
jamieschmeiser closed D126816: Only issue warning for subtraction involving null pointers on live code paths.
Jun 3 2022, 7:12 AM · Restricted Project, Restricted Project

Jun 2 2022

jamieschmeiser updated the diff for D126816: Only issue warning for subtraction involving null pointers on live code paths.

Respond to review comments: add cpp test.

Jun 2 2022, 7:10 AM · Restricted Project, Restricted Project
jamieschmeiser requested review of D126876: Change lit test for print-changed=dot-cfg to use regular expression.
Jun 2 2022, 5:45 AM · Restricted Project, Restricted Project

Jun 1 2022

jamieschmeiser requested review of D126816: Only issue warning for subtraction involving null pointers on live code paths.
Jun 1 2022, 1:20 PM · Restricted Project, Restricted Project

Mar 8 2022

jamieschmeiser added a comment to D86657: Add new hidden option -print-on-crash that prints out IR that caused opt pipeline to crash.

Thanks!

Mar 8 2022, 10:35 AM · Restricted Project, Restricted Project

Dec 16 2021

jamieschmeiser reopened D110776: A new hidden option exec-on-ir-change=exe that calls exe after each time IR changes.

Failing build: https://lab.llvm.org/buildbot/#/builders/42/builds/2800

Dec 16 2021, 7:56 AM · Restricted Project
jamieschmeiser added a reverting change for rGdff0e8b4ff13: A new hidden option exec-on-ir-change=exe that calls exe each time IR changes: rG864ca4248354: Revert "A new hidden option exec-on-ir-change=exe that calls exe each time IR….
Dec 16 2021, 7:54 AM
jamieschmeiser committed rG864ca4248354: Revert "A new hidden option exec-on-ir-change=exe that calls exe each time IR… (authored by jamieschmeiser).
Revert "A new hidden option exec-on-ir-change=exe that calls exe each time IR…
Dec 16 2021, 7:54 AM
jamieschmeiser added a reverting change for D110776: A new hidden option exec-on-ir-change=exe that calls exe after each time IR changes: rG864ca4248354: Revert "A new hidden option exec-on-ir-change=exe that calls exe each time IR….
Dec 16 2021, 7:54 AM · Restricted Project
jamieschmeiser committed rGdff0e8b4ff13: A new hidden option exec-on-ir-change=exe that calls exe each time IR changes (authored by jamieschmeiser).
A new hidden option exec-on-ir-change=exe that calls exe each time IR changes
Dec 16 2021, 6:02 AM
jamieschmeiser closed D110776: A new hidden option exec-on-ir-change=exe that calls exe after each time IR changes.
Dec 16 2021, 6:02 AM · Restricted Project

Dec 15 2021

jamieschmeiser updated subscribers of D110776: A new hidden option exec-on-ir-change=exe that calls exe after each time IR changes.

It was suggested by @reames that -exec-on-ir-change=exe is a better name for the option. This sounds like a good suggestion to me so I have renamed it.

Dec 15 2021, 12:31 PM · Restricted Project
jamieschmeiser updated the diff for D110776: A new hidden option exec-on-ir-change=exe that calls exe after each time IR changes.

renamed option to -exec-on-ir-change

Dec 15 2021, 12:27 PM · Restricted Project

Dec 14 2021

jamieschmeiser committed rG6fef0ffa14a3: Revert unnecessary and incorrect change made to GraphWriter (authored by jamieschmeiser).
Revert unnecessary and incorrect change made to GraphWriter
Dec 14 2021, 5:43 AM
jamieschmeiser closed D115649: Revert unnecessary and incorrect change made to GraphWriter.
Dec 14 2021, 5:43 AM · Restricted Project

Dec 13 2021

jamieschmeiser added a comment to D115649: Revert unnecessary and incorrect change made to GraphWriter.

I see. Yes, that would be a nice feature.

Dec 13 2021, 12:14 PM · Restricted Project
jamieschmeiser added a comment to D115649: Revert unnecessary and incorrect change made to GraphWriter.

Yes, it would be nice. BTW, the choice is not hard coded but is specified with DefaultDOTGraphTraits::renderNodesUsingHTML() and stored in the ctor since it is unlikely that an HTML and non-HTML mix would be desirable.

Dec 13 2021, 12:03 PM · Restricted Project
jamieschmeiser requested review of D115649: Revert unnecessary and incorrect change made to GraphWriter.
Dec 13 2021, 10:11 AM · Restricted Project
jamieschmeiser added a comment to D110776: A new hidden option exec-on-ir-change=exe that calls exe after each time IR changes.

Yes, bugpoint will find a misbehaving class but that is just one example usage for this. test-changed is more general in that any script/exe can be called each time the IR changes. Consider the situation where a performance degradation is noticed so the code still compiles but is not as well optimized. bugpoint (as I understand from the documation) will not detect this because the IR still compiles and the exe still runs. Using test-changed and a script that calls llc followed by a timed execution, one could determine how much impact the various passes have on the performance of the code as it gets changed in the pipeline. This could point out the source(s) of speed-ups and slow-downs in the pipeline and could be used as an exploration tool.

Dec 13 2021, 9:28 AM · Restricted Project
jamieschmeiser added inline comments to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..
Dec 13 2021, 8:29 AM · Restricted Project

Dec 9 2021

jamieschmeiser updated the diff for D110776: A new hidden option exec-on-ir-change=exe that calls exe after each time IR changes.

Replace the shell script with just calling cat directly. cat is used in many lit tests and will cat the IR file and will give an error that no file exists with the name of the pass and this can be checked. @thakis, can you please verify that this does not break the windows build?

Dec 9 2021, 9:23 AM · Restricted Project
jamieschmeiser reopened D110776: A new hidden option exec-on-ir-change=exe that calls exe after each time IR changes.

@aeubanks Thanks for reverting it. I'll take a look.

Dec 9 2021, 7:02 AM · Restricted Project

Dec 8 2021

jamieschmeiser committed rGf9235e45fd1f: A new hidden option test-changed=exe that calls exe after each time IR changes (authored by jamieschmeiser).
A new hidden option test-changed=exe that calls exe after each time IR changes
Dec 8 2021, 11:23 AM
jamieschmeiser closed D110776: A new hidden option exec-on-ir-change=exe that calls exe after each time IR changes.
Dec 8 2021, 11:23 AM · Restricted Project
jamieschmeiser committed rG84687405ce4d: Remove Colours array in -print-changed=dot-cfg (authored by jamieschmeiser).
Remove Colours array in -print-changed=dot-cfg
Dec 8 2021, 6:51 AM
jamieschmeiser closed D115175: Remove Colours array in -print-changed=dot-cfg.
Dec 8 2021, 6:51 AM · Restricted Project

Dec 7 2021

jamieschmeiser updated the diff for D115175: Remove Colours array in -print-changed=dot-cfg.

I've updated the patch with some changes to same parameter names (V -> Value, etc) and corresponding comments. The only substantive change in the update is that I changed DotCfgDiffNode::getEdge to DotCfgDiffNode::getEdgeColour and had it return a StringRef to the colour instead of the std::pair it previously did since the only use just extracted the colour from the pair (lines 1496 and 1769).

Dec 7 2021, 11:23 AM · Restricted Project
jamieschmeiser added inline comments to D115175: Remove Colours array in -print-changed=dot-cfg.
Dec 7 2021, 11:15 AM · Restricted Project

Dec 6 2021

jamieschmeiser added inline comments to D110776: A new hidden option exec-on-ir-change=exe that calls exe after each time IR changes.
Dec 6 2021, 12:13 PM · Restricted Project
jamieschmeiser added inline comments to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..
Dec 6 2021, 12:03 PM · Restricted Project
jamieschmeiser requested review of D115175: Remove Colours array in -print-changed=dot-cfg.
Dec 6 2021, 12:01 PM · Restricted Project
jamieschmeiser added inline comments to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..
Dec 6 2021, 7:43 AM · Restricted Project

Dec 2 2021

jamieschmeiser added a comment to D110776: A new hidden option exec-on-ir-change=exe that calls exe after each time IR changes.

ping

Dec 2 2021, 7:09 AM · Restricted Project
jamieschmeiser committed rG2a1bf9e0cf78: Expand testing of necessary features for print-changed=dot-cfg. (authored by jamieschmeiser).
Expand testing of necessary features for print-changed=dot-cfg.
Dec 2 2021, 5:17 AM
jamieschmeiser added a comment to D113187: Improve unsupported lit test config for print-changed=dot-cfg.

The dot documentation I saw recommended this method of checking whether an output format was supported.

Dec 2 2021, 5:17 AM · Restricted Project
jamieschmeiser closed D113187: Improve unsupported lit test config for print-changed=dot-cfg.
Dec 2 2021, 5:16 AM · Restricted Project

Nov 30 2021

jamieschmeiser added a comment to D113187: Improve unsupported lit test config for print-changed=dot-cfg.

ping

Nov 30 2021, 1:25 PM · Restricted Project

Nov 8 2021

jamieschmeiser updated the diff for D110776: A new hidden option exec-on-ir-change=exe that calls exe after each time IR changes.

Respond to review comments: remove templates in functions for temporary file creation and cleanup.

Nov 8 2021, 11:49 AM · Restricted Project

Nov 4 2021

jamieschmeiser committed rG8720149d9bb1: Remove unused function from print-changed=dot-cfg code (authored by jamieschmeiser).
Remove unused function from print-changed=dot-cfg code
Nov 4 2021, 7:41 AM
jamieschmeiser closed D113188: Remove unused function from print-changed=dot-cfg code.
Nov 4 2021, 7:41 AM · Restricted Project
jamieschmeiser added a comment to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Hi @uabelho, the function is unnecessary and has been removed in https://reviews.llvm.org/D113188

Nov 4 2021, 7:18 AM · Restricted Project
jamieschmeiser requested review of D113188: Remove unused function from print-changed=dot-cfg code.
Nov 4 2021, 7:16 AM · Restricted Project
jamieschmeiser added a comment to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Hi @hvdijk, a fix for the lit-test problem is up for review in https://reviews.llvm.org/D113187

Nov 4 2021, 7:12 AM · Restricted Project
jamieschmeiser requested review of D113187: Improve unsupported lit test config for print-changed=dot-cfg.
Nov 4 2021, 7:10 AM · Restricted Project

Nov 2 2021

jamieschmeiser added a comment to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Hi @tpopp, yes, it looks fine. Thanks!

Nov 2 2021, 10:31 AM · Restricted Project
jamieschmeiser added a comment to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Hi @tpopp, can you please explain to me the nature of these failures? The code changed here is only active under options that are not being used in those tests so I expect that the errors are unrelated. I have not received any notifications from the build-bots of a problem so far. I am also unclear as to why there are build issues on those other platforms. Are you asking me to revert this?

Nov 2 2021, 10:20 AM · Restricted Project
jamieschmeiser committed rG816761f04484: Add new choices dot-cfg and dot-cfg-quiet to print-changed. (authored by jamieschmeiser).
Add new choices dot-cfg and dot-cfg-quiet to print-changed.
Nov 2 2021, 9:06 AM
jamieschmeiser closed D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..
Nov 2 2021, 9:06 AM · Restricted Project

Nov 1 2021

jamieschmeiser updated the diff for D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Respond to review comments, remove nolint instructions and clean
up unit tests.

Nov 1 2021, 9:27 AM · Restricted Project

Oct 19 2021

jamieschmeiser updated the diff for D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Update after landing of D110737 which had most of the changes to existing code.

Oct 19 2021, 10:38 AM · Restricted Project
jamieschmeiser committed rG3af474c0a15a: Changes to print-changed classes in preparation for DotCfg change printer (authored by jamieschmeiser).
Changes to print-changed classes in preparation for DotCfg change printer
Oct 19 2021, 7:59 AM
jamieschmeiser closed D110737: Changes to print-changed classes in preparation for DotCfg change printer (https://reviews.llvm.org/D87202).
Oct 19 2021, 7:58 AM · Restricted Project

Oct 7 2021

jamieschmeiser added a comment to D86657: Add new hidden option -print-on-crash that prints out IR that caused opt pipeline to crash.

missed @MaskRay 's comment, will add that before attempting a relanding

Oct 7 2021, 12:48 PM · Restricted Project, Restricted Project
jamieschmeiser reopened D86657: Add new hidden option -print-on-crash that prints out IR that caused opt pipeline to crash.

Failed the lit test.
https://lab.llvm.org/buildbot/#/builders/110/builds/6977
https://lab.llvm.org/buildbot/#/builders/36/builds/13137
https://lab.llvm.org/buildbot/#/builders/52/builds/11218

Oct 7 2021, 12:46 PM · Restricted Project, Restricted Project
jamieschmeiser added a reverting change for rG13d1592716a6: Reland A new option -print-on-crash that prints the IR as it was upon entering…: rGbd5befb55087: Revert "Reland A new option -print-on-crash that prints the IR as it was upon….
Oct 7 2021, 12:24 PM
jamieschmeiser committed rGbd5befb55087: Revert "Reland A new option -print-on-crash that prints the IR as it was upon… (authored by jamieschmeiser).
Revert "Reland A new option -print-on-crash that prints the IR as it was upon…
Oct 7 2021, 12:24 PM
jamieschmeiser added a reverting change for D86657: Add new hidden option -print-on-crash that prints out IR that caused opt pipeline to crash: rGbd5befb55087: Revert "Reland A new option -print-on-crash that prints the IR as it was upon….
Oct 7 2021, 12:24 PM · Restricted Project, Restricted Project
jamieschmeiser committed rG13d1592716a6: Reland A new option -print-on-crash that prints the IR as it was upon entering… (authored by jamieschmeiser).
Reland A new option -print-on-crash that prints the IR as it was upon entering…
Oct 7 2021, 12:03 PM
jamieschmeiser closed D86657: Add new hidden option -print-on-crash that prints out IR that caused opt pipeline to crash.
Oct 7 2021, 12:03 PM · Restricted Project, Restricted Project
jamieschmeiser accepted D111282: Don't print uselistorder in --print-changed.

LGTM, thanks

Oct 7 2021, 11:48 AM · Restricted Project
jamieschmeiser requested changes to D111282: Don't print uselistorder in --print-changed.

As I recall, I added this in based on comments in the review and I am fine with removing it. However, the parameter to unWrapAndPrint was added to preserve existing function and if this is removed, then the parameter should also be removed as it will always be false. The parameter can be dropped from the call to print also, as it defaults to false.

Oct 7 2021, 7:40 AM · Restricted Project
jamieschmeiser added inline comments to D110737: Changes to print-changed classes in preparation for DotCfg change printer (https://reviews.llvm.org/D87202).
Oct 7 2021, 5:56 AM · Restricted Project

Oct 5 2021

jamieschmeiser updated the diff for D86657: Add new hidden option -print-on-crash that prints out IR that caused opt pipeline to crash.

Remove unnecessary include.

Oct 5 2021, 6:24 AM · Restricted Project, Restricted Project

Oct 4 2021

jamieschmeiser updated the diff for D86657: Add new hidden option -print-on-crash that prints out IR that caused opt pipeline to crash.

Added the usual filtering options (filter-passes and filter-print-func) with uninteresting passes being saved with a message that they were filtered out. This should speed up things significantly when they are used. If the user isn't aware of the name of the crashing pass, they can use -filter-passes=blah (where blah doesn't exist) and they will get a message saying that the pass was filtered out. They can discover the name from that message and then rerun it with -filter-passes.

Oct 4 2021, 7:24 AM · Restricted Project, Restricted Project

Sep 30 2021

jamieschmeiser added a comment to D86657: Add new hidden option -print-on-crash that prints out IR that caused opt pipeline to crash.

I think I am getting confused with llvm-extract --func=<function> which will extract what is needed for a function from a module IR. However, one could likely use that to get an IR with the necessary addition declarations and then substitute in the IR for the function using this option. I wonder if it might be possible to use the code in llvm-extract to do that automatically? Something to think about...

Sep 30 2021, 12:32 PM · Restricted Project, Restricted Project
jamieschmeiser updated the diff for D86657: Add new hidden option -print-on-crash that prints out IR that caused opt pipeline to crash.

Regarding always printing the module, I'm not sure that is desirable. The
problematic IR may be very large and the option respects -print-module-scope
so the module IR can be obtained. There are also tools for creating a fleshed-out IR
from the IR for a function.

Sep 30 2021, 6:55 AM · Restricted Project, Restricted Project

Sep 29 2021

jamieschmeiser requested review of D110776: A new hidden option exec-on-ir-change=exe that calls exe after each time IR changes.
Sep 29 2021, 2:15 PM · Restricted Project
jamieschmeiser updated the diff for D86657: Add new hidden option -print-on-crash that prints out IR that caused opt pipeline to crash.

As requested, I removed the mutex code and cleaned up a few things.

Sep 29 2021, 1:49 PM · Restricted Project, Restricted Project
jamieschmeiser added a comment to D86657: Add new hidden option -print-on-crash that prints out IR that caused opt pipeline to crash.

I agree that the mutex code is overkill, considering that this is intended for debugging. If things go off the rails because of the lacking mutex code, the consequences are not severe since it is expected to crash anyway (or else why would you use this?)
I will removed the mutex code and clean things up based on your comments unless someone raises an objection.

Sep 29 2021, 11:31 AM · Restricted Project, Restricted Project
jamieschmeiser added a comment to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Created new review https://reviews.llvm.org/D110737 with non-functional background changes to simplify this review. I will update this review to reflect any changes from that review when it lands.

Sep 29 2021, 10:37 AM · Restricted Project
jamieschmeiser requested review of D110737: Changes to print-changed classes in preparation for DotCfg change printer (https://reviews.llvm.org/D87202).
Sep 29 2021, 10:35 AM · Restricted Project

Sep 28 2021

jamieschmeiser updated the diff for D86657: Add new hidden option -print-on-crash that prints out IR that caused opt pipeline to crash.

fix Clang-tidy problems

Sep 28 2021, 12:42 PM · Restricted Project, Restricted Project
jamieschmeiser added a comment to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Thanks. Would it help if I split it up a bit? For example, there are a lot of changes relating to making data into templates which affects the existing change printers but doesn't change their functioning. These could be split out and handled first to simplify things. Would this help?

Sep 28 2021, 12:02 PM · Restricted Project
jamieschmeiser updated the diff for D86657: Add new hidden option -print-on-crash that prints out IR that caused opt pipeline to crash.

Update and change test pass to use assert(false)

Sep 28 2021, 10:03 AM · Restricted Project, Restricted Project
jamieschmeiser added a comment to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

I do not know what is causing the debian build to fail but I do not believe the failure is caused by my changes. I used the instructions to replicate the failure and this resulted in the same error that llgo isn't a known project. Checking out the previous commit resulted in the same error so it is a pre-existing condition and not the result of my changes.

Sep 28 2021, 7:43 AM · Restricted Project

Sep 20 2021

jamieschmeiser updated the diff for D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

make clang-tidy comments specific to readability-identifier-naming

Sep 20 2021, 11:37 AM · Restricted Project
jamieschmeiser updated the diff for D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Add // NOLINTNEXTLINE comments

Sep 20 2021, 7:08 AM · Restricted Project

Sep 16 2021

jamieschmeiser added a comment to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

The clang-tidy complaints relate to names that are required by existing code.

Sep 16 2021, 6:13 AM · Restricted Project

Sep 15 2021

jamieschmeiser updated the diff for D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Fix clang tidy problems and add option to specify dot executable.

Sep 15 2021, 4:34 PM · Restricted Project
jamieschmeiser updated the diff for D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Fix lit test failure: make test unsupported if /usr/bin/dot is unavailable.

Sep 15 2021, 2:23 PM · Restricted Project
jamieschmeiser updated the diff for D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Removed stale parent reviews because I think they were causing problems with applying the patch

Sep 15 2021, 12:54 PM · Restricted Project
jamieschmeiser updated the diff for D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Trying again with a newly generated patch...

Sep 15 2021, 12:28 PM · Restricted Project
jamieschmeiser updated the diff for D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Trying newly generated patch as last one couldn't be applied. I also added code to call expand_tilde on the -dot-cfg-dir specified directory and then make it absolute.

Sep 15 2021, 11:57 AM · Restricted Project

Sep 14 2021

jamieschmeiser updated the diff for D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

I have addressed your comments from previous reviews. Regarding the statics to avoid a crash,
I figured out that the problem was a template instantiation that was missing a const, resulting
in a copy being made, which didn't copy everything. This has been fixed. I have also
simplified the code and templates.

Sep 14 2021, 2:02 PM · Restricted Project

Aug 13 2021

jamieschmeiser committed rG64f29e2dd129: Fix bad assert in print-changed code (authored by jamieschmeiser).
Fix bad assert in print-changed code
Aug 13 2021, 7:55 AM
jamieschmeiser closed D107989: Fix bad assert in print-changed code.
Aug 13 2021, 7:54 AM · Restricted Project