Page MenuHomePhabricator

dongjunduo (dongjunduo)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 8 2022, 7:46 AM (22 w, 6 d)

Recent Activity

Thu, Aug 11

dongjunduo updated the diff for D131469: [Clang] change default storing path of `-ftime-trace`.

Add assert messages

Thu, Aug 11, 7:31 PM · Restricted Project, Restricted Project
dongjunduo updated the diff for D131469: [Clang] change default storing path of `-ftime-trace`.

Add necessary asserts

Thu, Aug 11, 7:13 PM · Restricted Project, Restricted Project
dongjunduo updated the diff for D131469: [Clang] change default storing path of `-ftime-trace`.

format cc1_main.cpp

Thu, Aug 11, 8:44 AM · Restricted Project, Restricted Project
dongjunduo added inline comments to D131469: [Clang] change default storing path of `-ftime-trace`.
Thu, Aug 11, 8:10 AM · Restricted Project, Restricted Project
dongjunduo updated the diff for D131469: [Clang] change default storing path of `-ftime-trace`.

Restyle codes

Thu, Aug 11, 8:07 AM · Restricted Project, Restricted Project
dongjunduo updated the diff for D131469: [Clang] change default storing path of `-ftime-trace`.

format code

Thu, Aug 11, 7:38 AM · Restricted Project, Restricted Project
dongjunduo added a comment to D131469: [Clang] change default storing path of `-ftime-trace`.

You should not have debugging information in code that is up for review. If this is debugging information that you plan to leave in for future purposes (which I doubt is the case here), you need to protect it so that it isn't active unless some option is set. For example, see LLVM_DEBUG code that lives in various opt routines.

Thu, Aug 11, 6:52 AM · Restricted Project, Restricted Project
dongjunduo updated the diff for D131469: [Clang] change default storing path of `-ftime-trace`.

fix stringRef bug

Thu, Aug 11, 6:48 AM · Restricted Project, Restricted Project
dongjunduo updated the diff for D131469: [Clang] change default storing path of `-ftime-trace`.

Add more debug info

Thu, Aug 11, 4:55 AM · Restricted Project, Restricted Project
dongjunduo updated the diff for D131469: [Clang] change default storing path of `-ftime-trace`.

Add more debug info

Thu, Aug 11, 3:40 AM · Restricted Project, Restricted Project
dongjunduo updated the diff for D131469: [Clang] change default storing path of `-ftime-trace`.

[Clang] add -### for debug

Thu, Aug 11, 2:48 AM · Restricted Project, Restricted Project

Tue, Aug 9

dongjunduo added reviewers for D131469: [Clang] change default storing path of `-ftime-trace`: jamieschmeiser, Whitney.
Tue, Aug 9, 12:50 AM · Restricted Project, Restricted Project
dongjunduo requested review of D131469: [Clang] change default storing path of `-ftime-trace`.
Tue, Aug 9, 12:49 AM · Restricted Project, Restricted Project

Jul 15 2022

dongjunduo committed rGf5d9de8cc330: [Clang] Add a new clang option "-ftime-trace=<value>" (authored by dongjunduo).
[Clang] Add a new clang option "-ftime-trace=<value>"
Jul 15 2022, 8:56 AM · Restricted Project, Restricted Project
dongjunduo closed D128048: Add a new clang option "-ftime-trace=<value>".
Jul 15 2022, 8:56 AM · Restricted Project, Restricted Project
dongjunduo updated the diff for D128048: Add a new clang option "-ftime-trace=<value>".

[Clang] fix mkdir error in ftime-trace=<value> test

Jul 15 2022, 5:19 AM · Restricted Project, Restricted Project
dongjunduo updated the diff for D128048: Add a new clang option "-ftime-trace=<value>".

[Clang] restyle code

Jul 15 2022, 12:28 AM · Restricted Project, Restricted Project

Jun 30 2022

dongjunduo updated the diff for D128048: Add a new clang option "-ftime-trace=<value>".

[Clang] format the source file

Jun 30 2022, 6:59 PM · Restricted Project, Restricted Project
dongjunduo retitled D128048: Add a new clang option "-ftime-trace=<value>" from Add a new clang option "-ftime-trace" to Add a new clang option "-ftime-trace=<value>".
Jun 30 2022, 6:53 PM · Restricted Project, Restricted Project
dongjunduo retitled D128048: Add a new clang option "-ftime-trace=<value>" from Add a new clang option "-ftime-trace-path" to Add a new clang option "-ftime-trace".
Jun 30 2022, 6:51 PM · Restricted Project, Restricted Project
dongjunduo added inline comments to D128048: Add a new clang option "-ftime-trace=<value>".
Jun 30 2022, 6:47 PM · Restricted Project, Restricted Project
dongjunduo updated the diff for D128048: Add a new clang option "-ftime-trace=<value>".

[Clang] change test cases to different directory

Jun 30 2022, 6:44 PM · Restricted Project, Restricted Project
dongjunduo added a comment to D128048: Add a new clang option "-ftime-trace=<value>".

Hi @jamieschmeiser @Whitney @MaskRay, I have changed "-ftime-trace-path" to "-ftime-trace". It is a well-spelling option name.

Jun 30 2022, 5:59 AM · Restricted Project, Restricted Project
dongjunduo updated the diff for D128048: Add a new clang option "-ftime-trace=<value>".

[Clang] change "-ftime-trace-path" to "-ftime-trace"

Jun 30 2022, 5:49 AM · Restricted Project, Restricted Project

Jun 28 2022

dongjunduo added inline comments to D128048: Add a new clang option "-ftime-trace=<value>".
Jun 28 2022, 6:42 AM · Restricted Project, Restricted Project

Jun 24 2022

dongjunduo updated the diff for D128048: Add a new clang option "-ftime-trace=<value>".

[Clang] rewrite test case of "-ftime-trace-path"

Jun 24 2022, 1:04 AM · Restricted Project, Restricted Project

Jun 23 2022

dongjunduo updated the summary of D128048: Add a new clang option "-ftime-trace=<value>".
Jun 23 2022, 7:30 AM · Restricted Project, Restricted Project
dongjunduo added a comment to D128048: Add a new clang option "-ftime-trace=<value>".

I have changed the approach from directory-store to path-store, so that the user can specify the aim path to store the time trace json file.
If "-ftime-trace-path" is not specified, it will follow the default behavior.

Jun 23 2022, 7:28 AM · Restricted Project, Restricted Project
dongjunduo updated the diff for D128048: Add a new clang option "-ftime-trace=<value>".

[Clang] change directory-store to path-store

Jun 23 2022, 7:22 AM · Restricted Project, Restricted Project

Jun 22 2022

dongjunduo added a comment to D128048: Add a new clang option "-ftime-trace=<value>".

Can you please use git rebase -i to collapse all the changes into a single change? If this isn't done, it is difficult to know what is being reviewed as the changes only show the differences since your last revision, not all of the changes.

Jun 22 2022, 6:46 AM · Restricted Project, Restricted Project

Jun 21 2022

dongjunduo updated the diff for D128048: Add a new clang option "-ftime-trace=<value>".

[Clang] update help text of "ftime-trace-path"

Jun 21 2022, 12:53 AM · Restricted Project, Restricted Project

Jun 20 2022

dongjunduo added a comment to D128048: Add a new clang option "-ftime-trace=<value>".

Can you please add some test cases?

Jun 20 2022, 2:17 AM · Restricted Project, Restricted Project
dongjunduo updated the diff for D128048: Add a new clang option "-ftime-trace=<value>".

[Clang] change unclear help text pf "-ftime-trace-path"

Jun 20 2022, 2:15 AM · Restricted Project, Restricted Project
dongjunduo updated the diff for D128048: Add a new clang option "-ftime-trace=<value>".

[Clang] Restore the old behaviors when "-ftime-trace-path" is not specified

Jun 20 2022, 1:33 AM · Restricted Project, Restricted Project

Jun 17 2022

dongjunduo added reviewers for D128048: Add a new clang option "-ftime-trace=<value>": Whitney, jamieschmeiser.
Jun 17 2022, 6:10 AM · Restricted Project, Restricted Project
dongjunduo requested review of D128048: Add a new clang option "-ftime-trace=<value>".
Jun 17 2022, 6:07 AM · Restricted Project, Restricted Project