Hey @dongjunduo,
Are you still interested in finishing this? If not I was thinking that I would pick it up, so I can work on the follow ups.

In D131469#3798409, @Maetveis wrote:

As discussed with @jamieschmeiser on D133662, I have left suggestions regarding the approach I took for handling -o and passing the option to the jobs.

I'm really happy to see this area getting attention, and I'm sorry for the confusion I must have caused.

@MaskRay ping

In D131469#3775741, @MaskRay wrote:

I appreciate the detailed summary. It has sufficient information but I think it can be rephased to be conciser.
I request changes for the verbosity and the possibly functionality issue.

We can use -ftime-trace or -ftime-trace=<path> to switch on the TimeProfiler.

"We can use" can be omitted => "-ftime-trace or -ftime-trace=<path> enables ..."

The source files should be compiled into object files (.o) by clang, and then linked into executable file by the linker.

This is basic knowledge and can be removed.

"-ftime-trace or -ftime-trace=<path> enables ..."

Where to store for now?

If we want a detailed description, the whole paragraph is really something which should go to https://clang.llvm.org/docs/UsersManual.html
Then, this patch summary (commit message) can just refer to it.

---

I'd delete everything and keep just

-ftime-trace and -ftime-trace=<path> enable the TimeProfiler.
When Clang does compile and link actions in one command and -ftime-trace is used, the JSON file currently goes to a temporary directory, e.g.

$ clang++ -ftime-trace -o main.out /demo/main.cpp
$ ls .
main.out
$ ls /tmp/
main-[random-string].json

The JSON file location is undesired. This patch changes the location based on the specified ...

---

What if an input file and the output is in directories, e.g.

% myclang -ftime-trace a/a.c -o b/a; ls *.json
a-a7cffa.json

Does the patch achieve what it intends to do?

fix related nits

Restyle codes and comments

fix windows path-check error

Add more comments

@dyung @steven_wu A newer diff has been submitted just now.

Rewrite test by checking output of -###

Remove the useless code

Restyle codes

Restyle the callback registration and related comment

These related commits have been reverted temporarily.

In D131469#3768288, @dyung wrote:

In D131469#3768283, @dongjunduo wrote:

In D131469#3768282, @dyung wrote:

In D131469#3768274, @dongjunduo wrote:

In D131469#3768260, @dyung wrote:

The test you added is failing on the PS4 linux bot because the PS4 platform requires an external linker that isn't present. Is linking necessary for your test? Or can -S or even -c work instead to accomplish what you are trying to test?

Yeah the new test case is designed to test the compiling jobs with a linking stage.

Are there any options or measures to avoid this test running on the PS4?

You could mark it as XFAIL: ps4

Your change also seems to have possibly the same issue when run on our PS5 Windows bot:
https://lab.llvm.org/buildbot/#/builders/216/builds/9260

$ ":" "RUN: at line 2"
$ "z:\test\build\bin\clang.exe" "--driver-mode=g++" "-ftime-trace" "-ftime-trace-granularity=0" "-o" "Z:\test\build\tools\clang\test\Driver\Output/exe/check-time-trace" "Z:\test\llvm-project\clang\test\Driver\check-time-trace.cpp"
# command stderr:
clang: error: unable to execute command: program not executable
clang: error: linker command failed with exit code 1 (use -v to see invocation)

How about "UNSUPPORTED: ps4, ps5"

That would likely work I think.

In D131469#3768282, @dyung wrote:

In D131469#3768274, @dongjunduo wrote:

In D131469#3768260, @dyung wrote:

The test you added is failing on the PS4 linux bot because the PS4 platform requires an external linker that isn't present. Is linking necessary for your test? Or can -S or even -c work instead to accomplish what you are trying to test?

Yeah the new test case is designed to test the compiling jobs with a linking stage.

Are there any options or measures to avoid this test running on the PS4?

You could mark it as XFAIL: ps4

Your change also seems to have possibly the same issue when run on our PS5 Windows bot:
https://lab.llvm.org/buildbot/#/builders/216/builds/9260

$ ":" "RUN: at line 2"
$ "z:\test\build\bin\clang.exe" "--driver-mode=g++" "-ftime-trace" "-ftime-trace-granularity=0" "-o" "Z:\test\build\tools\clang\test\Driver\Output/exe/check-time-trace" "Z:\test\llvm-project\clang\test\Driver\check-time-trace.cpp"
# command stderr:
clang: error: unable to execute command: program not executable
clang: error: linker command failed with exit code 1 (use -v to see invocation)

In D131469#3768260, @dyung wrote:

The test you added is failing on the PS4 linux bot because the PS4 platform requires an external linker that isn't present. Is linking necessary for your test? Or can -S or even -c work instead to accomplish what you are trying to test?

For now, the time-trace file's name is corresponding to the output file's name ([demo].o => [demo].json).

Adjust the location of TimeProfiler's start and end functions

Rewrite comments and commit log

Replace -ftime-trace with -ftime-trace=<infered_path> also

Restyle variables' name and comments

Move class PassTimeProfiling to StandardInstrumentation.cpp

Restyle code

Restyle code

Add assert messages

Add necessary asserts

format cc1_main.cpp

Restyle codes

format code

In D131469#3715929, @jamieschmeiser wrote:

You should not have debugging information in code that is up for review. If this is debugging information that you plan to leave in for future purposes (which I doubt is the case here), you need to protect it so that it isn't active unless some option is set. For example, see LLVM_DEBUG code that lives in various opt routines.

fix stringRef bug

Add more debug info

Add more debug info

[Clang] add -### for debug

[Clang] fix mkdir error in ftime-trace=<value> test

[Clang] restyle code

[Clang] format the source file

[Clang] change test cases to different directory

Hi @jamieschmeiser @Whitney @MaskRay, I have changed "-ftime-trace-path" to "-ftime-trace". It is a well-spelling option name.

[Clang] change "-ftime-trace-path" to "-ftime-trace"

[Clang] rewrite test case of "-ftime-trace-path"

I have changed the approach from directory-store to path-store, so that the user can specify the aim path to store the time trace json file.
If "-ftime-trace-path" is not specified, it will follow the default behavior.

[Clang] change directory-store to path-store

In D128048#3601579, @jamieschmeiser wrote:

Can you please use git rebase -i to collapse all the changes into a single change? If this isn't done, it is difficult to know what is being reviewed as the changes only show the differences since your last revision, not all of the changes.

[Clang] update help text of "ftime-trace-path"

In D128048#3591829, @Whitney wrote:

Can you please add some test cases?

[Clang] change unclear help text pf "-ftime-trace-path"

[Clang] Restore the old behaviors when "-ftime-trace-path" is not specified