This is an archive of the discontinued LLVM Phabricator instance.

Differential D133488

[clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than a slot
ClosedPublic

Authored by tingwang on Sep 8 2022, 6:49 AM.

Details

Reviewers
uweigand
wschmidt
nemanjai
rjmccall
shchenz
Group Reviewers
Restricted Project
Commits
rG00b9bed1f05a: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than…
Summary

Add base test case for https://reviews.llvm.org/D133338.

Diff Detail

Event Timeline

tingwang created this revision.Sep 8 2022, 6:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2022, 6:49 AM
Herald added subscribers: shchenz, kbarton, nemanjai. · View Herald Transcript
tingwang requested review of this revision.Sep 8 2022, 6:49 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptSep 8 2022, 6:49 AM
Harbormaster completed remote builds in B185608: Diff 458719.Sep 8 2022, 7:16 AM
tingwang added a child revision: D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register.Sep 8 2022, 7:09 PM
tingwang updated this revision to Diff 466708.Oct 10 2022, 11:34 PM
tingwang added a reviewer: nemanjai.

Rebase on opaque-pointers test case changes && Gentle ping.

Harbormaster completed remote builds in B191433: Diff 466708.Oct 11 2022, 12:16 AM
tingwang updated this revision to Diff 467040.Oct 12 2022, 1:08 AM
tingwang added a reviewer: rjmccall.

Add test case according to comment.

Harbormaster completed remote builds in B191670: Diff 467040.Oct 12 2022, 1:38 AM
shchenz accepted this revision.Oct 12 2022, 11:51 PM

LGTM

This revision is now accepted and ready to land.Oct 12 2022, 11:51 PM
Closed by commit rG00b9bed1f05a: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than… (authored by tingwang). · Explain WhyOct 13 2022, 7:58 PM
This revision was automatically updated to reflect the committed changes.
tingwang added a commit: rG00b9bed1f05a: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than….

Revision Contents

PathSize
clang/
test/
CodeGen/
PowerPC/
17 lines

Diff 466708

clang/test/CodeGen/PowerPC/ppc64-align-struct.c

// RUN: %clang_cc1 -target-feature +altivec -triple powerpc64-unknown-linux-gnu -emit-llvm -o - %s | FileCheck %s // RUN: %clang_cc1 -target-feature +altivec -triple powerpc64-unknown-linux-gnu -emit-llvm -o - %s | FileCheck %s
#include <stdarg.h> #include <stdarg.h>
struct test1 { int x; int y; }; struct test1 { int x; int y; };
struct test2 { int x; int y; } __attribute__((aligned (16))); struct test2 { int x; int y; } __attribute__((aligned (16)));
struct test3 { int x; int y; } __attribute__((aligned (32))); struct test3 { int x; int y; } __attribute__((aligned (32)));
struct test4 { int x; int y; int z; }; struct test4 { int x; int y; int z; };
struct test5 { int x[17]; }; struct test5 { int x[17]; };
struct test6 { int x[17]; } __attribute__((aligned (16))); struct test6 { int x[17]; } __attribute__((aligned (16)));
struct test7 { int x[17]; } __attribute__((aligned (32))); struct test7 { int x[17]; } __attribute__((aligned (32)));
struct test8 { char x; };
// CHECK: define{{.*}} void @test1(i32 noundef signext %x, i64 %y.coerce) // CHECK: define{{.*}} void @test1(i32 noundef signext %x, i64 %y.coerce)
void test1 (int x, struct test1 y) void test1 (int x, struct test1 y)
{ {
} }
// CHECK: define{{.*}} void @test2(i32 noundef signext %x, [1 x i128] %y.coerce) // CHECK: define{{.*}} void @test2(i32 noundef signext %x, [1 x i128] %y.coerce)
void test2 (int x, struct test2 y) void test2 (int x, struct test2 y)
▲ Show 20 Lines • Show All 91 Lines • ▼ Show 20 Linesstruct test4 test4va (int x, ...)
struct test4 y; struct test4 y;
va_list ap; va_list ap;
va_start(ap, x); va_start(ap, x);
y = va_arg (ap, struct test4); y = va_arg (ap, struct test4);
va_end(ap); va_end(ap);
return y; return y;
} }
// Error pattern will be fixed in https://reviews.llvm.org/D133338
// CHECK: define{{.*}} void @test8va(ptr noalias sret(%struct.test8) align 1 %[[AGG_RESULT:.*]], i32 noundef signext %x, ...)
// CHECK: %[[CUR:[^ ]+]] = load ptr, ptr %ap
// CHECK: %[[NEXT:[^ ]+]] = getelementptr inbounds i8, ptr %[[CUR]], i64 8
// CHECK: store ptr %[[NEXT]], ptr %ap
// CHECK: call void @llvm.memcpy.p0.p0.i64(ptr align 1 %[[AGG_RESULT]], ptr align 8 %[[CUR]], i64 1, i1 false)
struct test8 test8va (int x, ...)
{
struct test8 y;
va_list ap;
va_start(ap, x);
y = va_arg (ap, struct test8);
va_end(ap);
return y;
}
// CHECK: define{{.*}} void @testva_longdouble(ptr noalias sret(%struct.test_longdouble) align 16 %[[AGG_RESULT:.*]], i32 noundef signext %x, ...) // CHECK: define{{.*}} void @testva_longdouble(ptr noalias sret(%struct.test_longdouble) align 16 %[[AGG_RESULT:.*]], i32 noundef signext %x, ...)
// CHECK: %[[CUR:[^ ]+]] = load ptr, ptr %ap // CHECK: %[[CUR:[^ ]+]] = load ptr, ptr %ap
// CHECK: %[[NEXT:[^ ]+]] = getelementptr inbounds i8, ptr %[[CUR]], i64 16 // CHECK: %[[NEXT:[^ ]+]] = getelementptr inbounds i8, ptr %[[CUR]], i64 16
// CHECK: store ptr %[[NEXT]], ptr %ap // CHECK: store ptr %[[NEXT]], ptr %ap
// CHECK: call void @llvm.memcpy.p0.p0.i64(ptr align 16 %[[AGG_RESULT]], ptr align 8 %[[CUR]], i64 16, i1 false) // CHECK: call void @llvm.memcpy.p0.p0.i64(ptr align 16 %[[AGG_RESULT]], ptr align 8 %[[CUR]], i64 16, i1 false)
struct test_longdouble { long double x; }; struct test_longdouble { long double x; };
struct test_longdouble testva_longdouble (int x, ...) struct test_longdouble testva_longdouble (int x, ...)
{ {
Show All 28 Lines