Adding functionality to
— collect time information from the target devices
— sideloads the collected data TimeProfiler Entrys
Resulting in a Libomptarget Profile containing host + target information.
Paths
| Differential D133463
[OpenMP] Device Time Profile Needs ReviewPublic Authored by nrj5k on Sep 7 2022, 5:09 PM.
Details
Summary Adding functionality to
Diff Detail Event TimelineHerald added projects: Restricted Project, Restricted Project. · View Herald TranscriptSep 7 2022, 5:09 PM Comment Actions Can you 1) upload the patches with full context (see https://llvm.org/docs/Contributing.html#how-to-submit-a-patch) and 2) split it into the refactor of the timer facility and the OpenMP patch. jdoerfert retitled this revision from Device Time Profile to [OpenMP] Device Time Profile.Oct 25 2022, 10:07 PM nrj5k added a parent revision: D139587: [NFC] Expose Time Profile utilities for easier reuse.Dec 7 2022, 3:03 PM Comment Actions I left some initial comments, I think this is not in a "working" state, it looks like parts are missing, beyond the LLVM changes.
Comment Actions Can you please describe at a high level what data "Device Time Profile" is supposed to collect and how you are collecting it? Is there a specification somewhere for this functionality? Comment Actions
The profile collects time spend between user (or compiler) placed calls to start/stop a timer. The patch is not complete and I am not sure if Neeraj monitors these emails.
Revision Contents
Diff 481041 llvm/test/Transforms/OpenMP/spmdization_constant_prop.ll
openmp/libomptarget/DeviceRTL/include/Configuration.h
openmp/libomptarget/DeviceRTL/include/Interface.h
openmp/libomptarget/DeviceRTL/src/Configuration.cpp
openmp/libomptarget/DeviceRTL/src/Kernel.cpp
openmp/libomptarget/DeviceRTL/src/State.cpp
openmp/libomptarget/include/device.h
openmp/libomptarget/include/omptargetplugin.h
openmp/libomptarget/include/rtl.h
openmp/libomptarget/plugins/amdgpu/src/rtl.cpp
openmp/libomptarget/plugins/cuda/src/rtl.cpp
openmp/libomptarget/src/device.cpp
openmp/libomptarget/src/interface.cpp
openmp/libomptarget/src/rtl.cpp
|
Leftover