This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC][GFX11][NFC] Update disassembler tests for VOP3.DPP16 instructions
ClosedPublic

Authored by dp on Sep 6 2022, 7:25 AM.

Details

Summary
  • Split VOP3.DPP16 tests into smaller parts to make them more manageable. Separate v_cmp_* and v_cmpx_* from other tests.
  • Add missing tests for v_cvt_pknorm_u16_f32_e64_dpp and v_cvt_pknorm_i16_f32_e64_dpp.

Diff Detail

Event Timeline

dp created this revision.Sep 6 2022, 7:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2022, 7:25 AM
dp requested review of this revision.Sep 6 2022, 7:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2022, 7:25 AM
Joe_Nash accepted this revision.Sep 6 2022, 11:22 AM

I realized we don't have any asm or disasm coverage of v_fmac_.*_e64_dpp, and the asm at least is broken.
https://github.com/llvm/llvm-project/issues/57585

That said, this patch does not claim to be bringing VOP3DPP up to full coverage. So LGTM

This revision is now accepted and ready to land.Sep 6 2022, 11:22 AM
dp added a comment.Sep 7 2022, 6:29 AM

I realized we don't have any asm or disasm coverage of v_fmac_.*_e64_dpp, and the asm at least is broken.
https://github.com/llvm/llvm-project/issues/57585

That said, this patch does not claim to be bringing VOP3DPP up to full coverage. So LGTM

Sure, there are no tests for opcodes and features that have not passed testing. With these exceptions, I believe we now have good test coverage for GFX11 (3 final updates are in the review).

llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop3c_dpp16.txt