This is an archive of the discontinued LLVM Phabricator instance.

Differential D133350

[AMDGPU][MC][GFX11][NFC] Update disassembler tests for VOP3 instructions
ClosedPublic

Authored by dp on Sep 6 2022, 6:10 AM.

Details

Reviewers
Joe_Nash
foad
Commits
rGefa65ef28196: [AMDGPU][MC][GFX11][NFC] Update disassembler tests for VOP3 instructions
Summary
  • Split VOP3 tests into smaller parts to make them more manageable. Separate v_cmp_* and v_cmpx_* tests.
  • Add missing tests (130 opcodes currently have zero test coverage).
  • Update existing tests to improve coverage.

Diff Detail

Event Timeline

dp created this revision.Sep 6 2022, 6:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2022, 6:10 AM
Herald added subscribers: kosarev, kerbowa, t-tye and 5 others. · View Herald Transcript
dp requested review of this revision.Sep 6 2022, 6:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2022, 6:10 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
Harbormaster completed remote builds in B185209: Diff 458152.Sep 6 2022, 7:03 AM
Joe_Nash accepted this revision.Sep 6 2022, 7:13 AM

LGTM

This revision is now accepted and ready to land.Sep 6 2022, 7:13 AM
Closed by commit rGefa65ef28196: [AMDGPU][MC][GFX11][NFC] Update disassembler tests for VOP3 instructions (authored by dp). · Explain WhySep 7 2022, 4:00 AM
This revision was automatically updated to reflect the committed changes.
dp added a commit: rGefa65ef28196: [AMDGPU][MC][GFX11][NFC] Update disassembler tests for VOP3 instructions.

Revision Contents

PathSize
llvm/
test/
MC/
Disassembler/
AMDGPU/
27867 lines
5223 lines
3989 lines

Diff 458152

llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop3.txt

This file has a very large number of changes (27,867 lines). Show File Contents

llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop3c.txt

  • This file was added.
This file has a very large number of changes (5,223 lines). Show File Contents

llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop3cx.txt

  • This file was added.
This file has a very large number of changes (3,989 lines). Show File Contents