This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC][GFX11][NFC] Update disassembler tests for VOP1 and VOP1.DPP instructions
ClosedPublic

Authored by dp on Aug 26 2022, 4:43 AM.

Details

Summary

Update existing tests and add missing tests.

Diff Detail

Event Timeline

dp created this revision.Aug 26 2022, 4:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2022, 4:43 AM
dp requested review of this revision.Aug 26 2022, 4:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2022, 4:43 AM
Joe_Nash accepted this revision.Aug 26 2022, 10:43 AM

For these test and the other test updates, has the both the output and input been generated external to LLVM? Basically can we consider the output cross-checked against anything outside LLVM, or is the output simply what LLVM generates from the input.
Regardless, LGTM

This revision is now accepted and ready to land.Aug 26 2022, 10:43 AM
dp added a comment.Aug 26 2022, 11:04 AM

For these test and the other test updates, has the both the output and input been generated external to LLVM? Basically can we consider the output cross-checked against anything outside LLVM, or is the output simply what LLVM generates from the input.

Both the input and output are external to LLVM with one exception. When generating WS-dependent tests (e.g. for v_add_co_ci) I can only produce tests for one WS value. I have a script that merges WS32 and WS64 tests, but it currently works with asm tests only. For disassembler, I do use LLVM output for such instructions as a workaround.