This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC][GFX11][NFC] Add missing asm tests for VOPCX and VOPCX.DPP instructions
ClosedPublic

Authored by dp on Aug 25 2022, 11:46 AM.

Details

Summary

gfx11_asm_vopcx.s provide sufficient coverage, but it is updated to make tests sorted by opcode and to simplify future updates.

Diff Detail

Event Timeline

dp created this revision.Aug 25 2022, 11:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2022, 11:46 AM
dp requested review of this revision.Aug 25 2022, 11:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2022, 11:46 AM
This revision is now accepted and ready to land.Aug 25 2022, 12:27 PM

I realized this removes all coverage of vopcx dpp with a forced _dpp suffix. Same comment as on the VOPC change https://reviews.llvm.org/D132690. I think we should have a few tests with the suffix for this encoding as well.

dp added a comment.Aug 25 2022, 1:12 PM

Thanks for catching the issue. I’ll add separate tests for forced suffix.

Please note that the _dpp suffix is only meaningful when there are no modifiers that require dpp encoding. I believe all tests in this file have _dpp8[…] so adding a _dpp suffix does not enforce anything. This was the reason I removed the suffix. We need special tests for this case like the following:

v_cmpx_u_f32_dpp    v1, v2
dp updated this revision to Diff 455848.Aug 26 2022, 3:28 AM

Add tests with forced _e32 and _dpp suffices.