gfx11_asm_vopcx.s provide sufficient coverage, but it is updated to make tests sorted by opcode and to simplify future updates.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I realized this removes all coverage of vopcx dpp with a forced _dpp suffix. Same comment as on the VOPC change https://reviews.llvm.org/D132690. I think we should have a few tests with the suffix for this encoding as well.
Comment Actions
Thanks for catching the issue. I’ll add separate tests for forced suffix.
Please note that the _dpp suffix is only meaningful when there are no modifiers that require dpp encoding. I believe all tests in this file have _dpp8[…] so adding a _dpp suffix does not enforce anything. This was the reason I removed the suffix. We need special tests for this case like the following:
v_cmpx_u_f32_dpp v1, v2