This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC][GFX11][NFC] Add missing asm tests for VOPC and VOPC.DPP instructions
ClosedPublic

Authored by dp on Aug 25 2022, 11:23 AM.

Diff Detail

Event Timeline

dp created this revision.Aug 25 2022, 11:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2022, 11:23 AM
dp requested review of this revision.Aug 25 2022, 11:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2022, 11:23 AM

I do notice you have eliminated the forced _dpp suffix, and I believe this test has the only coverage of that with VOPC. For vop1 and vop2 we have coverage with the forced suffix on older subtargets. I think we should have a few tests with the forced suffix for each encoding.

dp updated this revision to Diff 455850.Aug 26 2022, 3:35 AM

Add tests with forced _e32 and _dpp suffices.

dp added a comment.Aug 29 2022, 11:10 AM

Anything wrong with this change?

Joe_Nash accepted this revision.Aug 29 2022, 11:34 AM
This revision is now accepted and ready to land.Aug 29 2022, 11:34 AM