This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC][GFX11][NFC] Update tests for FLAT instructions
ClosedPublic

Authored by dp on Aug 24 2022, 6:41 AM.

Details

Summary

Update assembler tests for FLAT instructions because most opcodes have 2 tests or fewer; remove redundant gfx11_asm_flat_mnemonic.s.
Disassembler tests for FLAT instructions have already been updated.

Diff Detail

Event Timeline

dp created this revision.Aug 24 2022, 6:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2022, 6:41 AM
dp requested review of this revision.Aug 24 2022, 6:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2022, 6:41 AM
foad accepted this revision.Aug 24 2022, 6:46 AM

LGTM, thanks. Are we consistently using "flat" in the filename even though it also tests global and scratch instructions?

zero to none

:)

This revision is now accepted and ready to land.Aug 24 2022, 6:46 AM
dp edited the summary of this revision. (Show Details)Aug 24 2022, 6:49 AM
dp added a comment.Aug 24 2022, 7:00 AM

Are we consistently using "flat" in the filename even though it also tests global and scratch instructions?

I believe we are, though GFX10 have separate tests for these. I was not sure if splitting FLAT tests into three separate encodings would be useful.

dp updated this revision to Diff 455196.Aug 24 2022, 7:15 AM
dp edited the summary of this revision. (Show Details)

Remove now redundant gfx11_asm_flat_mnemonic.s. I somehow missed this change in the first diff.

This revision was landed with ongoing or failed builds.Aug 25 2022, 2:51 AM
This revision was automatically updated to reflect the committed changes.