Page MenuHomePhabricator

[mlir] Use std::is_invocable instead of llvm::is_invocable
ClosedPublic

Authored by jloser on Aug 20 2022, 4:33 PM.

Details

Summary

Now that MLIR is built with C++17, use the standard library equivalent of
llvm::is_invocable: std::is_invocable.

Diff Detail

Event Timeline

jloser created this revision.Aug 20 2022, 4:33 PM
jloser requested review of this revision.Aug 20 2022, 4:33 PM
jloser updated this revision to Diff 454259.Aug 20 2022, 4:34 PM

clang-format

Should the latter be removed from ADT?

Mogball accepted this revision.Aug 20 2022, 4:38 PM

Thanks!

mlir/include/mlir/Transforms/DialectConversion.h
763

This reminds me that we can use the _v versions of many of the STL templates too now.

This revision is now accepted and ready to land.Aug 20 2022, 4:38 PM

Should the latter be removed from ADT?

The only callers outside of mlir are just the ADT unit tests for the trait - so I'll mark it as deprecated or remove it outright from ADT as a follow-up patch if that works with you.

mlir/include/mlir/Transforms/DialectConversion.h
763

Yep, might as well make the switch if I'm already touching this neighborhood of code. :)

This revision was automatically updated to reflect the committed changes.