This is an archive of the discontinued LLVM Phabricator instance.

Differential D131682

[libcxx] [test] Fix max_size.pass.cpp for PowerPC targets
ClosedPublic

Authored by amyk on Aug 11 2022, 7:35 AM.

Details

Reviewers
hubert.reinterpretcast
ldionne
Mordante
philnik
Group Reviewers
Restricted Project
Restricted Project
Commits
rGe2e9e2ce8efd: [libcxx] [test] Fix max_size.pass.cpp for PowerPC targets
Summary

This patch fixes the max_size.pass.cpp test for PowerPC targets, depending on endianness.

We will exhibit the full_size() behaviour for little endian (where __endian_factor = 2 ),
and the half_size() behaviour for big endian (where __endian_factor = 1).

Diff Detail

Event Timeline

amyk created this revision.Aug 11 2022, 7:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2022, 7:35 AM
Herald added subscribers: steven.zhang, shchenz, fedor.sergeev, nemanjai. · View Herald Transcript
amyk requested review of this revision.Aug 11 2022, 7:35 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptAug 11 2022, 7:35 AM
Herald added a subscriber: libcxx-commits. · View Herald Transcript
hubert.reinterpretcast accepted this revision.Aug 11 2022, 9:22 AM

Looks good from the Power side. Can a libc++ approver take a look?

Harbormaster completed remote builds in B180675: Diff 451730.Aug 11 2022, 11:31 AM
philnik accepted this revision.Aug 11 2022, 12:08 PM
This revision is now accepted and ready to land.Aug 11 2022, 12:08 PM
Closed by commit rGe2e9e2ce8efd: [libcxx] [test] Fix max_size.pass.cpp for PowerPC targets (authored by amyk). · Explain WhyAug 11 2022, 7:39 PM
This revision was automatically updated to reflect the committed changes.
amyk added a commit: rGe2e9e2ce8efd: [libcxx] [test] Fix max_size.pass.cpp for PowerPC targets.

Revision Contents

PathSize
libcxx/
test/
libcxx/
strings/
basic.string/
string.capacity/
8 lines

Diff 452060

libcxx/test/libcxx/strings/basic.string/string.capacity/max_size.pass.cpp

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines
# elif defined(__APPLE__) && defined(__aarch64__) # elif defined(__APPLE__) && defined(__aarch64__)
half_size(); half_size();
# elif defined(__arm__) || defined(__aarch64__) # elif defined(__arm__) || defined(__aarch64__)
# ifdef __BIG_ENDIAN__ # ifdef __BIG_ENDIAN__
half_size(); half_size();
# else # else
full_size(); full_size();
# endif # endif
# elif defined(__powerpc__) || defined(__powerpc64__) || defined(__sparc64__) # elif defined(__powerpc__) || defined(__powerpc64__)
# ifdef __BIG_ENDIAN__
half_size();
# else
full_size();
# endif
# elif defined(__sparc64__)
half_size(); half_size();
# elif defined(_WIN32) # elif defined(_WIN32)
full_size(); full_size();
# else # else
# error "Your target system seems to be unsupported." # error "Your target system seems to be unsupported."
# endif # endif
#else #else
Show All 16 Lines