This is an archive of the discontinued LLVM Phabricator instance.

[Support] Remove Log2 workaround for Android API level < 18
ClosedPublic

Authored by MaskRay on Aug 11 2022, 12:34 AM.

Details

Summary

The function added by D9467 is unneeded.
https://github.com/android/ndk/wiki/Changelog-r24 shows that the NDK has
moved forward to at least a minimum target API of 19.

Diff Detail

Event Timeline

MaskRay created this revision.Aug 11 2022, 12:34 AM
MaskRay requested review of this revision.Aug 11 2022, 12:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2022, 12:34 AM
srhines accepted this revision.Aug 11 2022, 12:49 AM
srhines added a reviewer: danalbert.

+Dan as FYI, but https://github.com/android/ndk/wiki/Changelog-r24 shows that the NDK has moved forward to at least a minimum target API of 19, so this code is indeed obsolete. We might want to go and update Clang to also forbid setting a target API less than 19 too.

This revision is now accepted and ready to land.Aug 11 2022, 12:50 AM
MaskRay edited the summary of this revision. (Show Details)Aug 11 2022, 10:32 AM
This revision was landed with ongoing or failed builds.Aug 11 2022, 10:39 AM
This revision was automatically updated to reflect the committed changes.