This is an archive of the discontinued LLVM Phabricator instance.

Differential D131580

[clang][SVE] Undefine preprocessor macro defined in
ClosedPublic

Authored by mgabka on Aug 10 2022, 8:42 AM.

Details

Reviewers
paulwalker-arm
efriedma
huntergr
Commits
rG48e1250a91d2: [clang][SVE] Undefine preprocessor macro defined in
Summary

arm_sve.h defines and uses __ai macro which needs to be undefined (as it is
already in arm_neon.h).

Diff Detail

Event Timeline

mgabka created this revision.Aug 10 2022, 8:42 AM
Herald added a reviewer: efriedma. · View Herald TranscriptAug 10 2022, 8:42 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. · View Herald Transcript
mgabka requested review of this revision.Aug 10 2022, 8:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 8:42 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
mgabka added a reviewer: huntergr.Aug 10 2022, 8:44 AM
paulwalker-arm added inline comments.Aug 10 2022, 9:13 AM
clang/utils/TableGen/SveEmitter.cpp
1285

Can you also do this for __aio?

mgabka updated this revision to Diff 451791.Aug 11 2022, 3:00 AM
mgabka marked an inline comment as done.
mgabka added inline comments.
clang/utils/TableGen/SveEmitter.cpp
1285

sure, I didn't notice that one.

paulwalker-arm accepted this revision.Aug 11 2022, 3:10 AM
This revision is now accepted and ready to land.Aug 11 2022, 3:10 AM
Harbormaster completed remote builds in B180630: Diff 451791.Aug 11 2022, 4:23 AM
mgabka marked an inline comment as done.Aug 11 2022, 5:50 AM

It is a fix for https://github.com/llvm/llvm-project/issues/57083

Closed by commit rG48e1250a91d2: [clang][SVE] Undefine preprocessor macro defined in (authored by mgabka, committed by paulwalker-arm). · Explain WhyAug 12 2022, 5:27 AM
This revision was automatically updated to reflect the committed changes.
paulwalker-arm added a commit: rG48e1250a91d2: [clang][SVE] Undefine preprocessor macro defined in.

Revision Contents

PathSize
clang/
utils/
TableGen/
2 lines

Diff 452149

clang/utils/TableGen/SveEmitter.cpp

Show First 20 Lines • Show All 1,276 Lines • ▼ Show 20 Linesvoid SVEEmitter::createHeader(raw_ostream &OS) {
OS << "#define svcvtxnt_f32_x svcvtxnt_f32_m\n"; OS << "#define svcvtxnt_f32_x svcvtxnt_f32_m\n";
OS << "#define svcvtxnt_f32_f64_x svcvtxnt_f32_f64_m\n\n"; OS << "#define svcvtxnt_f32_f64_x svcvtxnt_f32_f64_m\n\n";
OS << "#endif /*__ARM_FEATURE_SVE2 */\n\n"; OS << "#endif /*__ARM_FEATURE_SVE2 */\n\n";
OS << "#ifdef __cplusplus\n"; OS << "#ifdef __cplusplus\n";
OS << "} // extern \"C\"\n"; OS << "} // extern \"C\"\n";
OS << "#endif\n\n"; OS << "#endif\n\n";
OS << "#undef __ai\n\n";
paulwalker-armUnsubmitted
Done
ReplyInline Actions

Can you also do this for __aio?

paulwalker-arm: Can you also do this for `__aio`?
mgabkaAuthorUnsubmitted
Done
ReplyInline Actions

sure, I didn't notice that one.

mgabka: sure, I didn't notice that one.
OS << "#undef __aio\n\n";
OS << "#endif /*__ARM_FEATURE_SVE */\n\n"; OS << "#endif /*__ARM_FEATURE_SVE */\n\n";
OS << "#endif /* __ARM_SVE_H */\n"; OS << "#endif /* __ARM_SVE_H */\n";
} }
void SVEEmitter::createBuiltins(raw_ostream &OS) { void SVEEmitter::createBuiltins(raw_ostream &OS) {
std::vector<Record *> RV = Records.getAllDerivedDefinitions("Inst"); std::vector<Record *> RV = Records.getAllDerivedDefinitions("Inst");
SmallVector<std::unique_ptr<Intrinsic>, 128> Defs; SmallVector<std::unique_ptr<Intrinsic>, 128> Defs;
for (auto *R : RV) for (auto *R : RV)
▲ Show 20 Lines • Show All 145 Lines • Show Last 20 Lines