This is an archive of the discontinued LLVM Phabricator instance.

Differential D131564

[AMDGPU][MC][GFX11][NFC] Correct tests for 16-bit VOP2 opcodes which use v128 or higher VGPRs
ClosedPublic

Authored by dp on Aug 10 2022, 6:37 AM.

Details

Reviewers
Joe_Nash
foad
Commits
rGeda6e49aa88d: [AMDGPU][MC][GFX11][NFC] Correct tests for 16-bit VOP2 opcodes which use v128…
Summary

It looks like other VOP1/VOP2/VOPC asm tests are fine and need no corrections.

Diff Detail

Event Timeline

dp created this revision.Aug 10 2022, 6:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 6:37 AM
Herald added subscribers: kosarev, kerbowa, t-tye and 5 others. · View Herald Transcript
dp requested review of this revision.Aug 10 2022, 6:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 6:37 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
dp edited the summary of this revision. (Show Details)Aug 10 2022, 6:39 AM
Harbormaster completed remote builds in B180373: Diff 451437.Aug 10 2022, 7:26 AM
Joe_Nash accepted this revision.Aug 10 2022, 7:51 AM

LGTM

This revision is now accepted and ready to land.Aug 10 2022, 7:51 AM
This revision was landed with ongoing or failed builds.Aug 11 2022, 5:56 AM
Closed by commit rGeda6e49aa88d: [AMDGPU][MC][GFX11][NFC] Correct tests for 16-bit VOP2 opcodes which use v128… (authored by dp). · Explain Why
This revision was automatically updated to reflect the committed changes.
dp added a commit: rGeda6e49aa88d: [AMDGPU][MC][GFX11][NFC] Correct tests for 16-bit VOP2 opcodes which use v128….

Revision Contents

PathSize
llvm/
test/
MC/
AMDGPU/
24 lines

Diff 451437

llvm/test/MC/AMDGPU/gfx11_asm_vop2.s

Show All 31 Lines
// GFX11: encoding: [0x01,0xff,0x0b,0x5a,0x41,0x31,0x21,0x11] // GFX11: encoding: [0x01,0xff,0x0b,0x5a,0x41,0x31,0x21,0x11]
v_fmaak_f32 v5, v1, v2, 0xa1b1c1d1 v_fmaak_f32 v5, v1, v2, 0xa1b1c1d1
// GFX11: encoding: [0x01,0x05,0x0a,0x5a,0xd1,0xc1,0xb1,0xa1] // GFX11: encoding: [0x01,0x05,0x0a,0x5a,0xd1,0xc1,0xb1,0xa1]
v_fmaak_f16 v5, v1, v2, 0x1121 v_fmaak_f16 v5, v1, v2, 0x1121
// GFX11: encoding: [0x01,0x05,0x0a,0x70,0x21,0x11,0x00,0x00] // GFX11: encoding: [0x01,0x05,0x0a,0x70,0x21,0x11,0x00,0x00]
v_fmaak_f16 v255, v1, v2, 0x1121 v_fmaak_f16 v127, v1, v2, 0x1121
// GFX11: encoding: [0x01,0x05,0xfe,0x71,0x21,0x11,0x00,0x00] // GFX11: encoding: [0x01,0x05,0xfe,0x70,0x21,0x11,0x00,0x00]
v_fmaak_f16 v5, v255, v2, 0x1121 v_fmaak_f16 v5, v127, v2, 0x1121
// GFX11: encoding: [0xff,0x05,0x0a,0x70,0x21,0x11,0x00,0x00] // GFX11: encoding: [0x7f,0x05,0x0a,0x70,0x21,0x11,0x00,0x00]
v_fmaak_f16 v5, 0, v2, 0x1121 v_fmaak_f16 v5, 0, v2, 0x1121
// GFX11: encoding: [0x80,0x04,0x0a,0x70,0x21,0x11,0x00,0x00] // GFX11: encoding: [0x80,0x04,0x0a,0x70,0x21,0x11,0x00,0x00]
v_fmaak_f16 v5, -1, v2, 0x1121 v_fmaak_f16 v5, -1, v2, 0x1121
// GFX11: encoding: [0xc1,0x04,0x0a,0x70,0x21,0x11,0x00,0x00] // GFX11: encoding: [0xc1,0x04,0x0a,0x70,0x21,0x11,0x00,0x00]
v_fmaak_f16 v5, 0.5, v2, 0x1121 v_fmaak_f16 v5, 0.5, v2, 0x1121
// GFX11: encoding: [0xf0,0x04,0x0a,0x70,0x21,0x11,0x00,0x00] // GFX11: encoding: [0xf0,0x04,0x0a,0x70,0x21,0x11,0x00,0x00]
v_fmaak_f16 v5, -4.0, v2, 0x1121 v_fmaak_f16 v5, -4.0, v2, 0x1121
// GFX11: encoding: [0xf7,0x04,0x0a,0x70,0x21,0x11,0x00,0x00] // GFX11: encoding: [0xf7,0x04,0x0a,0x70,0x21,0x11,0x00,0x00]
v_fmaak_f16 v5, v1, v255, 0x1121 v_fmaak_f16 v5, v1, v127, 0x1121
// GFX11: encoding: [0x01,0xff,0x0b,0x70,0x21,0x11,0x00,0x00] // GFX11: encoding: [0x01,0xff,0x0a,0x70,0x21,0x11,0x00,0x00]
v_fmaak_f16 v5, v1, v2, 0xa1b1 v_fmaak_f16 v5, v1, v2, 0xa1b1
// GFX11: encoding: [0x01,0x05,0x0a,0x70,0xb1,0xa1,0x00,0x00] // GFX11: encoding: [0x01,0x05,0x0a,0x70,0xb1,0xa1,0x00,0x00]
v_fmac_dx9_zero_f32 v0, v1, v2 v_fmac_dx9_zero_f32 v0, v1, v2
// GFX11: encoding: [0x01,0x05,0x00,0x0c] // GFX11: encoding: [0x01,0x05,0x00,0x0c]
v_fmac_f16 v5, 0x1234, v2 v_fmac_f16 v5, 0x1234, v2
Show All 30 Lines
// GFX11: encoding: [0x01,0x07,0x0a,0x58,0xd1,0xc1,0xb1,0xa1] // GFX11: encoding: [0x01,0x07,0x0a,0x58,0xd1,0xc1,0xb1,0xa1]
v_fmamk_f32 v5, v1, 0x11213141, v255 v_fmamk_f32 v5, v1, 0x11213141, v255
// GFX11: encoding: [0x01,0xff,0x0b,0x58,0x41,0x31,0x21,0x11] // GFX11: encoding: [0x01,0xff,0x0b,0x58,0x41,0x31,0x21,0x11]
v_fmamk_f16 v5, v1, 0x1121, v3 v_fmamk_f16 v5, v1, 0x1121, v3
// GFX11: encoding: [0x01,0x07,0x0a,0x6e,0x21,0x11,0x00,0x00] // GFX11: encoding: [0x01,0x07,0x0a,0x6e,0x21,0x11,0x00,0x00]
v_fmamk_f16 v255, v1, 0x1121, v3 v_fmamk_f16 v127, v1, 0x1121, v3
// GFX11: encoding: [0x01,0x07,0xfe,0x6f,0x21,0x11,0x00,0x00] // GFX11: encoding: [0x01,0x07,0xfe,0x6e,0x21,0x11,0x00,0x00]
v_fmamk_f16 v5, v255, 0x1121, v3 v_fmamk_f16 v5, v127, 0x1121, v3
// GFX11: encoding: [0xff,0x07,0x0a,0x6e,0x21,0x11,0x00,0x00] // GFX11: encoding: [0x7f,0x07,0x0a,0x6e,0x21,0x11,0x00,0x00]
v_fmamk_f16 v5, 0, 0x1121, v3 v_fmamk_f16 v5, 0, 0x1121, v3
// GFX11: encoding: [0x80,0x06,0x0a,0x6e,0x21,0x11,0x00,0x00] // GFX11: encoding: [0x80,0x06,0x0a,0x6e,0x21,0x11,0x00,0x00]
v_fmamk_f16 v5, -1, 0x1121, v3 v_fmamk_f16 v5, -1, 0x1121, v3
// GFX11: encoding: [0xc1,0x06,0x0a,0x6e,0x21,0x11,0x00,0x00] // GFX11: encoding: [0xc1,0x06,0x0a,0x6e,0x21,0x11,0x00,0x00]
v_fmamk_f16 v5, 0.5, 0x1121, v3 v_fmamk_f16 v5, 0.5, 0x1121, v3
// GFX11: encoding: [0xf0,0x06,0x0a,0x6e,0x21,0x11,0x00,0x00] // GFX11: encoding: [0xf0,0x06,0x0a,0x6e,0x21,0x11,0x00,0x00]
v_fmamk_f16 v5, -4.0, 0x1121, v3 v_fmamk_f16 v5, -4.0, 0x1121, v3
// GFX11: encoding: [0xf7,0x06,0x0a,0x6e,0x21,0x11,0x00,0x00] // GFX11: encoding: [0xf7,0x06,0x0a,0x6e,0x21,0x11,0x00,0x00]
v_fmamk_f16 v5, v1, 0xa1b1, v3 v_fmamk_f16 v5, v1, 0xa1b1, v3
// GFX11: encoding: [0x01,0x07,0x0a,0x6e,0xb1,0xa1,0x00,0x00] // GFX11: encoding: [0x01,0x07,0x0a,0x6e,0xb1,0xa1,0x00,0x00]
v_fmamk_f16 v5, v1, 0x1121, v255 v_fmamk_f16 v5, v1, 0x1121, v127
// GFX11: encoding: [0x01,0xff,0x0b,0x6e,0x21,0x11,0x00,0x00] // GFX11: encoding: [0x01,0xff,0x0a,0x6e,0x21,0x11,0x00,0x00]
v_pk_fmac_f16 v5, v1, v2 v_pk_fmac_f16 v5, v1, v2
// GFX11: encoding: [0x01,0x05,0x0a,0x78] // GFX11: encoding: [0x01,0x05,0x0a,0x78]
v_pk_fmac_f16 v255, v1, v2 v_pk_fmac_f16 v255, v1, v2
// GFX11: encoding: [0x01,0x05,0xfe,0x79] // GFX11: encoding: [0x01,0x05,0xfe,0x79]
v_pk_fmac_f16 v5, v255, v2 v_pk_fmac_f16 v5, v255, v2
Show All 40 Lines