Page MenuHomePhabricator

[Orc] Reorder operations in ExecutorSharedMemoryMapperService shutdown
ClosedPublic

Authored by argentite on Aug 9 2022, 10:27 AM.

Diff Detail

Unit TestsFailed

TimeTest
60,140 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
Script: -- : 'RUN: at line 4'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m64 -O0 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/asan/TestCases/scariness_score_test.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/asan/X86_64LinuxConfig/TestCases/Output/scariness_score_test.cpp.tmp

Event Timeline

argentite created this revision.Aug 9 2022, 10:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2022, 10:27 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
argentite published this revision for review.Aug 9 2022, 10:37 AM
argentite added reviewers: RKSimon, lhames, sgraenitz.

This should fix https://reviews.llvm.org/D128544#3710127 but I think we may not even need the lock at all since this is called only at shutdown.

Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2022, 10:37 AM
lhames accepted this revision.Aug 10 2022, 10:29 PM

LGTM. Thanks Argentite!

This revision is now accepted and ready to land.Aug 10 2022, 10:29 PM
This revision was landed with ongoing or failed builds.Aug 11 2022, 7:05 AM
This revision was automatically updated to reflect the committed changes.