Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D131510

[Orc] Reorder operations in ExecutorSharedMemoryMapperService shutdown
ClosedPublic
Actions

Authored by argentite on Aug 9 2022, 10:27 AM.

Details

Reviewers
RKSimon
lhames
sgraenitz
Commits
rG0aaa74f7e6e5: [Orc] Reorder operations in ExecutorSharedMemoryMapperService shutdown

Diff Detail

Unit TestsFailed
View All

TimeTest
60,140 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp

Event Timeline

argentite created this revision.Aug 9 2022, 10:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2022, 10:27 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
argentite published this revision for review.Aug 9 2022, 10:37 AM
argentite added reviewers: RKSimon, lhames, sgraenitz.

This should fix https://reviews.llvm.org/D128544#3710127 but I think we may not even need the lock at all since this is called only at shutdown.

Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2022, 10:37 AM
Herald added subscribers: llvm-commits, StephenFan. · View Herald Transcript
argentite mentioned this in D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper.Aug 9 2022, 10:37 AM
Harbormaster completed remote builds in B180208: Diff 451200.Aug 9 2022, 2:02 PM
lhames accepted this revision.Aug 10 2022, 10:29 PM

LGTM. Thanks Argentite!

This revision is now accepted and ready to land.Aug 10 2022, 10:29 PM
This revision was landed with ongoing or failed builds.Aug 11 2022, 7:05 AM
Closed by commit rG0aaa74f7e6e5: [Orc] Reorder operations in ExecutorSharedMemoryMapperService shutdown (authored by argentite). · Explain Why
This revision was automatically updated to reflect the committed changes.
argentite added a commit: rG0aaa74f7e6e5: [Orc] Reorder operations in ExecutorSharedMemoryMapperService shutdown.

Revision Contents
Changeset List

PathSize
llvm/
lib/
ExecutionEngine/
Orc/
TargetProcess/
19 lines

Diff 451200

View Options

llvm/lib/ExecutionEngine/Orc/TargetProcess/ExecutorSharedMemoryMapperService.cpp

Loading...