Page MenuHomePhabricator

argentite (Anubhab Ghosh)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 16 2022, 9:36 AM (59 w, 10 h)

Recent Activity

Thu, Jun 1

argentite added inline comments to D151904: [clang-repl][CUDA] Add an unit test for interactive CUDA.
Thu, Jun 1, 10:36 AM · Restricted Project, Restricted Project
argentite requested review of D151904: [clang-repl][CUDA] Add an unit test for interactive CUDA.
Thu, Jun 1, 10:21 AM · Restricted Project, Restricted Project

Sat, May 27

argentite committed rGddeab07ca632: [clang-repl][CUDA] Re-land: Initial interactive CUDA support for clang-repl (authored by argentite).
[clang-repl][CUDA] Re-land: Initial interactive CUDA support for clang-repl
Sat, May 27, 1:26 AM · Restricted Project, Restricted Project
argentite closed D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.
Sat, May 27, 1:26 AM · Restricted Project, Restricted Project

Thu, May 25

argentite updated the diff for D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.

Workaround for depending on NVPTX symbols: initialize all available targets instead. If NVPTX is not available, it will complain when we try to actually execute anything in CUDA mode.
Rebased and fixed conflicts on recent value printing related patches.

Thu, May 25, 6:16 AM · Restricted Project, Restricted Project

Sat, May 20

argentite updated the diff for D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.

Added some std::move fixes for Error -> Expected conversions

Sat, May 20, 2:41 AM · Restricted Project, Restricted Project
argentite reopened D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.
Sat, May 20, 2:40 AM · Restricted Project, Restricted Project
argentite added a reverting change for rG80e7eed6a610: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl: rG0929f5b90350: Revert "[clang-repl][CUDA] Initial interactive CUDA support for clang-repl".
Sat, May 20, 2:14 AM · Restricted Project, Restricted Project
argentite committed rG0929f5b90350: Revert "[clang-repl][CUDA] Initial interactive CUDA support for clang-repl" (authored by argentite).
Revert "[clang-repl][CUDA] Initial interactive CUDA support for clang-repl"
Sat, May 20, 2:14 AM · Restricted Project, Restricted Project
argentite added a reverting change for D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl: rG0929f5b90350: Revert "[clang-repl][CUDA] Initial interactive CUDA support for clang-repl".
Sat, May 20, 2:14 AM · Restricted Project, Restricted Project
argentite committed rG80e7eed6a610: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl (authored by argentite).
[clang-repl][CUDA] Initial interactive CUDA support for clang-repl
Sat, May 20, 1:57 AM · Restricted Project, Restricted Project
argentite closed D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.
Sat, May 20, 1:57 AM · Restricted Project, Restricted Project

Tue, May 16

argentite updated the diff for D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.

Update the filenames

Tue, May 16, 11:06 AM · Restricted Project, Restricted Project

Sun, May 14

argentite updated the diff for D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.

Remove the copy of CodeGenOpts in CodeGeneratorImpl

Sun, May 14, 9:56 PM · Restricted Project, Restricted Project

Sat, May 13

argentite added inline comments to D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.
Sat, May 13, 11:09 AM · Restricted Project, Restricted Project

Fri, May 12

argentite updated the diff for D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.

Add some CUDA basic functionality tests.
Disallow undo-ing of the initial PTU. This should fix the undo command test.

Fri, May 12, 11:39 AM · Restricted Project, Restricted Project

Tue, May 9

argentite updated the diff for D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.

Added a check to run CUDA tests only on systems with CUDA. We need some ideas for the actual tests.
Rename Offload.cpp to DeviceOffload.cpp
Other syntax/style fixes

Tue, May 9, 2:46 AM · Restricted Project, Restricted Project

Apr 25 2023

argentite committed rGe037880b8eff: [clang-repl] Only enable dynamic-library test on x86_64 (authored by argentite).
[clang-repl] Only enable dynamic-library test on x86_64
Apr 25 2023, 9:19 PM · Restricted Project, Restricted Project
argentite committed rG7f96ce5e133b: [clang-repl] Fix dynamic library test to avoid cstdio and linker (authored by argentite).
[clang-repl] Fix dynamic library test to avoid cstdio and linker
Apr 25 2023, 8:49 PM · Restricted Project, Restricted Project
argentite closed D148992: [clang-repl] Fix dynamic library test to avoid cstdio and linker.
Apr 25 2023, 8:49 PM · Restricted Project, Restricted Project
argentite updated the diff for D148992: [clang-repl] Fix dynamic library test to avoid cstdio and linker.

extern "C" and enable PS4/5

Apr 25 2023, 2:27 AM · Restricted Project, Restricted Project

Apr 23 2023

argentite added inline comments to D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.
Apr 23 2023, 3:33 AM · Restricted Project, Restricted Project

Apr 22 2023

argentite added a comment to D141824: [clang-repl] Add a command to load dynamic libraries.

I made patch with both precompiled library and without cstdio. D148992

Apr 22 2023, 7:02 AM · Restricted Project, Restricted Project
argentite published D148992: [clang-repl] Fix dynamic library test to avoid cstdio and linker for review.
Apr 22 2023, 7:01 AM · Restricted Project, Restricted Project
argentite updated the diff for D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.

Use virtual file system to store CUDA fatbinaries in memory
Adapted Interpreter tests to use the CompilerBuilder

Apr 22 2023, 5:49 AM · Restricted Project, Restricted Project

Apr 17 2023

argentite added a comment to D141824: [clang-repl] Add a command to load dynamic libraries.

We should probably also address the lack of linker issue as well. Should we go for a precompiled dynamic library file? There seems to be some "precedent" of this in other tests.

Apr 17 2023, 9:51 AM · Restricted Project, Restricted Project

Apr 11 2023

argentite added inline comments to D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.
Apr 11 2023, 10:54 AM · Restricted Project, Restricted Project
argentite updated the diff for D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.

Combined IncrementalCompilerBuilder and IncrementalCudaCompilerBuilder
Added --cuda-path support
Use sys::fs::createTemporaryFile() instead of hardcoding the path
Other minor refactoring

Apr 11 2023, 10:54 AM · Restricted Project, Restricted Project

Apr 5 2023

argentite added a comment to D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl.

Initial interactive CUDA support for clang-repl

What should a user expect to be supported, functionality wise? I assume it should cover parsing and compilation. I'm not so sure about the execution. Should it be expected to actually launch kernels, or will that come in a future patch?

Apr 5 2023, 1:41 AM · Restricted Project, Restricted Project

Apr 4 2023

argentite published D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl for review.
Apr 4 2023, 8:09 AM · Restricted Project, Restricted Project

Mar 29 2023

argentite added a comment to D141824: [clang-repl] Add a command to load dynamic libraries.

Just to confirm, UNSUPPORTED: target=x86_64-scei-ps4 should be enough, right?

Mar 29 2023, 2:18 AM · Restricted Project, Restricted Project
argentite added a comment to D141824: [clang-repl] Add a command to load dynamic libraries.

Hi, @dyung ! It seems the dynamic library generation is failing from the lack of a linker. We need a test library to load at runtime in clang-repl. Do you have any idea how we can create one without a linker? Otherwise we can disable the test on PS4 as it is probably an unlikely use case.

Mar 29 2023, 12:33 AM · Restricted Project, Restricted Project

Mar 28 2023

argentite committed rG766d048d819a: [clang-repl] Use std::move when converting Error to Expected (authored by argentite).
[clang-repl] Use std::move when converting Error to Expected
Mar 28 2023, 7:54 PM · Restricted Project, Restricted Project
argentite committed rGd978730d8e2c: [clang-repl] Add a command to load dynamic libraries (authored by argentite).
[clang-repl] Add a command to load dynamic libraries
Mar 28 2023, 7:36 PM · Restricted Project, Restricted Project
argentite closed D141824: [clang-repl] Add a command to load dynamic libraries.
Mar 28 2023, 7:36 PM · Restricted Project, Restricted Project
argentite added inline comments to D141824: [clang-repl] Add a command to load dynamic libraries.
Mar 28 2023, 5:42 AM · Restricted Project, Restricted Project
argentite updated the diff for D141824: [clang-repl] Add a command to load dynamic libraries.

Changed test to use a separate Input file for the dynamic library generation

Mar 28 2023, 5:41 AM · Restricted Project, Restricted Project

Mar 21 2023

argentite updated the diff for D141824: [clang-repl] Add a command to load dynamic libraries.

Added a simple test and removed the automatic OS specific library filenames

Mar 21 2023, 10:43 AM · Restricted Project, Restricted Project

Jan 23 2023

argentite added inline comments to D141824: [clang-repl] Add a command to load dynamic libraries.
Jan 23 2023, 7:29 AM · Restricted Project, Restricted Project

Jan 16 2023

argentite published D141824: [clang-repl] Add a command to load dynamic libraries for review.
Jan 16 2023, 1:27 AM · Restricted Project, Restricted Project

Sep 28 2022

argentite committed rG5ccadb48c914: [llvm-jitlink] Remove JITLinkSlabAllocator class (authored by argentite).
[llvm-jitlink] Remove JITLinkSlabAllocator class
Sep 28 2022, 6:21 AM · Restricted Project, Restricted Project
argentite closed D134781: Remove JITLinkSlabAllocator class.
Sep 28 2022, 6:21 AM · Restricted Project, Restricted Project

Sep 27 2022

argentite published D134781: Remove JITLinkSlabAllocator class for review.
Sep 27 2022, 7:06 PM · Restricted Project, Restricted Project
argentite accepted D134774: [llvm-jitlink] Only use delta-mapper when needed, always onor slab-size..

Thanks!

Sep 27 2022, 6:50 PM · Restricted Project, Restricted Project

Sep 20 2022

argentite accepted D134212: [Orc] Fix the SharedMemoryMapper dtor.

Thanks! I forgot about this.

Sep 20 2022, 6:08 AM · Restricted Project, Restricted Project

Aug 28 2022

argentite committed rGf1aa49ad34ce: [Orc] Use MapperJITLinkMemoryManager with SharedMemoryMapper in llvm-jitlink… (authored by argentite).
[Orc] Use MapperJITLinkMemoryManager with SharedMemoryMapper in llvm-jitlink…
Aug 28 2022, 2:28 AM · Restricted Project, Restricted Project
argentite closed D132369: [Orc] Use MapperJITLinkMemoryManager with SharedMemoryMapper in llvm-jitlink tool.
Aug 28 2022, 2:28 AM · Restricted Project, Restricted Project

Aug 26 2022

argentite committed rGc69df92b4f8b: [Orc] Use MapperJITLinkMemoryManager with InProcessMapper in llvm-jitlink tool (authored by argentite).
[Orc] Use MapperJITLinkMemoryManager with InProcessMapper in llvm-jitlink tool
Aug 26 2022, 10:44 PM · Restricted Project, Restricted Project
argentite closed D132315: [Orc] Use MapperJITLinkMemoryManager with InProcessMapper in llvm-jitlink tool.
Aug 26 2022, 10:43 PM · Restricted Project, Restricted Project
argentite committed rGab492f628216: [Orc] Take offset inside slab into account in SharedMemoryMapper (authored by argentite).
[Orc] Take offset inside slab into account in SharedMemoryMapper
Aug 26 2022, 8:11 PM · Restricted Project, Restricted Project

Aug 23 2022

argentite added inline comments to rG1134d3a03fac: [Orc] Only unmap shared memory in controller process destructor.
Aug 23 2022, 7:43 PM · Restricted Project, Restricted Project

Aug 22 2022

argentite published D132369: [Orc] Use MapperJITLinkMemoryManager with SharedMemoryMapper in llvm-jitlink tool for review.
Aug 22 2022, 4:35 AM · Restricted Project, Restricted Project
argentite published D132315: [Orc] Use MapperJITLinkMemoryManager with InProcessMapper in llvm-jitlink tool for review.
Aug 22 2022, 4:35 AM · Restricted Project, Restricted Project

Aug 21 2022

argentite committed rGe309f5ebc0d7: [Orc] Improve deintialize and shutdown logic (authored by argentite).
[Orc] Improve deintialize and shutdown logic
Aug 21 2022, 4:09 AM · Restricted Project, Restricted Project
argentite committed rG0ecfee0b9eaf: [Orc] Provide correct Reservation address for slab allocations (authored by argentite).
[Orc] Provide correct Reservation address for slab allocations
Aug 21 2022, 4:09 AM · Restricted Project, Restricted Project
argentite committed rG1134d3a03fac: [Orc] Only unmap shared memory in controller process destructor (authored by argentite).
[Orc] Only unmap shared memory in controller process destructor
Aug 21 2022, 4:09 AM · Restricted Project, Restricted Project
argentite committed rG5df428eac37f: [Orc] Actually save the callback (authored by argentite).
[Orc] Actually save the callback
Aug 21 2022, 4:09 AM · Restricted Project, Restricted Project
argentite closed D132313: [Orc] Memory Mapper fixes.
Aug 21 2022, 4:08 AM · Restricted Project, Restricted Project
argentite updated the diff for D132313: [Orc] Memory Mapper fixes.

Properly base everything hopefully

Aug 21 2022, 2:41 AM · Restricted Project, Restricted Project
argentite updated the diff for D132313: [Orc] Memory Mapper fixes.

Properly rebase everything

Aug 21 2022, 2:29 AM · Restricted Project, Restricted Project

Aug 20 2022

argentite added a comment to D132313: [Orc] Memory Mapper fixes.

By the time SharedMemoryMapper destructor is called, the RPC
connection is no longer available causing the release() call to
always fail. Instead at this point only shared memory regions
can be unmapped safely.

I think that you can assert that there are no remaining allocations in the destructor -- these should all have been destroyed by a call to endSession(), which should happen before the allocator is destroyed.

Aug 20 2022, 8:27 PM · Restricted Project, Restricted Project
argentite updated the diff for D132313: [Orc] Memory Mapper fixes.

Addressed the above issues

Aug 20 2022, 8:27 PM · Restricted Project, Restricted Project
argentite published D132313: [Orc] Memory Mapper fixes for review.
Aug 20 2022, 3:17 PM · Restricted Project, Restricted Project

Aug 14 2022

argentite committed rG23d0e71fcbc4: [Orc] Use IntervalMap to store free memory regions in MapperJITLinkMemoryManager (authored by argentite).
[Orc] Use IntervalMap to store free memory regions in MapperJITLinkMemoryManager
Aug 14 2022, 2:28 AM · Restricted Project, Restricted Project
argentite closed D131831: [Orc] Use IntervalMap to store free memory regions in MapperJITLinkMemoryManager.
Aug 14 2022, 2:28 AM · Restricted Project, Restricted Project

Aug 13 2022

argentite published D131831: [Orc] Use IntervalMap to store free memory regions in MapperJITLinkMemoryManager for review.
Aug 13 2022, 4:39 AM · Restricted Project, Restricted Project
argentite committed rGa31af3218385: Reapply [Orc] Properly deallocate mapped memory in MapperJITLinkMemoryManager (authored by argentite).
Reapply [Orc] Properly deallocate mapped memory in MapperJITLinkMemoryManager
Aug 13 2022, 12:40 AM · Restricted Project, Restricted Project

Aug 12 2022

argentite added a reverting change for rG143555b2ed30: [Orc] Properly deallocate mapped memory in MapperJITLinkMemoryManager: rG8180105143dc: Revert "[Orc] Properly deallocate mapped memory in MapperJITLinkMemoryManager".
Aug 12 2022, 9:53 PM · Restricted Project, Restricted Project
argentite committed rG8180105143dc: Revert "[Orc] Properly deallocate mapped memory in MapperJITLinkMemoryManager" (authored by argentite).
Revert "[Orc] Properly deallocate mapped memory in MapperJITLinkMemoryManager"
Aug 12 2022, 9:53 PM · Restricted Project, Restricted Project
argentite added a reverting change for D131768: [Orc] Properly deallocate mapped memory in MapperJITLinkMemoryManager: rG8180105143dc: Revert "[Orc] Properly deallocate mapped memory in MapperJITLinkMemoryManager".
Aug 12 2022, 9:53 PM · Restricted Project, Restricted Project
argentite committed rG143555b2ed30: [Orc] Properly deallocate mapped memory in MapperJITLinkMemoryManager (authored by argentite).
[Orc] Properly deallocate mapped memory in MapperJITLinkMemoryManager
Aug 12 2022, 9:43 PM · Restricted Project, Restricted Project
argentite closed D131768: [Orc] Properly deallocate mapped memory in MapperJITLinkMemoryManager.
Aug 12 2022, 9:43 PM · Restricted Project, Restricted Project
argentite published D131768: [Orc] Properly deallocate mapped memory in MapperJITLinkMemoryManager for review.

We are resetting permissions to read/write in InProcessMapper::deinitialize(). It may make sense to set them to read/write in InProcessMapper::prepare() instead. But in that case extra syscalls are made during startup instead of shutdown.

Aug 12 2022, 6:23 AM · Restricted Project, Restricted Project

Aug 11 2022

argentite committed rG0aaa74f7e6e5: [Orc] Reorder operations in ExecutorSharedMemoryMapperService shutdown (authored by argentite).
[Orc] Reorder operations in ExecutorSharedMemoryMapperService shutdown
Aug 11 2022, 7:05 AM · Restricted Project, Restricted Project
argentite closed D131510: [Orc] Reorder operations in ExecutorSharedMemoryMapperService shutdown.
Aug 11 2022, 7:05 AM · Restricted Project, Restricted Project

Aug 9 2022

argentite added inline comments to D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper.
Aug 9 2022, 10:37 AM · Restricted Project, Restricted Project
argentite published D131510: [Orc] Reorder operations in ExecutorSharedMemoryMapperService shutdown for review.

This should fix https://reviews.llvm.org/D128544#3710127 but I think we may not even need the lock at all since this is called only at shutdown.

Aug 9 2022, 10:37 AM · Restricted Project, Restricted Project

Aug 8 2022

argentite committed rG1eee6de87397: [Orc][JITLink] Slab based memory allocator to reduce RPC calls (authored by argentite).
[Orc][JITLink] Slab based memory allocator to reduce RPC calls
Aug 8 2022, 2:44 AM · Restricted Project, Restricted Project
argentite closed D130392: [Orc][JITLink] Slab based memory allocator to reduce RPC calls.
Aug 8 2022, 2:44 AM · Restricted Project, Restricted Project

Aug 7 2022

argentite added inline comments to D130392: [Orc][JITLink] Slab based memory allocator to reduce RPC calls.
Aug 7 2022, 5:19 AM · Restricted Project, Restricted Project
argentite updated the diff for D130392: [Orc][JITLink] Slab based memory allocator to reduce RPC calls.

Remove address space size check and improve comments

Aug 7 2022, 5:12 AM · Restricted Project, Restricted Project

Aug 3 2022

argentite accepted D131055: [ORC] Fix a warning about an unused variable on Windows. NFC..

Thanks for the fix.

Aug 3 2022, 10:16 AM · Restricted Project, Restricted Project
argentite accepted D131056: [ORC] Actually propagate memory unmapping errors on Windows.

That was a mistake, Thanks.

Aug 3 2022, 10:09 AM · Restricted Project, Restricted Project

Aug 1 2022

argentite committed rGac3cb4ecd0c6: [Orc] Disable use of shared memory on Android (authored by argentite).
[Orc] Disable use of shared memory on Android
Aug 1 2022, 6:21 AM · Restricted Project, Restricted Project
argentite closed D130814: [Orc] Disable use of shared memory on Android.
Aug 1 2022, 6:21 AM · Restricted Project, Restricted Project

Jul 30 2022

argentite updated the diff for D130814: [Orc] Disable use of shared memory on Android.

Something like LLVM_ORC_SHARED_MAPPER_SUPPORTED would be nice and maybe we can even define it from the build system. In any case it should be a follow up patch I guess.

Jul 30 2022, 6:31 PM · Restricted Project, Restricted Project

Jul 29 2022

argentite requested review of D130814: [Orc] Disable use of shared memory on Android.
Jul 29 2022, 6:38 PM · Restricted Project, Restricted Project

Jul 28 2022

argentite published D130392: [Orc][JITLink] Slab based memory allocator to reduce RPC calls for review.
Jul 28 2022, 4:34 AM · Restricted Project, Restricted Project

Jul 21 2022

argentite committed rGab3650d80d49: [NFC] Empty commit to test commit access (authored by argentite).
[NFC] Empty commit to test commit access
Jul 21 2022, 11:04 AM

Jul 20 2022

argentite added reviewers for D129495: [Orc][JITLink] JITLinkMemoryManager implementation using MemoryMapper: lhames, sgraenitz.
Jul 20 2022, 1:55 PM · Restricted Project, Restricted Project
argentite updated the diff for D129495: [Orc][JITLink] JITLinkMemoryManager implementation using MemoryMapper.

Added support for new SharedMemoryMapper

Jul 20 2022, 1:54 PM · Restricted Project, Restricted Project

Jul 18 2022

argentite updated the diff for D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper.

Use new SharedMemorySegFinalizeRequest instead of SegFinalizeRequest

Jul 18 2022, 7:40 AM · Restricted Project, Restricted Project
argentite reopened D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper.
Jul 18 2022, 7:36 AM · Restricted Project, Restricted Project

Jul 14 2022

argentite updated the diff for D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper.

Link with librt if available

Jul 14 2022, 5:15 AM · Restricted Project, Restricted Project
argentite reopened D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper.
Jul 14 2022, 5:15 AM · Restricted Project, Restricted Project

Jul 13 2022

argentite added a comment to D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper.

Hi! I am not very familiar with powerpc but it seems like POSIX shared memory APIs should be available.
From this page I suspect shm_ family of functions could be in librt instead of libc.

Jul 13 2022, 11:45 PM · Restricted Project, Restricted Project
argentite updated the diff for D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper.

Skip the test on unimplemented operating systems

Jul 13 2022, 6:25 AM · Restricted Project, Restricted Project

Jul 11 2022

argentite requested review of D129495: [Orc][JITLink] JITLinkMemoryManager implementation using MemoryMapper.
Jul 11 2022, 8:51 AM · Restricted Project, Restricted Project

Jul 5 2022

argentite updated the diff for D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper.

Replaced some llvm_unreachable() with llvm::Error

Jul 5 2022, 11:58 PM · Restricted Project, Restricted Project

Jul 1 2022

argentite updated the diff for D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper.

Added explicit cast from size_t to uint64_t

Jul 1 2022, 11:23 AM · Restricted Project, Restricted Project