[mlir] Deprecate OptionalParseResult::{hasValue,getValue}

[kazu]

Summary

This patch deprecates hasValue and getValue for consistency with
std::optional and llvm::Optional. Note that I've migrated all known
uses of them to has_value and value, respectively.

[kazu]

Updated to use LLVM_DEPRECATED instead of [[deprecated]].

[kazu]

PTAL. Thanks!

[rriddle]

How bad would it be just to remove uses of these methods? It'd be nice to avoid the intermediate warning spam that comes along with these.

[rriddle]

Ah, I see the comment says you removed all known uses. What is the removal timeline for these methods?

[kazu]

In D131366#3716558, @rriddle wrote:

Ah, I see the comment says you removed all known uses. What is the removal timeline for these methods?

I am thinking about 3 months or so to accommodate downstream users and other patches landing nearly at the same time.

[rriddle]

In D131366#3716711, @kazu wrote:

In D131366#3716558, @rriddle wrote:

Ah, I see the comment says you removed all known uses. What is the removal timeline for these methods?

I am thinking about 3 months or so to accommodate downstream users and other patches landing nearly at the same time.

That seems like a huge lead time for something not really heavily used. I'd honestly rather remove it earlier than that, but LGTM for marking it for now.

mlir/include/mlir/IR/OpDefinition.h

public:
   OptionalParseResult(LogicalResult result) : impl(result) {}
   OptionalParseResult(ParseResult result) : impl(result) {}
   OptionalParseResult(const InFlightDiagnostic &)
       : OptionalParseResult(failure()) {}
   OptionalParseResult(llvm::NoneType) : impl(llvm::None) {}
 
   /// Returns true if we contain a valid ParseResult value.
   bool has_value() const { return impl.has_value(); }
-  bool hasValue() const { return impl.has_value(); }
+  LLVM_DEPRECATED("Use has_value instead", "has_value") bool hasValue() const {
+    return impl.has_value();
+  }
 
   /// Access the internal ParseResult value.
   ParseResult value() const { return impl.value(); }
-  ParseResult getValue() const { return impl.value(); }
+  LLVM_DEPRECATED("Use value instead", "value") ParseResult getValue() const {
+    return impl.value();
+  }
   ParseResult operator*() const { return value(); }
 
 private:
   Optional<ParseResult> impl;
 };
 
 // These functions are out-of-line utilities, which avoids them being template
 // instantiated/duplicated.