Implements part of P1614R2 "The Mothership has Landed"
Details
Details
- Reviewers
ldionne Mordante philnik mumbleskates fsb4000 - Group Reviewers
Restricted Project - Commits
- rG9df58928045f: [libc++] Implement `operator<=>` for `type_index`
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
LGTM modulo some nits. I think the CI failures are unrelated, but please update the review for a CI iteration.
I want to have a quick look after the update.
libcxx/include/typeindex | ||
---|---|---|
97 | ||
98 | Please run clang-format on these changes. | |
libcxx/test/std/utilities/type.index/type.index.members/cmp.pass.cpp | ||
49 | We use snake-case in our tests. |
libcxx/test/std/utilities/type.index/type.index.members/cmp.pass.cpp | ||
---|---|---|
49 | only for variable names or also for function names? |
Comment Actions
LGTM, thanks!
libcxx/test/std/utilities/type.index/type.index.members/cmp.pass.cpp | ||
---|---|---|
49 | Both, but we're not always consistent ;-) |