This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Implement `operator<=>` for `type_index`
ClosedPublic

Authored by avogelsgesang on Aug 7 2022, 8:40 AM.

Details

Summary

Implements part of P1614R2 "The Mothership has Landed"

Diff Detail

Event Timeline

avogelsgesang created this revision.Aug 7 2022, 8:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2022, 8:40 AM
Herald added a subscriber: arphaman. · View Herald Transcript
avogelsgesang requested review of this revision.Aug 7 2022, 8:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2022, 8:40 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

update review link

actually check results in test case

LGTM modulo some nits. I think the CI failures are unrelated, but please update the review for a CI iteration.
I want to have a quick look after the update.

libcxx/include/typeindex
97
98

Please run clang-format on these changes.

libcxx/test/std/utilities/type.index/type.index.members/cmp.pass.cpp
49

We use snake-case in our tests.

avogelsgesang added inline comments.Aug 8 2022, 10:34 AM
libcxx/test/std/utilities/type.index/type.index.members/cmp.pass.cpp
49

only for variable names or also for function names?

avogelsgesang marked 3 inline comments as done.

address @Mordante's comments

Mordante accepted this revision.Aug 9 2022, 10:31 AM

LGTM, thanks!

libcxx/test/std/utilities/type.index/type.index.members/cmp.pass.cpp
49

Both, but we're not always consistent ;-)

This revision is now accepted and ready to land.Aug 9 2022, 10:31 AM
This revision was landed with ongoing or failed builds.Aug 9 2022, 4:35 PM
This revision was automatically updated to reflect the committed changes.
libcxx/test/std/utilities/type.index/type.index.members/eq.pass.cpp