This is an archive of the discontinued LLVM Phabricator instance.

Differential D131236

[llvm][ir][NFC] Clean up "if after return" in ProfDataUtils.cpp
ClosedPublic

Authored by paulkirth on Aug 4 2022, 8:37 PM.

Details

Reviewers
phosek
davidxl
bogner
tejohnson
Commits
rGdeef5b8c0d69: [llvm][ir][NFC] Clean up "if after return" in ProfDataUtils.cpp

Diff Detail

Unit TestsFailed

TimeTest
60,120 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp

Event Timeline

paulkirth created this revision.Aug 4 2022, 8:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2022, 8:37 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
paulkirth requested review of this revision.Aug 4 2022, 8:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2022, 8:37 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B179463: Diff 450220.Aug 4 2022, 9:22 PM
tejohnson accepted this revision.Aug 26 2022, 9:12 AM
tejohnson added a subscriber: tejohnson.

lgtm

This revision is now accepted and ready to land.Aug 26 2022, 9:12 AM
This revision was landed with ongoing or failed builds.Aug 26 2022, 1:27 PM
Closed by commit rGdeef5b8c0d69: [llvm][ir][NFC] Clean up "if after return" in ProfDataUtils.cpp (authored by paulkirth). · Explain Why
This revision was automatically updated to reflect the committed changes.
paulkirth added a commit: rGdeef5b8c0d69: [llvm][ir][NFC] Clean up "if after return" in ProfDataUtils.cpp.

Revision Contents

PathSize
llvm/
lib/
IR/
6 lines

Diff 450220

llvm/lib/IR/ProfDataUtils.cpp

Show First 20 Lines • Show All 131 Lines • ▼ Show 20 Linesbool extractProfTotalWeight(const MDNode *ProfileData, uint64_t &TotalVal) {
if (ProfDataName->getString().equals("branch_weights")) { if (ProfDataName->getString().equals("branch_weights")) {
for (unsigned Idx = 1; Idx < ProfileData->getNumOperands(); Idx++) { for (unsigned Idx = 1; Idx < ProfileData->getNumOperands(); Idx++) {
auto *V = mdconst::dyn_extract<ConstantInt>(ProfileData->getOperand(Idx)); auto *V = mdconst::dyn_extract<ConstantInt>(ProfileData->getOperand(Idx));
assert(V && "Malformed branch_weight in MD_prof node"); assert(V && "Malformed branch_weight in MD_prof node");
TotalVal += V->getValue().getZExtValue(); TotalVal += V->getValue().getZExtValue();
} }
return true; return true;
} else if (ProfDataName->getString().equals("VP") && }
if (ProfDataName->getString().equals("VP") &&
ProfileData->getNumOperands() > 3) { ProfileData->getNumOperands() > 3) {
TotalVal = mdconst::dyn_extract<ConstantInt>(ProfileData->getOperand(2)) TotalVal = mdconst::dyn_extract<ConstantInt>(ProfileData->getOperand(2))
->getValue() ->getValue()
.getZExtValue(); .getZExtValue();
return true; return true;
} }
return false; return false;
} }
} // namespace llvm } // namespace llvm