This is an archive of the discontinued LLVM Phabricator instance.

[X86] Using `X86MemOperand` instead of `Operand` for `i32mem_TC` and `i64mem_TC`
ClosedPublic

Authored by LiuChen3 on Aug 2 2022, 11:42 PM.

Details

Summary

To fix build fail when X86_GEN_FOLD_TABLES is enabled.

Diff Detail

Event Timeline

LiuChen3 created this revision.Aug 2 2022, 11:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2022, 11:42 PM
LiuChen3 requested review of this revision.Aug 2 2022, 11:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2022, 11:42 PM
pengfei accepted this revision.Aug 3 2022, 12:23 AM

LGTM.

This revision is now accepted and ready to land.Aug 3 2022, 12:23 AM
skan added a comment.Aug 3 2022, 12:49 AM

Remove NFC in the title? I think this patch is used to fix the build error for auto-generating X86 memory folding table.

Remove NFC in the title? I think this patch is used to fix the build error for auto-generating X86 memory folding table.

Yes, this is for fixing build fail. I am fine with removing NFC.

LiuChen3 retitled this revision from [X86][NFC] Using `X86MemOperand` instead of `Operand` for `i32mem_TC` and `i64mem_TC` to [X86] Using `X86MemOperand` instead of `Operand` for `i32mem_TC` and `i64mem_TC`.Aug 3 2022, 1:12 AM
LiuChen3 edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Aug 3 2022, 1:18 AM
This revision was automatically updated to reflect the committed changes.