Page MenuHomePhabricator

[clang][dataflow] Make the type of the post visit callback consistent
ClosedPublic

Authored by sgatev on Aug 2 2022, 1:01 PM.

Details

Summary

Make the types of the post visit callbacks in transferBlock and runTypeErasedDataflowAnalysis consistent.

Diff Detail

Event Timeline

sgatev created this revision.Aug 2 2022, 1:01 PM
Herald added a project: Restricted Project. · View Herald Transcript
sgatev requested review of this revision.Aug 2 2022, 1:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2022, 1:01 PM
sgatev updated this revision to Diff 449398.Aug 2 2022, 1:03 PM

Update commit message

sgatev edited the summary of this revision. (Show Details)Aug 2 2022, 1:03 PM
xazax.hun accepted this revision.Aug 2 2022, 2:13 PM
This revision is now accepted and ready to land.Aug 2 2022, 2:13 PM

Seems reasonable 👍 I'm curious though, why does this not require clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp to be updated?

sgatev updated this revision to Diff 449449.Aug 2 2022, 2:49 PM

Address comments

Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2022, 2:49 PM
sgatev added a comment.Aug 2 2022, 2:50 PM

Seems reasonable 👍 I'm curious though, why does this not require clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp to be updated?

It does, thanks! Fixed.

gribozavr2 accepted this revision.Aug 2 2022, 2:51 PM
ymandel accepted this revision.Aug 2 2022, 5:59 PM
This revision was landed with ongoing or failed builds.Aug 2 2022, 10:59 PM
This revision was automatically updated to reflect the committed changes.