This is an archive of the discontinued LLVM Phabricator instance.

Added warning about outdated feature into Kaleidoscope tutorial text
ClosedPublic

Authored by DKay7 on Jul 26 2022, 9:31 PM.

Details

Summary

Motivation: I have been studying LLVM with LLVM Kaleidoscope tutorial. In the 4th part I faced an error which said that I can't redefine a function as shown in the tutorial. After hours of searching, I finally found the reason that produced the error is that the feature of symbols redefinition has been disabled since LLVM-9. There was no information about that in the tutorial's text, so I've decided to add a warning.

Changes: The only file I fixed is "llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl04.rst", I added text warning which says that described feature is outdated and the described functionality will not work properly on LLVM versions older 8 one.

Diff Detail

Event Timeline

DKay7 created this revision.Jul 26 2022, 9:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2022, 9:31 PM
DKay7 requested review of this revision.Jul 26 2022, 9:31 PM
xgupta added subscribers: sunho, lhames.

LGTM, though @sunho or @lhames would be in better position to accept the patch.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 7 2022, 2:07 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.