This is an archive of the discontinued LLVM Phabricator instance.

Differential D130185

[flang][nfc] Add missing `REQUIRES: asserts` in tests
ClosedPublic

Authored by awarzynski on Jul 20 2022, 10:14 AM.

Details

Reviewers
rovka
tarunprabhu
kiranchandramohan
vzakhari
Commits
rG7c49f56956eb: [flang][nfc] Add missing `REQUIRES: asserts` in tests
Summary

Tests that use --mlir-pass-statistics-display= from MLIR require the
following condition to hold: (extracted from LLVM's Statistics.h):

#define LLVM_ENABLE_STATS 1

This is normally enforced with REQUIRES: asserts. This patch updates
relevant Flang tests accordingly.

For "Release" builds (with assertions disabled), the affected tests will
be failing without this change.

Diff Detail

Event Timeline

awarzynski created this revision.Jul 20 2022, 10:14 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 20 2022, 10:14 AM
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 18 others. · View Herald Transcript
awarzynski requested review of this revision.Jul 20 2022, 10:14 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache, jdoerfert. · View Herald TranscriptJul 20 2022, 10:14 AM
tarunprabhu accepted this revision.Jul 20 2022, 10:20 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Jul 20 2022, 10:20 AM
Harbormaster completed remote builds in B176541: Diff 446198.Jul 20 2022, 10:45 AM
Closed by commit rG7c49f56956eb: [flang][nfc] Add missing `REQUIRES: asserts` in tests (authored by awarzynski). · Explain WhyJul 21 2022, 2:23 AM
This revision was automatically updated to reflect the committed changes.
awarzynski added a commit: rG7c49f56956eb: [flang][nfc] Add missing `REQUIRES: asserts` in tests.
awarzynski mentioned this in rG640c0ad0d580: [flang][nfc] Add missing `REQUIRES: asserts` in a test.Jul 25 2022, 9:30 AM

Revision Contents

PathSize
flang/
test/
Driver/
3 lines
Fir/
2 lines

Diff 446397

flang/test/Driver/mlir-pass-pipeline.f90

! Test the MLIR pass pipeline ! Test the MLIR pass pipeline
! RUN: %flang_fc1 -S -mmlir --mlir-pass-statistics -mmlir --mlir-pass-statistics-display=pipeline %s -o - 2>&1 | FileCheck %s ! RUN: %flang_fc1 -S -mmlir --mlir-pass-statistics -mmlir --mlir-pass-statistics-display=pipeline %s -o - 2>&1 | FileCheck %s
! REQUIRES: asserts
end program end program
! CHECK: Pass statistics report ! CHECK: Pass statistics report
! CHECK: CSE ! CHECK: CSE
! CHECK-LABEL: 'func.func' Pipeline ! CHECK-LABEL: 'func.func' Pipeline
! CHECK: ArrayValueCopy ! CHECK: ArrayValueCopy
! CHECK: CharacterConversion ! CHECK: CharacterConversion
Show All 24 Lines

flang/test/Fir/basic-program.fir

// RUN: tco %s | FileCheck %s // RUN: tco %s | FileCheck %s
// RUN: tco %s --mlir-pass-statistics --mlir-pass-statistics-display=pipeline 2>&1 | FileCheck %s --check-prefix=PASSES // RUN: tco %s --mlir-pass-statistics --mlir-pass-statistics-display=pipeline 2>&1 | FileCheck %s --check-prefix=PASSES
// REQUIRES: asserts
// Check that tco is working with a basic test. // Check that tco is working with a basic test.
// Also check the passes in the default pipeline. // Also check the passes in the default pipeline.
func.func @_QQmain() { func.func @_QQmain() {
return return
} }
// CHECK: ; ModuleID = 'FIRModule' // CHECK: ; ModuleID = 'FIRModule'
Show All 32 Lines